From c6365df81832b7d2da8906bb88afbdfe01e639f6 Mon Sep 17 00:00:00 2001 From: Charlie Gilman Date: Thu, 19 Nov 2026 15:01:34 +0000 Subject: [PATCH 1/5] APP-569: Upgrade pnpm 11 to pnpm 12 Pin pnpm 12.21.0 via pnpm self-update. The lockfile change is only pnpm's own pin: packageManagerDependencies now records pnpm 12's per-platform native binaries instead of @pnpm/exe 11. No dependency versions moved. Co-Authored-By: Claude Opus 5.5 --- package.json | 2 +- pnpm-lock.yaml | 204 +++++++++++++++++++++---------------------------- 2 files changed, 87 insertions(+), 119 deletions(-) diff --git a/package.json b/package.json index 6ea42d07e5..67de470aad 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "version": "1.0.0", "private": true, "type": "commonjs", - "packageManager": "pnpm@11.10.0+sha512.0b7f8b98060031904c017e3a41eb187a16d40eeb829b95c4f8cb03681761fc4ab53dd219115b9b447f4dce1a05a214764461e7d3703392a9f32f9511ce8c86c8", + "packageManager": "pnpm@12.21.0", "engines": { "node": "24.22.3", "runtime": { diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index ab0027dca8..4f1bec7549 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -6,195 +6,163 @@ importers: .: configDependencies: {} packageManagerDependencies: - '@pnpm/exe': - specifier: 11.10.0 - version: 11.10.0 pnpm: - specifier: 11.10.0 - version: 11.10.0 + specifier: 12.21.0 + version: 12.21.0 packages: - '@pnpm/exe@11.10.0': - resolution: {integrity: sha512-mrmfi2C7LpZkyq0voKKye6MzrK8/K7tYQRiSB/jqOiwnFtQxxcA3xGTY9cEsrGpNl2ClPecQofLuj+BO8AIsxw==} - hasBin: true - - '@pnpm/linux-arm64@11.10.0': - resolution: {integrity: sha512-NbvDeUfs0SJuli9OPvgVvmnlbo2DvJ861XGXKrzgLu5AuTnLDLXgbZEEUd8mJ5I0YNrqOVXSWVfWEqiAazWzPA==} + '@pnpm/exe.android-arm64@12.21.0': + resolution: {integrity: sha512-iaWidxR5B9NUBpwMznCQu1yUpKB6BjTY5BYX2lORj76VsfINdj8Z8XWSzSNrGI8qlxa28Jzdp5fiaspzOaJZlA==} cpu: [arm64] - os: [linux] + os: [android] - '@pnpm/linux-x64@11.10.0': - resolution: {integrity: sha512-kdgb8BXZ/3XQ0x2cOmgLmsij7+SUIqd1bcV6OZhdGzQiDrOY6FAPrR+Y2Bp+NjrrhjzMHVm5pZrrmdeC67ymSQ==} + '@pnpm/exe.android-x64@12.21.0': + resolution: {integrity: sha512-35e5v3wlwjIYxDywq+R6/z8CE4gLOEgRxt18yqz1tMRLmx2mnW+CFJI2Q8+srTNjn7gykXUC0x1k195JNikC5A==} cpu: [x64] - os: [linux] + os: [android] - '@pnpm/linuxstatic-arm64@11.10.0': - resolution: {integrity: sha512-JE1WrSyKGvqGQgWzqrMXn//ehedpiRax3hi1oP+v6mhvcnlJD1lpfXsjSfIFl9weTWC5KVtFbxSNKbKWfP+v6g==} + '@pnpm/exe.darwin-arm64@12.21.0': + resolution: {integrity: sha512-F5OyMX/6zLSowpTZEQRojbCmPS1Pq+fyRaIinslsIe6Glh3qbyQ52u+Fe0eEzSaRuIbWZkXmAAXSWh6Q5Wrlgg==} cpu: [arm64] - os: [linux] - libc: [musl] + os: [darwin] - '@pnpm/linuxstatic-x64@11.10.0': - resolution: {integrity: sha512-1TBZVRkWb78GnsusIfVgwz20MOOW0fyehW+qLL3MxE9vT0IedNWsAhe3KWXgEvtC4M7NtMt55uQQJm+1egwBkA==} + '@pnpm/exe.darwin-x64@12.21.0': + resolution: {integrity: sha512-EzpvcsaE6hrrgYeEiAFYd2rSgFybYyxXhkAY7K3y6Hg3loVfcyJ81hHczpFzi8lW5RXtUlFECRPZ8ZAMRFQYYg==} cpu: [x64] - os: [linux] - libc: [musl] - - '@pnpm/macos-arm64@11.10.0': - resolution: {integrity: sha512-94AVpPixBqyNT6SHYvIKFb1bfaHR5vxBzZsiFJahNSlGkgyPrgzmcqDiloZ/Jl+zxJd8L5PU1ddP0Q9PZnRqlA==} - cpu: [arm64] os: [darwin] - '@pnpm/win-arm64@11.10.0': - resolution: {integrity: sha512-g2Ymnq+LgVyZaWsGBQSlpIcBCOOxyLky2UX+kTwGiIXnj6k/xXqZR0ZJLuxeiGNh/CVmhftOqokpyJNzyj8kng==} - cpu: [arm64] - os: [win32] - - '@pnpm/win-x64@11.10.0': - resolution: {integrity: sha512-kCHYZudUEBjrEchgnJUnNHCdvLXpUZun2z0rMAeP5DymsaXwEVvVzGj220iR/NyhgDocJUmgtTKtwL/ejL785Q==} + '@pnpm/exe.freebsd-x64@12.21.0': + resolution: {integrity: sha512-wNjuEnmdLks4aayPu/QZWQ5tQM9Jn+odUp/vwQM8BXRYoulkTZhtZTHoD60N6mUdLWef1hgUeUh8llNGEUsimw==} cpu: [x64] - os: [win32] + os: [freebsd] - '@reflink/reflink-darwin-arm64@0.1.19': - resolution: {integrity: sha512-ruy44Lpepdk1FqDz38vExBY/PVUsjxZA+chd9wozjUH9JjuDT/HEaQYA6wYN9mf041l0yLVar6BCZuWABJvHSA==} - engines: {node: '>= 10'} + '@pnpm/exe.linux-arm64-musl@12.21.0': + resolution: {integrity: sha512-Ceit9zn4g5ZqCJtx1fV8eJE7p8aeXMrGZ+Dc01vRqZLIUNgNeI+Ur0ruyqxtsnJx6rGADyXzohumxPLHjaJ5AQ==} cpu: [arm64] - os: [darwin] - - '@reflink/reflink-darwin-x64@0.1.19': - resolution: {integrity: sha512-By85MSWrMZa+c26TcnAy8SDk0sTUkYlNnwknSchkhHpGXOtjNDUOxJE9oByBnGbeuIE1PiQsxDG3Ud+IVV9yuA==} - engines: {node: '>= 10'} - cpu: [x64] - os: [darwin] + os: [linux] + libc: [musl] - '@reflink/reflink-linux-arm64-gnu@0.1.19': - resolution: {integrity: sha512-7P+er8+rP9iNeN+bfmccM4hTAaLP6PQJPKWSA4iSk2bNvo6KU6RyPgYeHxXmzNKzPVRcypZQTpFgstHam6maVg==} - engines: {node: '>= 10'} + '@pnpm/exe.linux-arm64@12.21.0': + resolution: {integrity: sha512-4Oj/iF2TDCe2lcH0n4TupPR5sSdrNLclJB6xBElLMPCUOAvBhdf2rRlSaO5M4erJ6g4Fyy7YTXTpcmfFsKyxEA==} cpu: [arm64] os: [linux] libc: [glibc] - '@reflink/reflink-linux-arm64-musl@0.1.19': - resolution: {integrity: sha512-37iO/Dp6m5DDaC2sf3zPtx/hl9FV3Xze4xoYidrxxS9bgP3S8ALroxRK6xBG/1TtfXKTvolvp+IjrUU6ujIGmA==} - engines: {node: '>= 10'} - cpu: [arm64] + '@pnpm/exe.linux-ppc64@12.21.0': + resolution: {integrity: sha512-s2o7rdSDeUTBFsNqxptpZXlTgT6cojmMVUOvTQvFNSv6Easian02ha4tR32fwwD97Au4YzIIjMCwywCF4D82Sw==} + cpu: [ppc64] os: [linux] - libc: [musl] + libc: [glibc] - '@reflink/reflink-linux-x64-gnu@0.1.19': - resolution: {integrity: sha512-jbI8jvuYCaA3MVUdu8vLoLAFqC+iNMpiSuLbxlAgg7x3K5bsS8nOpTRnkLF7vISJ+rVR8W+7ThXlXlUQ93ulkw==} - engines: {node: '>= 10'} - cpu: [x64] + '@pnpm/exe.linux-riscv64@12.21.0': + resolution: {integrity: sha512-EYv3GzxeBTITCuM3yGHHbpRFpUvyulkXpQ6LsjKAQNL3iaba1E6h9iDmlouLb3Io4AMMsfdk0/uG6poQ41uewA==} + cpu: [riscv64] os: [linux] libc: [glibc] - '@reflink/reflink-linux-x64-musl@0.1.19': - resolution: {integrity: sha512-e9FBWDe+lv7QKAwtKOt6A2W/fyy/aEEfr0g6j/hWzvQcrzHCsz07BNQYlNOjTfeytrtLU7k449H1PI95jA4OjQ==} - engines: {node: '>= 10'} + '@pnpm/exe.linux-s390x@12.21.0': + resolution: {integrity: sha512-8VXGNGVNEfs7pL9GTZOzFxjFEnMt4WL3rLOADR5/kPQ7ROTV9GfpVI2DPO/zArXFSkvfc9Zad/WypHLbvzoaTQ==} + cpu: [s390x] + os: [linux] + libc: [glibc] + + '@pnpm/exe.linux-x64-musl@12.21.0': + resolution: {integrity: sha512-MnC5vpIXYubhDZCgCwlfJMg7Cg6HupN2IuouT9gD/tUmOfVdQYqeyYccWbthyo/Jeto8de1oQlxeRN1+1Hl2DQ==} cpu: [x64] os: [linux] libc: [musl] - '@reflink/reflink-win32-arm64-msvc@0.1.19': - resolution: {integrity: sha512-09PxnVIQcd+UOn4WAW73WU6PXL7DwGS6wPlkMhMg2zlHHG65F3vHepOw06HFCq+N42qkaNAc8AKIabWvtk6cIQ==} - engines: {node: '>= 10'} + '@pnpm/exe.linux-x64@12.21.0': + resolution: {integrity: sha512-8eufCjHXspKbNS/kh8q4Q0gqJoOuvC4Q5pgos6XS8By/nAMtP+jf8F1Cw9er840kfAX+PJ/ts+A9qnLE91rvXQ==} + cpu: [x64] + os: [linux] + libc: [glibc] + + '@pnpm/exe.netbsd-x64@12.21.0': + resolution: {integrity: sha512-eyh1M8hQZCkLWxuva7S/fc1SbFbgqg0/5di0dgWmyiuc2Io3dbWVihDun8X+XM8zsR5uhIDvvZpbS9aZQbCovg==} + cpu: [x64] + os: [netbsd] + + '@pnpm/exe.win32-arm64@12.21.0': + resolution: {integrity: sha512-7xTxxUXo/grRLivSeIl6B21gnsz7ooe5EMPcJmQqwxc8WLJVReN8MzrlHru8bqXfVr4X3+6ZGZscntKenlCBqQ==} cpu: [arm64] os: [win32] - '@reflink/reflink-win32-x64-msvc@0.1.19': - resolution: {integrity: sha512-E//yT4ni2SyhwP8JRjVGWr3cbnhWDiPLgnQ66qqaanjjnMiu3O/2tjCPQXlcGc/DEYofpDc9fvhv6tALQsMV9w==} - engines: {node: '>= 10'} + '@pnpm/exe.win32-x64@12.21.0': + resolution: {integrity: sha512-9TpkJemVApxJ1Z1w0ZFGN+AuSx4nJOqXSJUqMqDvaXTYwGOzvBiiWdFP9GN0ketiWCQS1Q0/pza2E7I3pP0OBQ==} cpu: [x64] os: [win32] - '@reflink/reflink@0.1.19': - resolution: {integrity: sha512-DmCG8GzysnCZ15bres3N5AHCmwBwYgp0As6xjhQ47rAUTUXxJiK+lLUxaGsX3hd/30qUpVElh05PbGuxRPgJwA==} - engines: {node: '>= 10'} - - detect-libc@2.1.2: - resolution: {integrity: sha512-Btj2BOOO83o3WyH59e8MgXsxEQVcarkUOpEYrubB0urwnN10yQ364rsiByU11nZlqWYZm05i/of7io4mzihBtQ==} - engines: {node: '>=8'} - - pnpm@11.10.0: - resolution: {integrity: sha512-C3+LmAYAMZBMAX46QesYehbUDuuCm5XE+MsDaBdh/Eq1PdIZEVubRH9NzhoFohR2RGHn03AzkqnzL5URzoyGyA==} - engines: {node: '>=22.13'} + pnpm@12.21.0: + resolution: {integrity: sha512-Zv2CeO4ok1zpUXktNDZ/869cQyonVkRYIwKVM4NbjaUpu+C+UTCv1W7QcT+4eJ5Hutgtk71a4v5UsVVi1idu8A==} + engines: {node: '>=18'} hasBin: true snapshots: - '@pnpm/exe@11.10.0': - dependencies: - '@reflink/reflink': 0.1.19 - detect-libc: 2.1.2 - optionalDependencies: - '@pnpm/linux-arm64': 11.10.0 - '@pnpm/linux-x64': 11.10.0 - '@pnpm/linuxstatic-arm64': 11.10.0 - '@pnpm/linuxstatic-x64': 11.10.0 - '@pnpm/macos-arm64': 11.10.0 - '@pnpm/win-arm64': 11.10.0 - '@pnpm/win-x64': 11.10.0 - - '@pnpm/linux-arm64@11.10.0': + '@pnpm/exe.android-arm64@12.21.0': optional: true - '@pnpm/linux-x64@11.10.0': + '@pnpm/exe.android-x64@12.21.0': optional: true - '@pnpm/linuxstatic-arm64@11.10.0': + '@pnpm/exe.darwin-arm64@12.21.0': optional: true - '@pnpm/linuxstatic-x64@11.10.0': + '@pnpm/exe.darwin-x64@12.21.0': optional: true - '@pnpm/macos-arm64@11.10.0': + '@pnpm/exe.freebsd-x64@12.21.0': optional: true - '@pnpm/win-arm64@11.10.0': + '@pnpm/exe.linux-arm64-musl@12.21.0': optional: true - '@pnpm/win-x64@11.10.0': + '@pnpm/exe.linux-arm64@12.21.0': optional: true - '@reflink/reflink-darwin-arm64@0.1.19': + '@pnpm/exe.linux-ppc64@12.21.0': optional: true - '@reflink/reflink-darwin-x64@0.1.19': + '@pnpm/exe.linux-riscv64@12.21.0': optional: true - '@reflink/reflink-linux-arm64-gnu@0.1.19': + '@pnpm/exe.linux-s390x@12.21.0': optional: true - '@reflink/reflink-linux-arm64-musl@0.1.19': + '@pnpm/exe.linux-x64-musl@12.21.0': optional: true - '@reflink/reflink-linux-x64-gnu@0.1.19': + '@pnpm/exe.linux-x64@12.21.0': optional: true - '@reflink/reflink-linux-x64-musl@0.1.19': + '@pnpm/exe.netbsd-x64@12.21.0': optional: true - '@reflink/reflink-win32-arm64-msvc@0.1.19': + '@pnpm/exe.win32-arm64@12.21.0': optional: true - '@reflink/reflink-win32-x64-msvc@0.1.19': + '@pnpm/exe.win32-x64@12.21.0': optional: true - '@reflink/reflink@0.1.19': + pnpm@12.21.0: optionalDependencies: - '@reflink/reflink-darwin-arm64': 0.1.19 - '@reflink/reflink-darwin-x64': 0.1.19 - '@reflink/reflink-linux-arm64-gnu': 0.1.19 - '@reflink/reflink-linux-arm64-musl': 0.1.19 - '@reflink/reflink-linux-x64-gnu': 0.1.19 - '@reflink/reflink-linux-x64-musl': 0.1.19 - '@reflink/reflink-win32-arm64-msvc': 0.1.19 - '@reflink/reflink-win32-x64-msvc': 0.1.19 - - detect-libc@2.1.2: {} - - pnpm@11.10.0: {} + '@pnpm/exe.android-arm64': 12.21.0 + '@pnpm/exe.android-x64': 12.21.0 + '@pnpm/exe.darwin-arm64': 12.21.0 + '@pnpm/exe.darwin-x64': 12.21.0 + '@pnpm/exe.freebsd-x64': 12.21.0 + '@pnpm/exe.linux-arm64': 12.21.0 + '@pnpm/exe.linux-arm64-musl': 12.21.0 + '@pnpm/exe.linux-ppc64': 12.21.0 + '@pnpm/exe.linux-riscv64': 12.21.0 + '@pnpm/exe.linux-s390x': 12.21.0 + '@pnpm/exe.linux-x64': 12.21.0 + '@pnpm/exe.linux-x64-musl': 12.21.0 + '@pnpm/exe.netbsd-x64': 12.21.0 + '@pnpm/exe.win32-arm64': 12.21.0 + '@pnpm/exe.win32-x64': 12.21.0 --- lockfileVersion: '9.0' From edcbf142c975102974bf53d5fb12d36258cb3481 Mon Sep 17 00:00:00 2001 From: Charlie Gilman Date: Thu, 19 Nov 2026 15:01:37 +0000 Subject: [PATCH 2/5] APP-569: Set up pnpm 12 in CI through one shared action pnpm/setup v2 cannot install pnpm 12; v3.2.0 can. publish-vortex-api.yml had its own pnpm/action-setup + setup-node + node-gyp chmod workaround, so it now uses the shared setup-pnpm action too and keeps setup-node only to write the npm registry config for trusted publishing. Co-Authored-By: Claude Opus 5.5 --- .github/actions/setup-pnpm/action.yml | 2 +- .github/workflows/publish-vortex-api.yml | 14 +++----------- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/.github/actions/setup-pnpm/action.yml b/.github/actions/setup-pnpm/action.yml index afbc7ad4fd..9eaca7eacb 100644 --- a/.github/actions/setup-pnpm/action.yml +++ b/.github/actions/setup-pnpm/action.yml @@ -16,7 +16,7 @@ runs: run: dpkg -s libatomic1 >/dev/null 2>&1 || (sudo apt-get update && sudo apt-get install -y libatomic1) - name: Install pnpm and Node.js - uses: pnpm/setup@v2.0.2 + uses: pnpm/setup@v3.2.0 with: cache: true install: false diff --git a/.github/workflows/publish-vortex-api.yml b/.github/workflows/publish-vortex-api.yml index 0aa0bde83f..1e16261d7f 100644 --- a/.github/workflows/publish-vortex-api.yml +++ b/.github/workflows/publish-vortex-api.yml @@ -48,23 +48,15 @@ jobs: with: ref: ${{ github.event.release.tag_name || inputs.tag }} - - name: Read Node.js version from package.json - id: node-version - run: echo "NODE_VERSION=$(jq -r .engines.node package.json)" >> "$GITHUB_OUTPUT" - - name: Install pnpm - uses: pnpm/action-setup@v6 + uses: ./.github/actions/setup-pnpm - - name: Use Node.js + # Only writes the registry .npmrc; Node.js itself comes from setup-pnpm. + - name: Configure npm registry uses: actions/setup-node@v7 with: - node-version: ${{ steps.node-version.outputs.NODE_VERSION }} - cache: "pnpm" registry-url: "https://registry.npmjs.org" - - name: Fix pnpm node-gyp permissions - run: find "$PNPM_HOME" -path '*/node-gyp/gyp/gyp_main.py' -exec chmod +x {} \; - # NOTE(erri120): fontconfig required by font-scanner required by theme-switcher - name: Install fontconfig run: sudo apt-get update && sudo apt-get install -y libfontconfig1-dev From fabf79d174f7c5b78af6caf209333f6bd246c172 Mon Sep 17 00:00:00 2001 From: Charlie Gilman Date: Thu, 19 Nov 2026 15:01:40 +0000 Subject: [PATCH 3/5] APP-569: Resolve winapi-bindings without a pnpm store path The test hard-coded winapi-bindings' node_modules/.pnpm folder name, which pnpm 12 hashes differently, so the native cross-check silently skipped. Resolve it through @vortex/main instead and fail rather than skip. Co-Authored-By: Claude Opus 5.5 --- packages/exe-version/src/index.test.ts | 33 ++++++++++---------------- 1 file changed, 12 insertions(+), 21 deletions(-) diff --git a/packages/exe-version/src/index.test.ts b/packages/exe-version/src/index.test.ts index b34c0cfb52..b4058ca9d5 100644 --- a/packages/exe-version/src/index.test.ts +++ b/packages/exe-version/src/index.test.ts @@ -1,4 +1,5 @@ import * as fs from "fs"; +import { createRequire } from "module"; import * as path from "path"; import { describe, it, expect } from "vitest"; @@ -98,25 +99,17 @@ describeOnWindows("public API", () => { }); describeOnWindows("cross-validation with native module", () => { - let nativeGetInfo: - | ((filePath: string) => { - fileVersion: number[]; - productVersion: number[]; - fileVersionString: string; - productVersionString: string; - }) - | undefined; - - try { - const winapiPath = path.resolve( - __dirname, - "../../../node_modules/.pnpm/winapi-bindings@https+++cod_133dce9c747207ea117c57c1f8ca67ef/node_modules/winapi-bindings", - ); - // eslint-disable-next-line @typescript-eslint/no-var-requires - nativeGetInfo = require(winapiPath).GetFileVersionInfo; - } catch { - nativeGetInfo = undefined; - } + // Resolved through @vortex/main, which depends on winapi-bindings, rather than + // a hard-coded node_modules/.pnpm path: pnpm's store folder names are not + // stable across pnpm versions. A failed resolve fails the suite instead of + // skipping it. + const mainRequire = createRequire( + path.resolve(import.meta.dirname, "../../../src/main/package.json"), + ); + const nativeGetInfo: (filePath: string) => { + fileVersion: number[]; + productVersion: number[]; + } = mainRequire("winapi-bindings").GetFileVersionInfo; const testFiles = [ "C:\\Windows\\System32\\notepad.exe", @@ -128,8 +121,6 @@ describeOnWindows("cross-validation with native module", () => { if (!fs.existsSync(file)) continue; it(`matches native output for ${path.basename(file)}`, () => { - if (nativeGetInfo === undefined) return; // skip if native not available - const tsInfo = readVersionInfo(file)!; const native = nativeGetInfo(file); From 120bc8873452d1867b66a31ed96c1492d910b278 Mon Sep 17 00:00:00 2001 From: Charlie Gilman Date: Thu, 19 Nov 2026 15:01:42 +0000 Subject: [PATCH 4/5] APP-569: Update setup docs for pnpm 12, drop stale .node-version .node-version said 22 while the repo pins Node 24.22.3 through devEngines.runtime; nothing reads it. Also drop the shared setup docs' claim of a Node catalog entry that does not exist, and bump the pnpm version suggested to extension authors. Co-Authored-By: Claude Opus 5.5 --- .node-version | 1 - docs/install-instructions/shared.md | 9 +++++++-- packages/vortex-api/docs/MIGRATION.md | 2 +- 3 files changed, 8 insertions(+), 4 deletions(-) delete mode 100644 .node-version diff --git a/.node-version b/.node-version deleted file mode 100644 index 2bd5a0a98a..0000000000 --- a/.node-version +++ /dev/null @@ -1 +0,0 @@ -22 diff --git a/docs/install-instructions/shared.md b/docs/install-instructions/shared.md index 059797ee86..48283e8167 100644 --- a/docs/install-instructions/shared.md +++ b/docs/install-instructions/shared.md @@ -64,6 +64,12 @@ The version you installed in step 2 only bootstraps the process. `pnpm` reads downloads the pinned `node.js` runtime declared in `devEngines.runtime`. Building the native modules is the slow part of this step. +The repository pins pnpm 12. A pnpm 11 install (11.10 or newer) still switches to +it, so you do not need to upgrade your global `pnpm` first. To upgrade it anyway, +run `pnpm self-update` outside the repository. If `pnpm --version` still reports +an older version afterwards, an older `pnpm` is earlier on `PATH`: find it with +`where.exe pnpm` on Windows or `which -a pnpm` on Linux. + This also installs the git pre-commit hook for auto-formatting. If the hook is missing, install it by hand: @@ -88,8 +94,7 @@ which is not necessarily the one on your `PATH`. ## Notes - Corepack, `npm` and a global `node.js` are not required. The `node.js` version - is pinned by `devEngines.runtime` in `package.json` and by the `node` - runtime entry in the `pnpm-workspace.yaml` catalog. + is pinned by `devEngines.runtime` in `package.json`. - `nx` is a dev dependency of the repository. Always run it as `pnpm nx `; do not install it globally. - If you want `node` and `npm` on `PATH` for unrelated projects, install `node.js` diff --git a/packages/vortex-api/docs/MIGRATION.md b/packages/vortex-api/docs/MIGRATION.md index 1803db4f7b..0391be3a6e 100644 --- a/packages/vortex-api/docs/MIGRATION.md +++ b/packages/vortex-api/docs/MIGRATION.md @@ -62,7 +62,7 @@ In your `package.json`, replace: ```diff - "packageManager": "yarn@1.22.19" -+ "packageManager": "pnpm@10.31.0" ++ "packageManager": "pnpm@12.21.0" ``` ### 1b. Generate `pnpm-lock.yaml` From acf524c9c326dcba407d9a7f078993c215d3e262 Mon Sep 17 00:00:00 2001 From: Charlie Gilman Date: Thu, 19 Nov 2026 15:54:05 +0000 Subject: [PATCH 5/5] APP-569: Allow dry runs of publish-vortex-api against a branch The workflow always built the release tag, so a pnpm upgrade could not be dry-run before release. An optional ref input builds that branch or commit instead, and a guard refuses a real publish with it set. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/publish-vortex-api.yml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/publish-vortex-api.yml b/.github/workflows/publish-vortex-api.yml index 1e16261d7f..7339e4a443 100644 --- a/.github/workflows/publish-vortex-api.yml +++ b/.github/workflows/publish-vortex-api.yml @@ -25,6 +25,10 @@ on: description: "Build and pack without publishing." type: boolean default: true + ref: + description: "Branch or commit to build instead of the tag, for dry runs of an unreleased branch. The tag still sets the version." + required: false + type: string concurrency: group: publish-vortex-api-${{ github.event.release.tag_name || inputs.tag }} @@ -44,9 +48,15 @@ jobs: # The API bundle never loads Electron, so skip the native rebuild the app needs. VORTEX_ELECTRON_REBUILD: "skip" steps: + - name: Refuse to publish a ref other than the tag + if: ${{ inputs.ref != '' && env.DRY_RUN != 'true' }} + run: | + echo "::error::The ref input is for dry runs only. Publishing must build the release tag." + exit 1 + - uses: actions/checkout@v7 with: - ref: ${{ github.event.release.tag_name || inputs.tag }} + ref: ${{ github.event.release.tag_name || inputs.ref || inputs.tag }} - name: Install pnpm uses: ./.github/actions/setup-pnpm