From d4aa14f71f58b7a5fbf9084db8ed449f7708f615 Mon Sep 17 00:00:00 2001 From: shimoncohen Date: Mon, 28 Sep 2026 14:31:02 +0300 Subject: [PATCH] ci: fail eslint job on lint errors lint-action defaults to continue_on_error: true, and without checks: write its ESLint check run is rejected with 403, so lint errors never surfaced. Co-Authored-By: Claude Opus 5.5 (1M context) --- .github/workflows/pull_request.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/pull_request.yaml b/.github/workflows/pull_request.yaml index 0becfd5..566ac31 100644 --- a/.github/workflows/pull_request.yaml +++ b/.github/workflows/pull_request.yaml @@ -5,6 +5,7 @@ on: pull_request permissions: contents: read pull-requests: read + checks: write jobs: eslint: @@ -29,6 +30,7 @@ jobs: prettier: true eslint_extensions: ts tsc: true + continue_on_error: false openapi-lint: name: Run OpenAPI lint Check