From f185b6f3bb7627949ca36f87fa315a3aeea11c3f Mon Sep 17 00:00:00 2001
From: Nathan Hughes <nathan.h.hughes@gmail.com>
Date: Fri, 7 Aug 2026 19:20:53 +0000
Subject: [PATCH] fix clang warnings

---
 ianvs/include/ianvs/app/rosbag_play_plugins.h | 2 ++
 ianvs/include/ianvs/node_handle.h             | 2 +-
 ianvs/include/ianvs/node_init.h               | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/ianvs/include/ianvs/app/rosbag_play_plugins.h b/ianvs/include/ianvs/app/rosbag_play_plugins.h
index af7f333..89427ad 100644
--- a/ianvs/include/ianvs/app/rosbag_play_plugins.h
+++ b/ianvs/include/ianvs/app/rosbag_play_plugins.h
@@ -46,6 +46,8 @@ namespace ianvs {
 
 class RosbagPlayPlugin {
  public:
+  virtual ~RosbagPlayPlugin() = default;
+
   //! @brief Initialize plugin
   virtual void init(std::shared_ptr<rclcpp::Node> node) = 0;
 
diff --git a/ianvs/include/ianvs/node_handle.h b/ianvs/include/ianvs/node_handle.h
index 62848b1..d8847c0 100644
--- a/ianvs/include/ianvs/node_handle.h
+++ b/ianvs/include/ianvs/node_handle.h
@@ -153,7 +153,7 @@ typename NodeHandle::Subscription<T> NodeHandle::create_subscription(const std::
                                                                      Cls* class_pointer,
                                                                      GroupPtr group) {
   return create_subscription<T>(
-      topic, qos, std::bind(callback, class_pointer, std::placeholders::_1));
+      topic, qos, std::bind(callback, class_pointer, std::placeholders::_1), group);
 }
 
 template <typename T, typename CallbackT>
diff --git a/ianvs/include/ianvs/node_init.h b/ianvs/include/ianvs/node_init.h
index f940fe0..a418106 100644
--- a/ianvs/include/ianvs/node_init.h
+++ b/ianvs/include/ianvs/node_init.h
@@ -29,7 +29,7 @@ struct NodeGuard {
   ~NodeGuard();
 };
 
-IANVS_PUBLIC [[nodiscard]] NodeGuard init_node(int& argc,
+[[nodiscard]] IANVS_PUBLIC NodeGuard init_node(int& argc,
                                                char** argv,
                                                const std::string& node_name);