diff --git a/ianvs/include/ianvs/app/rosbag_play_plugins.h b/ianvs/include/ianvs/app/rosbag_play_plugins.h index af7f333..89427ad 100644 --- a/ianvs/include/ianvs/app/rosbag_play_plugins.h +++ b/ianvs/include/ianvs/app/rosbag_play_plugins.h @@ -46,6 +46,8 @@ namespace ianvs { class RosbagPlayPlugin { public: + virtual ~RosbagPlayPlugin() = default; + //! @brief Initialize plugin virtual void init(std::shared_ptr node) = 0; diff --git a/ianvs/include/ianvs/node_handle.h b/ianvs/include/ianvs/node_handle.h index 62848b1..d8847c0 100644 --- a/ianvs/include/ianvs/node_handle.h +++ b/ianvs/include/ianvs/node_handle.h @@ -153,7 +153,7 @@ typename NodeHandle::Subscription NodeHandle::create_subscription(const std:: Cls* class_pointer, GroupPtr group) { return create_subscription( - topic, qos, std::bind(callback, class_pointer, std::placeholders::_1)); + topic, qos, std::bind(callback, class_pointer, std::placeholders::_1), group); } template diff --git a/ianvs/include/ianvs/node_init.h b/ianvs/include/ianvs/node_init.h index f940fe0..a418106 100644 --- a/ianvs/include/ianvs/node_init.h +++ b/ianvs/include/ianvs/node_init.h @@ -29,7 +29,7 @@ struct NodeGuard { ~NodeGuard(); }; -IANVS_PUBLIC [[nodiscard]] NodeGuard init_node(int& argc, +[[nodiscard]] IANVS_PUBLIC NodeGuard init_node(int& argc, char** argv, const std::string& node_name);