Skip to content

Deploy shared wallet module to lock, otc, and rewards #53

Description

@dnlbui

Summary

Production wallet UIs in liberdus.github.io should use the shared liberdus-wallet-module instead of legacy MetaMask-only or bespoke wallet code.

Already deployed here

Folder Source repo Update script Status
farm/ lib-lp-staking-frontend ./update-farm.sh Done
bsc-bridge/ liberdus-bsc-bridge-ui ./update-bsc-bridge.sh Done
token/ liberdus-token-ui ./update-token-client.sh Done

Still needs migration (production folders)

Folder Current wallet stack Source repo Update script
lock/ MetaMask-only MetaMaskConnector token-lock-ui ./update-lock.sh
otc/ Custom WalletManager via window.ethereum otc-web-client-1 ./update-otc-client.sh
rewards/ Custom EIP-6963 wallet code in js/shared/wallet.js liberdus-airdrop/frontend ./update-rewards.sh

Related follow-up (separate deploy path): farm/migration/ still uses the legacy MetaMask wallet manager and is synced via ./update-farm-migration.sh.

Blockers

This github.io work is blocked upstream for all three folders. Two already have open integration PRs that need review feedback addressed and merged before we can sync to Pages:

rewards/ — blocked on source PR

lock/ — blocked on source PR

  • PR: Liberdus/token-lock-ui#9 — feat: import liberdus wallet module (open)
  • Replaces MetaMask-only integration with shared wallet core
  • Review feedback pending: wallet picker flow for multi-wallet installs, local disconnect / session cleanup, and related module session handling — see inline review threads on the PR
  • After merge: run ./update-lock.sh to copy token-lock-uilock/
  • Consider updating update-lock.sh to init/check vendor/liberdus-wallet-module submodules (similar to update-token-client.sh)

otc/ — blocked on source work (no open wallet-module PR yet)

  • Still uses legacy wallet code in otc/js/config.js
  • No wallet-module integration PR identified yet in the OTC source repo (otc-web-client-1 / otc-web-client)
  • Needs source-repo integration work before ./update-otc-client.sh can deploy the module to otc/

Acceptance criteria

  • Upstream wallet-module PRs merged for lock and rewards
  • Upstream wallet-module integration completed and merged for otc
  • ./update-lock.sh, ./update-otc-client.sh, and ./update-rewards.sh run successfully against updated source repos
  • lock/, otc/, and rewards/ contain vendor/liberdus-wallet-module/ (or equivalent vendored copy) and use createWalletCore / shared module session APIs
  • Production smoke test: connect wallet, switch network, sign/submit tx, disconnect on each site

Notes

  • Test/staging counterparts (locktest, otctest, rewards-test) can be updated separately after production paths are validated.
  • Submodule bump/maintenance scripts (scripts/bump-wallet-module.sh, docs/SUBMODULE.md) should be mirrored from the token/bridge/farm pattern where applicable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions