Skip to content

fix(wl-sdk): escape SQL LIKE wildcards in one pass#3852

Merged
RSO merged 1 commit into
mainfrom
fix/codeql-433-sql-like-escape
Jun 9, 2026
Merged

fix(wl-sdk): escape SQL LIKE wildcards in one pass#3852
RSO merged 1 commit into
mainfrom
fix/codeql-433-sql-like-escape

Conversation

@kilo-code-bot

@kilo-code-bot kilo-code-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Refactor escapeSqlLike to escape SQL LIKE wildcards in a single global replacement pass, addressing CodeQL alert 433 without changing the emitted escapes.
  • Add coverage for repeated % and _ wildcards so the helper keeps escaping every occurrence.

Verification

N/A - security helper change with no manual UI flow.

Visual Changes

N/A

Reviewer Notes

Targets only CodeQL alert 433 (js/incomplete-sanitization) in packages/wl-sdk/src/commons/escape.ts.

@kilo-code-bot kilo-code-bot Bot requested a review from RSO June 9, 2026 09:36
@kilo-code-bot

kilo-code-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Minimal, correct security fix — replaces two sequential replace calls with a single-pass character-class replacement to address CodeQL alert 433 (js/incomplete-sanitization), with a matching regression test.

Files Reviewed (2 files)
  • packages/wl-sdk/src/commons/escape.ts
  • packages/wl-sdk/src/commons/escape.test.ts

Reviewed by claude-4.6-sonnet-20260217 · 254,411 tokens

Review guidance: REVIEW.md from base branch main

@RSO RSO merged commit dd88cb3 into main Jun 9, 2026
55 checks passed
@RSO RSO deleted the fix/codeql-433-sql-like-escape branch June 9, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants