From d86ac4b1068fa3911a1e33b755116ce3cc838262 Mon Sep 17 00:00:00 2001 From: Anant Date: Wed, 7 Oct 2026 17:52:15 +0530 Subject: [PATCH 1/8] Request Ben and Utkarsh for Desktop reviews --- .github/CODEOWNERS | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000..8511802 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,2 @@ +# Request both developers for Desktop changes; one approval is required. +* @ben-kaufman @cakesoft-utkarsh From e1741540222a96bec30fe646dfd585723b63a6bc Mon Sep 17 00:00:00 2001 From: Anant Date: Wed, 7 Oct 2026 17:58:22 +0530 Subject: [PATCH 2/8] Install Rust formatting and lint components in Desktop CI --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ca3aa62..f759d98 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -33,6 +33,8 @@ jobs: libudev-dev - name: Install Rust 1.85.1 uses: dtolnay/rust-toolchain@1.85.1 + with: + components: clippy, rustfmt - name: Run ESLint run: npm run lint - name: Check Prettier formatting From 54c1a512dcb75523e025e5ca71ea73f410c69ba2 Mon Sep 17 00:00:00 2001 From: Anant Date: Wed, 7 Oct 2026 18:01:35 +0530 Subject: [PATCH 3/8] Include Parsh in developer review requests --- .github/CODEOWNERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 8511802..d50b67d 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,2 +1,2 @@ -# Request both developers for Desktop changes; one approval is required. -* @ben-kaufman @cakesoft-utkarsh +# Request Ben, Utkarsh, and Parsh for Desktop changes; one approval is required. +* @ben-kaufman @cakesoft-utkarsh @Parsh From 79b3b659fa3d462dad6804d73366a90ee1dee5a7 Mon Sep 17 00:00:00 2001 From: Anant Date: Wed, 7 Oct 2026 22:02:45 +0530 Subject: [PATCH 4/8] Document Desktop Copilot review policy --- .github/PULL_REQUEST_TEMPLATE.md | 20 ++++++++++++++++++++ .github/REVIEW_POLICY.md | 22 ++++++++++++++++++++++ AGENTS.md | 3 +++ README.md | 2 ++ 4 files changed, 47 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md create mode 100644 .github/REVIEW_POLICY.md create mode 100644 AGENTS.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..f18f31b --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,20 @@ +## Change + +Describe the problem and resulting behavior. + +## Verification + +- Checks run and results: +- Remaining limitations: + +## Review + +Follow `.github/REVIEW_POLICY.md`. Complete the selected effort fields before the first review; update the actual evidence after review. + +- Selected Copilot effort (Lite / Balanced) and reason: +- Confirmed GitHub PR effort (including any saved override): +- Actual Copilot effort and reviewed commit SHA: +- Review outcome, link, and real comments addressed (or pending / unavailable): +- Material changes since the reviewed commit / re-review needed: +- Unavailable review or quota status (if applicable): +- Independent human approver (Ben / Utkarsh / Parsh) and required checks: diff --git a/.github/REVIEW_POLICY.md b/.github/REVIEW_POLICY.md new file mode 100644 index 0000000..35f9cd8 --- /dev/null +++ b/.github/REVIEW_POLICY.md @@ -0,0 +1,22 @@ +# Pull request review policy + +## Copilot effort + +The Desktop repository default policy is **Lite**. Before the first review, choose the effort for the whole PR in GitHub and record the choice and reason in the PR description. A saved PR effort overrides the repository default; verify it when updating an existing PR. GitHub controls the review model; the model selected in ChatGPT or Codex does not select Copilot's model. + +- **Lite:** routine UI, styling, noncritical copy, documentation, or isolated changes with understood, low risk. +- **Balanced:** keys, signing, recovery, backup, authentication, pairing, transactions, wallet migration, security-sensitive copy or dependencies, permissions, complex changes, changes spanning services/repositories, or unclear risk. + +Use Balanced when a PR mixes categories or its risk is uncertain. Set any PR override before the first review. This policy and the PR template document the choice; they do not configure GitHub effort or enforce a CI gate. + +## Review timing and evidence + +Keep automatic first review for ready PRs active. Keep automatic reviews of drafts and every push disabled. Finish relevant checks and batch fixes before requesting another review for material source changes. Routine documentation edits do not need another paid review. + +Record the actual effort reported by Copilot, the reviewed commit SHA, the review link, and how feedback was addressed. A review of an older commit is evidence only for that commit; explain material changes since that review and request another review when needed. If quota or availability prevents a review, record that status explicitly. Quota unavailability is not a completed review, and a missing effort/head must remain unverified. + +## Human approval and merge + +Merge requires all required checks and one independent human approval from **Ben (`ben-kaufman`)**, **Utkarsh (`cakesoft-utkarsh`)**, or **Parsh (`Parsh`)**. The approver must be someone other than the PR author. CODEOWNERS requests the named reviewers; approval from all three is not required. Copilot feedback does not count as human approval. + +Confirm the review evidence and required checks apply to the current changes before merging. Repository branch protection remains the merge enforcement mechanism. diff --git a/AGENTS.md b/AGENTS.md new file mode 100644 index 0000000..8cdc954 --- /dev/null +++ b/AGENTS.md @@ -0,0 +1,3 @@ +# Pull request review + +Follow [.github/REVIEW_POLICY.md](.github/REVIEW_POLICY.md) when preparing or updating a pull request. Use [.github/PULL_REQUEST_TEMPLATE.md](.github/PULL_REQUEST_TEMPLATE.md), select and verify the GitHub Copilot effort before the first review, and record actual review evidence. Keep draft and every-push automatic reviews disabled, batch material fixes before requesting another review, and obtain the required independent human approval and checks before merge. diff --git a/README.md b/README.md index ff2ec83..b2551fd 100644 --- a/README.md +++ b/README.md @@ -106,6 +106,8 @@ We use several tools to maintain code quality and consistency: Before submitting a pull request, please ensure that your code passes all linting and formatting checks. +Follow the [pull request review policy](.github/REVIEW_POLICY.md) for Copilot effort, review evidence, and the required independent human approval. Use the [pull request template](.github/PULL_REQUEST_TEMPLATE.md) when opening a PR. + ## License This project is licensed under the **MIT License.** From affe9ec036b302a65b251fdd6d3fa24af60bbf23 Mon Sep 17 00:00:00 2001 From: Anant Date: Wed, 7 Oct 2026 22:04:24 +0530 Subject: [PATCH 5/8] Clarify Copilot effort selection and final review --- .github/PULL_REQUEST_TEMPLATE.md | 2 ++ .github/REVIEW_POLICY.md | 6 ++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f18f31b..7eaa884 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -9,6 +9,8 @@ Describe the problem and resulting behavior. ## Review + + Follow `.github/REVIEW_POLICY.md`. Complete the selected effort fields before the first review; update the actual evidence after review. - Selected Copilot effort (Lite / Balanced) and reason: diff --git a/.github/REVIEW_POLICY.md b/.github/REVIEW_POLICY.md index 35f9cd8..a666553 100644 --- a/.github/REVIEW_POLICY.md +++ b/.github/REVIEW_POLICY.md @@ -2,17 +2,19 @@ ## Copilot effort -The Desktop repository default policy is **Lite**. Before the first review, choose the effort for the whole PR in GitHub and record the choice and reason in the PR description. A saved PR effort overrides the repository default; verify it when updating an existing PR. GitHub controls the review model; the model selected in ChatGPT or Codex does not select Copilot's model. +Desktop defaults to **Lite**. Before requesting the first review or marking a draft ready, select the whole PR's effort in GitHub and record its reason in the PR description. A saved PR effort overrides the repository default; verify it when updating an existing PR. GitHub controls the review model; the model selected in ChatGPT or Codex does not select Copilot's model. - **Lite:** routine UI, styling, noncritical copy, documentation, or isolated changes with understood, low risk. - **Balanced:** keys, signing, recovery, backup, authentication, pairing, transactions, wallet migration, security-sensitive copy or dependencies, permissions, complex changes, changes spanning services/repositories, or unclear risk. -Use Balanced when a PR mixes categories or its risk is uncertain. Set any PR override before the first review. This policy and the PR template document the choice; they do not configure GitHub effort or enforce a CI gate. +Use Balanced when a PR mixes categories or its risk is uncertain. This policy and the PR template document the choice; they do not configure GitHub effort or enforce a CI gate. ## Review timing and evidence Keep automatic first review for ready PRs active. Keep automatic reviews of drafts and every push disabled. Finish relevant checks and batch fixes before requesting another review for material source changes. Routine documentation edits do not need another paid review. +If a material security PR was automatically reviewed at Lite, select Balanced and request one substantive final review after batching fixes and stabilizing checks. A Lite review does not count as Balanced. + Record the actual effort reported by Copilot, the reviewed commit SHA, the review link, and how feedback was addressed. A review of an older commit is evidence only for that commit; explain material changes since that review and request another review when needed. If quota or availability prevents a review, record that status explicitly. Quota unavailability is not a completed review, and a missing effort/head must remain unverified. ## Human approval and merge From 00f1725beb2b00199f9c15828e1a91cafe632761 Mon Sep 17 00:00:00 2001 From: Anant Date: Wed, 7 Oct 2026 22:05:50 +0530 Subject: [PATCH 6/8] Clarify agent verification and review references --- .github/REVIEW_POLICY.md | 2 +- AGENTS.md | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/REVIEW_POLICY.md b/.github/REVIEW_POLICY.md index a666553..f5f57e3 100644 --- a/.github/REVIEW_POLICY.md +++ b/.github/REVIEW_POLICY.md @@ -2,7 +2,7 @@ ## Copilot effort -Desktop defaults to **Lite**. Before requesting the first review or marking a draft ready, select the whole PR's effort in GitHub and record its reason in the PR description. A saved PR effort overrides the repository default; verify it when updating an existing PR. GitHub controls the review model; the model selected in ChatGPT or Codex does not select Copilot's model. +Desktop defaults to **Lite**. Before requesting the first review or marking a draft ready, select the whole PR's effort in GitHub and record its reason in the PR description. A saved PR effort overrides the repository default; verify it when updating an existing PR. [GitHub controls the review model](https://docs.github.com/en/copilot/concepts/agents/code-review); the model selected in ChatGPT or Codex does not select Copilot's model. - **Lite:** routine UI, styling, noncritical copy, documentation, or isolated changes with understood, low risk. - **Balanced:** keys, signing, recovery, backup, authentication, pairing, transactions, wallet migration, security-sensitive copy or dependencies, permissions, complex changes, changes spanning services/repositories, or unclear risk. diff --git a/AGENTS.md b/AGENTS.md index 8cdc954..f7cf41e 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -1,3 +1,5 @@ # Pull request review Follow [.github/REVIEW_POLICY.md](.github/REVIEW_POLICY.md) when preparing or updating a pull request. Use [.github/PULL_REQUEST_TEMPLATE.md](.github/PULL_REQUEST_TEMPLATE.md), select and verify the GitHub Copilot effort before the first review, and record actual review evidence. Keep draft and every-push automatic reviews disabled, batch material fixes before requesting another review, and obtain the required independent human approval and checks before merge. + +Preserve current repository conventions. Before delivery, run feasible checks proportional to the change: documentation edits need formatting, links, and scoped diff checks; runtime changes need relevant checks. Human live verification takes place after agent delivery. Merge still requires the existing required checks and one independent human approval under the review policy. From 648b8a8c8836f80cac4da7b41af1dc547575bb1a Mon Sep 17 00:00:00 2001 From: antuz123 <43998049+antuz123@users.noreply.github.com> Date: Thu, 22 Oct 2026 11:37:56 +0530 Subject: [PATCH 7/8] docs: make human developer reviews optional --- .github/CODEOWNERS | 4 ++-- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- .github/REVIEW_POLICY.md | 6 +++--- AGENTS.md | 4 ++-- README.md | 2 +- 5 files changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index d50b67d..0564a25 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,2 +1,2 @@ -# Request Ben, Utkarsh, and Parsh for Desktop changes; one approval is required. -* @ben-kaufman @cakesoft-utkarsh @Parsh +# Human developer reviews are optional; no automatic code-owner assignment is required. +# Suggested reviewers when useful and already eligible: @ben-kaufman @cakesoft-utkarsh @Parsh diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 7eaa884..42a2d66 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -19,4 +19,5 @@ Follow `.github/REVIEW_POLICY.md`. Complete the selected effort fields before th - Review outcome, link, and real comments addressed (or pending / unavailable): - Material changes since the reviewed commit / re-review needed: - Unavailable review or quota status (if applicable): -- Independent human approver (Ben / Utkarsh / Parsh) and required checks: +- Optional human review, if requested (reviewer, link, actual status and findings): +- Required checks and remaining gates: diff --git a/.github/REVIEW_POLICY.md b/.github/REVIEW_POLICY.md index f5f57e3..faf37fd 100644 --- a/.github/REVIEW_POLICY.md +++ b/.github/REVIEW_POLICY.md @@ -17,8 +17,8 @@ If a material security PR was automatically reviewed at Lite, select Balanced an Record the actual effort reported by Copilot, the reviewed commit SHA, the review link, and how feedback was addressed. A review of an older commit is evidence only for that commit; explain material changes since that review and request another review when needed. If quota or availability prevents a review, record that status explicitly. Quota unavailability is not a completed review, and a missing effort/head must remain unverified. -## Human approval and merge +## Optional human review and merge -Merge requires all required checks and one independent human approval from **Ben (`ben-kaufman`)**, **Utkarsh (`cakesoft-utkarsh`)**, or **Parsh (`Parsh`)**. The approver must be someone other than the PR author. CODEOWNERS requests the named reviewers; approval from all three is not required. Copilot feedback does not count as human approval. +Human developer review is optional. **Ben (`ben-kaufman`)**, **Utkarsh (`cakesoft-utkarsh`)**, and **Parsh (`Parsh`)** are suggested reviewers when useful and already eligible. Pending invitations or the absence of human review do not block readiness or merge and do not require an access grant. CODEOWNERS contains suggestions only; no human approval is required. -Confirm the review evidence and required checks apply to the current changes before merging. Repository branch protection remains the merge enforcement mechanism. +All required checks and resolution of relevant review concerns remain required. Record any requested human review, findings and their disposition accurately, and confirm review evidence applies to the current changes. Product signoff, required security and native validation, and operation-specific signing, deployment and release authorization remain separate. Repository branch protection remains the merge enforcement mechanism. diff --git a/AGENTS.md b/AGENTS.md index f7cf41e..d2083d0 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -1,5 +1,5 @@ # Pull request review -Follow [.github/REVIEW_POLICY.md](.github/REVIEW_POLICY.md) when preparing or updating a pull request. Use [.github/PULL_REQUEST_TEMPLATE.md](.github/PULL_REQUEST_TEMPLATE.md), select and verify the GitHub Copilot effort before the first review, and record actual review evidence. Keep draft and every-push automatic reviews disabled, batch material fixes before requesting another review, and obtain the required independent human approval and checks before merge. +Follow [.github/REVIEW_POLICY.md](.github/REVIEW_POLICY.md) when preparing or updating a pull request. Use [.github/PULL_REQUEST_TEMPLATE.md](.github/PULL_REQUEST_TEMPLATE.md), select and verify the GitHub Copilot effort before the first review, and record actual review evidence. Keep draft and every-push automatic reviews disabled, batch material fixes before requesting another review, and retain all required checks before merge. Human developer review is optional. -Preserve current repository conventions. Before delivery, run feasible checks proportional to the change: documentation edits need formatting, links, and scoped diff checks; runtime changes need relevant checks. Human live verification takes place after agent delivery. Merge still requires the existing required checks and one independent human approval under the review policy. +Preserve current repository conventions. Before delivery, run feasible checks proportional to the change: documentation edits need formatting, links, and scoped diff checks; runtime changes need relevant checks. Human live verification takes place after agent delivery. Merge still requires the existing required checks; requested human feedback and its disposition must be recorded without making approval a merge gate. diff --git a/README.md b/README.md index b2551fd..39712b0 100644 --- a/README.md +++ b/README.md @@ -106,7 +106,7 @@ We use several tools to maintain code quality and consistency: Before submitting a pull request, please ensure that your code passes all linting and formatting checks. -Follow the [pull request review policy](.github/REVIEW_POLICY.md) for Copilot effort, review evidence, and the required independent human approval. Use the [pull request template](.github/PULL_REQUEST_TEMPLATE.md) when opening a PR. +Follow the [pull request review policy](.github/REVIEW_POLICY.md) for Copilot effort, review evidence, and optional human developer review. Use the [pull request template](.github/PULL_REQUEST_TEMPLATE.md) when opening a PR. ## License From 76d2415bdbcb1a157e267147c65bff371fd7877d Mon Sep 17 00:00:00 2001 From: antuz123 <43998049+antuz123@users.noreply.github.com> Date: Thu, 22 Oct 2026 11:53:21 +0530 Subject: [PATCH 8/8] Use conditional cloud review based on risk and cost --- .github/PULL_REQUEST_TEMPLATE.md | 38 ++++++++++++++++++--------- .github/REVIEW_POLICY.md | 44 +++++++++++++++++++++++--------- AGENTS.md | 2 +- README.md | 2 +- 4 files changed, 60 insertions(+), 26 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 42a2d66..b313c76 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -9,15 +9,29 @@ Describe the problem and resulting behavior. ## Review - - -Follow `.github/REVIEW_POLICY.md`. Complete the selected effort fields before the first review; update the actual evidence after review. - -- Selected Copilot effort (Lite / Balanced) and reason: -- Confirmed GitHub PR effort (including any saved override): -- Actual Copilot effort and reviewed commit SHA: -- Review outcome, link, and real comments addressed (or pending / unavailable): -- Material changes since the reviewed commit / re-review needed: -- Unavailable review or quota status (if applicable): -- Optional human review, if requested (reviewer, link, actual status and findings): -- Required checks and remaining gates: + + +- Review decision: Skip provider review / Lite / Balanced +- Severity, scope, cost and reason: +- Checks/source evidence supporting this decision: +- Least-cost adequate installed cloud route, intended effort and authorized allowance, if used: +- Reused exact head/base review receipt, or initial/re-review reason: +- Actual provider/model/effort, reviewed SHA, coverage and evidence, or skipped/pending/unavailable: +- Real findings and evidence for their disposition: +- Independent coverage needed? Why, exact scope and actual status: +- Material changes since reviewed SHA / further review needed: +- Optional human review, if requested (reviewer, link, status and findings): + + + +- [ ] Required checks and applicable validation pass; remaining failures/limits are recorded. +- [ ] Substantive review findings have evidence-based dispositions. diff --git a/.github/REVIEW_POLICY.md b/.github/REVIEW_POLICY.md index faf37fd..4450861 100644 --- a/.github/REVIEW_POLICY.md +++ b/.github/REVIEW_POLICY.md @@ -1,24 +1,44 @@ # Pull request review policy -## Copilot effort +## Review decision: severity and cost -Desktop defaults to **Lite**. Before requesting the first review or marking a draft ready, select the whole PR's effort in GitHub and record its reason in the PR description. A saved PR effort overrides the repository default; verify it when updating an existing PR. [GitHub controls the review model](https://docs.github.com/en/copilot/concepts/agents/code-review); the model selected in ChatGPT or Codex does not select Copilot's model. +Cloud review is the primary developer-review route when the change warrants it; it replaces a mandatory human developer-approval gate. Human developer review is optional. Choose whether a separate provider review is useful and, if so, its type from the actual severity, uncertainty, scope and cost. Complete feasible deterministic verification first. -- **Lite:** routine UI, styling, noncritical copy, documentation, or isolated changes with understood, low risk. -- **Balanced:** keys, signing, recovery, backup, authentication, pairing, transactions, wallet migration, security-sensitive copy or dependencies, permissions, complex changes, changes spanning services/repositories, or unclear risk. +| Decision | Use when | Evidence | +| --- | --- | --- | +| Skip provider review | Verified routine documentation, noncritical copy or pure style changes with no behavior, security, permission, dependency or workflow impact; policy/security/agent/workflow documents are excluded | Record the reason and the checks/source inspection supporting the low-risk classification. | +| Lite | Bounded normal changes with understood risk that benefit from cloud review | Record the bounded scope, chosen route, intended effort and cost/allowance. | +| Balanced | Signing, keys, authentication, recovery, backup, pairing, transactions, migrations, workflows, permissions, security-sensitive dependencies/copy, complex or cross-service changes, or unknown risk | Record the risks and coverage needed; use Balanced when categories are mixed or risk is uncertain. | -Use Balanced when a PR mixes categories or its risk is uncertain. This policy and the PR template document the choice; they do not configure GitHub effort or enforce a CI gate. +A filename or a documentation label alone does not justify skipping review. Policy, security, agent and workflow documents are not routine documentation eligible for Skip. Assess their actual effect and choose an adequate Lite or Balanced route. A low-cost check or source inspection may resolve uncertainty without another provider call after valid review coverage; explain that evidence. -## Review timing and evidence +Independent cloud review is needed only when the actual risk or a substantive finding requires independence. Record why and what it must cover. Use only an already installed, authorized route whose repository scope, provider access and budget permit that review. Do not add another model, paid review or external executor merely to satisfy a routine checklist. If needed independent coverage is unavailable, record the exact blocker; substantive security concerns remain unresolved until supported by evidence, not waived because review is unavailable. -Keep automatic first review for ready PRs active. Keep automatic reviews of drafts and every push disabled. Finish relevant checks and batch fixes before requesting another review for material source changes. Routine documentation edits do not need another paid review. +## Route, effort and budget -If a material security PR was automatically reviewed at Lite, select Balanced and request one substantive final review after batching fixes and stabilizing checks. A Lite review does not count as Balanced. +When using Copilot, verify the PR's saved effort because an override may differ from the repository default. [GitHub controls Copilot's review model](https://docs.github.com/en/copilot/concepts/agents/code-review); selecting a ChatGPT or Codex model does not select Copilot's model. Lite and Balanced here specify the review choice; do not claim a mode or independent coverage that the selected route cannot provide. -Record the actual effort reported by Copilot, the reviewed commit SHA, the review link, and how feedback was addressed. A review of an older commit is evidence only for that commit; explain material changes since that review and request another review when needed. If quota or availability prevents a review, record that status explicitly. Quota unavailability is not a completed review, and a missing effort/head must remain unverified. +Use the least-cost already authorized route that adequately covers the risk. Reuse valid review receipts for the exact head/base and coverage; do not buy duplicate initial reviews. Complete stable checks before one initial review, batch material fixes before a necessary re-review, and preserve existing spending limits, permanent reservations, deduplication and no-retry controls. Routine reviews within an established scope and allowance do not need repeated owner permission. -## Optional human review and merge +Verify installed scope, applicable allowance and expected cost before a provider request. If quota, cap, activation or scope is unavailable, record unavailable and use another already-authorized adequate cloud route or hold the applicable gate. Do not silently downgrade critical review, create paid retries/fallbacks or infer a fresh budget. An uninstalled or disabled reviewer is not an available route, and these files do not install or activate one. Existing Claude limits, where applicable, of $3 reserved per attempt, two attempts per head and three per PR are ceilings, not activation or a fresh allowance. Historical Copilot balances or spending-cap observations are not current-credit proof. -Human developer review is optional. **Ben (`ben-kaufman`)**, **Utkarsh (`cakesoft-utkarsh`)**, and **Parsh (`Parsh`)** are suggested reviewers when useful and already eligible. Pending invitations or the absence of human review do not block readiness or merge and do not require an access grant. CODEOWNERS contains suggestions only; no human approval is required. +## Timing, automation and evidence -All required checks and resolution of relevant review concerns remain required. Record any requested human review, findings and their disposition accurately, and confirm review evidence applies to the current changes. Product signoff, required security and native validation, and operation-specific signing, deployment and release authorization remain separate. Repository branch protection remains the merge enforcement mechanism. +Batch material fixes and stabilize relevant checks before another review. Repeat cloud review only when a change materially alters the reviewed correctness/security scope or a finding needs independent confirmation. Verified routine follow-up edits do not automatically require another provider call. A Lite review of earlier content is not a Balanced review of the final changes. + +Blanket automatic ready-PR or every-push review does not implement this conditional decision and may consume allowance for changes classified Skip. Intended automation must honor the recorded decision; otherwise use an explicitly authorized trigger. Keep automatic draft and every-push review off. Inspect and record actual settings before a ready transition or request; these documents do not change GitHub rules, enforce risk classification, grant a budget or prove an installed trigger. Report a settings mismatch rather than claiming it is fixed by Markdown. + +Record in the PR: + +- Review decision: Skip provider review / Lite / Balanced, with severity, scope, uncertainty, cost and reason. +- Deterministic checks and source evidence; distinguish passed, failed, blocked and not run. +- Selected installed cloud route and intended effort, if used; applicable scope/allowance. +- Actual provider/model/effort, exact reviewed SHA, coverage, link and result, or accurately skipped/pending/unavailable. +- Real findings, including substantive overview concerns, and evidence for each disposition. A skipped or unavailable review is not evidence of no findings. +- Whether independent coverage is needed, why, and its actual status. Do not transfer old-SHA results to new changes. + +## Optional human review and required gates + +Ben (`ben-kaufman`), Utkarsh (`cakesoft-utkarsh`) and Parsh (`Parsh`) are suggested human reviewers when useful and already eligible. Pending invitations or the absence of human review do not block readiness or merge and do not require an access grant. Record any requested human feedback and its disposition; no human developer approval is required. CODEOWNERS suggestions, where present, do not create a mandatory review assignment. + +Required CI/status checks, resolution of substantive findings, security and native/device validation, product signoff and operation-specific signing, deployment and release authorization remain intact. Conditional review is not permission to bypass these gates or to merge a change with unresolved substantive security concerns. Repository protection remains the enforcement mechanism; report any live mismatch separately. diff --git a/AGENTS.md b/AGENTS.md index d2083d0..a0095b5 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -1,5 +1,5 @@ # Pull request review -Follow [.github/REVIEW_POLICY.md](.github/REVIEW_POLICY.md) when preparing or updating a pull request. Use [.github/PULL_REQUEST_TEMPLATE.md](.github/PULL_REQUEST_TEMPLATE.md), select and verify the GitHub Copilot effort before the first review, and record actual review evidence. Keep draft and every-push automatic reviews disabled, batch material fixes before requesting another review, and retain all required checks before merge. Human developer review is optional. +Follow [.github/REVIEW_POLICY.md](.github/REVIEW_POLICY.md) when preparing or updating a pull request. Use [.github/PULL_REQUEST_TEMPLATE.md](.github/PULL_REQUEST_TEMPLATE.md) to choose Skip provider review / Lite / Balanced from actual severity, uncertainty, scope and cost. Cloud review replaces mandatory human developer approval when warranted; human review is optional. Independent coverage is needed only when actual risk/findings require it and installed scope/budget permit. Record the decision, real checks, reviewed SHA/coverage and findings/dispositions; batch material fixes and avoid unnecessary provider requests. Keep draft/every-push review off, report automation mismatches and retain all required checks. Preserve current repository conventions. Before delivery, run feasible checks proportional to the change: documentation edits need formatting, links, and scoped diff checks; runtime changes need relevant checks. Human live verification takes place after agent delivery. Merge still requires the existing required checks; requested human feedback and its disposition must be recorded without making approval a merge gate. diff --git a/README.md b/README.md index 39712b0..3a087d3 100644 --- a/README.md +++ b/README.md @@ -106,7 +106,7 @@ We use several tools to maintain code quality and consistency: Before submitting a pull request, please ensure that your code passes all linting and formatting checks. -Follow the [pull request review policy](.github/REVIEW_POLICY.md) for Copilot effort, review evidence, and optional human developer review. Use the [pull request template](.github/PULL_REQUEST_TEMPLATE.md) when opening a PR. +Follow the [pull request review policy](.github/REVIEW_POLICY.md) for severity/cost-based cloud review decisions, actual review evidence, and optional human developer review. Use the [pull request template](.github/PULL_REQUEST_TEMPLATE.md) when opening a PR. ## License