Skip to content

Commit 4217787

Browse files
committed
Remove weak reference construct from fenv code.
I grepped through the FreeBSD source tree and for me, it seems to be totally unclear why these two specific functions are weak references. Such a construct is commonly used by FreeBSD's threading library (libthr) to override certain functions, but I can't find any traces of that. Just use the function name directly. This fixes a compiler warning as well (-Wmissing-prototypes).
1 parent 89ac4d4 commit 4217787

2 files changed

Lines changed: 4 additions & 10 deletions

File tree

amd64/fenv.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ feupdateenv(const fenv_t *envp)
128128
}
129129

130130
int
131-
__feenableexcept(int mask)
131+
feenableexcept(int mask)
132132
{
133133
uint32_t mxcsr, omask;
134134
uint16_t control;
@@ -145,7 +145,7 @@ __feenableexcept(int mask)
145145
}
146146

147147
int
148-
__fedisableexcept(int mask)
148+
fedisableexcept(int mask)
149149
{
150150
uint32_t mxcsr, omask;
151151
uint16_t control;
@@ -160,6 +160,3 @@ __fedisableexcept(int mask)
160160
__ldmxcsr(mxcsr);
161161
return (omask);
162162
}
163-
164-
__weak_reference(__feenableexcept, feenableexcept);
165-
__weak_reference(__fedisableexcept, fedisableexcept);

i387/fenv.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ feupdateenv(const fenv_t *envp)
182182
}
183183

184184
int
185-
__feenableexcept(int mask)
185+
feenableexcept(int mask)
186186
{
187187
uint32_t mxcsr, omask;
188188
uint16_t control;
@@ -204,7 +204,7 @@ __feenableexcept(int mask)
204204
}
205205

206206
int
207-
__fedisableexcept(int mask)
207+
fedisableexcept(int mask)
208208
{
209209
uint32_t mxcsr, omask;
210210
uint16_t control;
@@ -224,6 +224,3 @@ __fedisableexcept(int mask)
224224
}
225225
return (omask);
226226
}
227-
228-
__weak_reference(__feenableexcept, feenableexcept);
229-
__weak_reference(__fedisableexcept, fedisableexcept);

0 commit comments

Comments
 (0)