Skip to content

Commit 872675d

Browse files
authored
Merge pull request #74 from JuliaMath/teh/amb
Fix an ambiguity on julia 0.6
2 parents 9a1b40a + 3bf4701 commit 872675d

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

src/normed.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ zero(x::Normed) = zero(typeof(x))
3636
rawone(v) = reinterpret(one(v))
3737

3838
# Conversions
39-
convert{T<:Normed}(::Type{T}, x::T) = x
39+
convert{T<:Unsigned,f}(::Type{Normed{T,f}}, x::Normed{T,f}) = x
4040
convert{T1<:Unsigned,T2<:Unsigned,f}(::Type{Normed{T1,f}}, x::Normed{T2,f}) = Normed{T1,f}(convert(T1, x.i), 0)
4141
function convert{T<:Unsigned,T2<:Unsigned,f}(::Type{Normed{T,f}}, x::Normed{T2})
4242
U = Normed{T,f}
@@ -45,7 +45,6 @@ function convert{T<:Unsigned,T2<:Unsigned,f}(::Type{Normed{T,f}}, x::Normed{T2})
4545
reinterpret(U, _unsafe_trunc(T, y))
4646
end
4747
convert{U<:Normed}(::Type{U}, x::Real) = _convert(U, rawtype(U), x)
48-
convert{T1,T2,f}(::Type{Normed{T1,f}}, x::Normed{T2,f}) = Normed{T1,f}(convert(T1, x.i), 0)
4948

5049
convert(::Type{N0f16}, x::N0f8) = reinterpret(N0f16, convert(UInt16, 0x0101*reinterpret(x)))
5150
function _convert{U<:Normed,T}(::Type{U}, ::Type{T}, x)

test/normed.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ end
6565
@test_throws ArgumentError convert(Normed{UInt128,100}, 10.0^9)
6666

6767
x = N0f8(0.5)
68+
@test convert(N0f8, x) === x
6869
@test isfinite(x) == true
6970
@test isnan(x) == false
7071
@test isinf(x) == false

0 commit comments

Comments
 (0)