Skip to content

Commit 3194b28

Browse files
authored
Merge pull request #87 from JuliaMath/teh/realmin
realmin should be equal to eps for FixedPoint. Fixes #79.
2 parents 1f7d94d + c635f67 commit 3194b28

3 files changed

Lines changed: 5 additions & 2 deletions

File tree

src/FixedPointNumbers.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ isinteger{T,f}(x::FixedPoint{T,f}) = (x.i&(1<<f-1)) == 0
6868
# traits
6969
typemax{T<: FixedPoint}(::Type{T}) = T(typemax(rawtype(T)), 0)
7070
typemin{T<: FixedPoint}(::Type{T}) = T(typemin(rawtype(T)), 0)
71-
realmin{T<: FixedPoint}(::Type{T}) = typemin(T)
71+
realmin{T<: FixedPoint}(::Type{T}) = eps(T)
7272
realmax{T<: FixedPoint}(::Type{T}) = typemax(T)
7373

7474
widen1(::Type{Int8}) = Int16

test/fixed.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,3 +126,6 @@ for T in (Fixed{Int8,8}, Fixed{Int16,8}, Fixed{Int16,10}, Fixed{Int32,16})
126126
@test isa(a, Array{T,2})
127127
@test size(a) == (3,5)
128128
end
129+
130+
# issue #79
131+
@test realmin(Q11f4) == Q11f4(0.06)

test/normed.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ for T in (FixedPointNumbers.UF..., UF2...)
3535
@test one(T) == 1
3636
@test one(T) * one(T) == one(T)
3737
@test typemin(T) == 0
38-
@test realmin(T) == 0
38+
@test realmin(T) == eps(T)
3939
@test eps(zero(T)) == eps(typemax(T))
4040
@test sizeof(T) == sizeof(FixedPointNumbers.rawtype(T))
4141
end

0 commit comments

Comments
 (0)