From 5d3f7f015bcb209846e396b9cf241a762a18c19c Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Fri, 8 May 2026 15:24:01 +0000
Subject: [PATCH 1/2] Initial plan


From 212a539e2fc79fc08eec7858ee32ff216136a77e Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Fri, 8 May 2026 15:39:46 +0000
Subject: [PATCH 2/2] fix: enable proper mypy checking for
 idc_index_data_manager.py

- Add a separate mypy pre-commit hook entry for scripts/python/idc_index_data_manager.py
  using --explicit-package-bases to resolve consistent module naming
- Add google-cloud-storage to both mypy hooks' additional_dependencies
  so future google.cloud.storage imports are covered
- Add [[tool.mypy.overrides]] for scripts.python.idc_index_data_manager
  to disable attr-defined and import-untyped errors (handles the known
  ruff/mypy conflict for google.cloud.storage deferred imports)

Agent-Logs-Url: https://github.com/ImagingDataCommons/idc-index-data/sessions/e35c5d48-55ec-45fa-ae54-c20d15f4862f

Co-authored-by: fedorov <313942+fedorov@users.noreply.github.com>
---
 .pre-commit-config.yaml | 9 +++++++++
 pyproject.toml          | 5 +++++
 2 files changed, 14 insertions(+)

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 553d7ca..ebfda65 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -58,6 +58,15 @@ repos:
           - pytest
           - pandas-stubs
           - google-cloud-bigquery
+          - google-cloud-storage
+      - id: mypy
+        name: mypy (scripts)
+        files: ^scripts/python/idc_index_data_manager\.py$
+        args: ["--explicit-package-bases"]
+        additional_dependencies:
+          - pandas-stubs
+          - google-cloud-bigquery
+          - google-cloud-storage
 
   - repo: https://github.com/codespell-project/codespell
     rev: "v2.4.2"
diff --git a/pyproject.toml b/pyproject.toml
index be1d56d..5ecf7ce 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -131,6 +131,11 @@ module = "idc_index_data._version"
 ignore_missing_imports = true
 
 
+[[tool.mypy.overrides]]
+module = "scripts.python.idc_index_data_manager"
+disable_error_code = ["attr-defined", "import-untyped"]
+
+
 [tool.ruff]
 src = ["src", "scripts"]