Skip to content

Fix deprecated lag_matrix argument names (filling, drop_missing) #27

Description

@Hugo-W

Summary

lag_matrix emits DeprecationWarning for two keyword arguments:

  • filling (deprecated, replaced by another name)
  • drop_missing (deprecated, replaced by another name)

Impact

32 DeprecationWarnings are produced across the test suite on every run. While not failures, they clutter output and the deprecated arguments will be removed in a future version, at which point callers will break.

Fix

Replace the deprecated argument names with their current equivalents in all call sites. Per the lag_matrix docstring:

  • filling=... → use the current argument name
  • drop_missing=... → use the current argument name

Affected files (call sites)

  • tests/test_regression.py (multiple)
  • tests/test_solvers.py
  • tests/test_utils.py
  • pyeeg/models.py (the fit method calls lag_matrix with both deprecated kwargs)

Reproduction

uv run pytest tests/ -q 2>&1 | grep DeprecationWarning

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions