Skip to content

Commit 25e96d5

Browse files
committed
Address reviewer changes - make previews private and remove white space
1 parent 9d3ac1b commit 25e96d5

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

app/src/main/java/org/schabi/newpipe/ui/components/common/ErrorPanel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ fun ErrorPanel(
9090
@Preview(name = "Light mode", uiMode = Configuration.UI_MODE_NIGHT_NO)
9191
@Preview(name = "Dark mode", uiMode = Configuration.UI_MODE_NIGHT_YES)
9292
@Composable
93-
fun ErrorPanelPreview() {
93+
private fun ErrorPanelPreview() {
9494
AppTheme {
9595
ErrorPanel(
9696
errorInfo = ErrorInfo(

app/src/main/java/org/schabi/newpipe/ui/components/common/ServiceColoredButton.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.schabi.newpipe.ui.components.common
22

3+
import android.content.res.Configuration
34
import androidx.compose.foundation.layout.PaddingValues
45
import androidx.compose.foundation.layout.RowScope
56
import androidx.compose.foundation.layout.wrapContentWidth
@@ -40,9 +41,10 @@ fun ServiceColoredButton(
4041
}
4142
}
4243

43-
@Preview
44+
@Preview(name = "Light mode", uiMode = Configuration.UI_MODE_NIGHT_NO)
45+
@Preview(name = "Dark mode", uiMode = Configuration.UI_MODE_NIGHT_YES)
4446
@Composable
45-
fun ServiceColoredButtonPreview() {
47+
private fun ServiceColoredButtonPreview() {
4648
AppTheme {
4749
ServiceColoredButton(
4850
onClick = {},

app/src/main/java/org/schabi/newpipe/ui/components/video/comment/CommentSection.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ private fun CommentSection(
122122
Box(
123123
modifier = Modifier
124124
.fillMaxWidth()
125-
126125
) {
127126
ErrorPanel(
128127
errorInfo = errorInfo,

0 commit comments

Comments
 (0)