You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to #2153 / #2176 (baseUrl/paths resolution). Two gaps from review:
extends-inherited baseUrl is not honored. _load_tsconfig_base_url parses only the leaf config, so a tsconfig.json with "extends": "./tsconfig.base.json" where the base declares baseUrl resolves to None (common monorepo/NestJS shape). Mirror the extends-chain handling that _read_tsconfig_aliases already has (child declaration wins; resolve each baseUrl relative to the config that declares it; skip @-scoped npm configs; circular-guard).
Also apply an isinstance(compilerOptions, dict) guard so a "compilerOptions": null config does not raise AttributeError (pre-existing in the alias loader too).
Follow-up to #2153 / #2176 (baseUrl/paths resolution). Two gaps from review:
extends-inheritedbaseUrlis not honored._load_tsconfig_base_urlparses only the leaf config, so atsconfig.jsonwith"extends": "./tsconfig.base.json"where the base declaresbaseUrlresolves to None (common monorepo/NestJS shape). Mirror the extends-chain handling that_read_tsconfig_aliasesalready has (child declaration wins; resolve each baseUrl relative to the config that declares it; skip @-scoped npm configs; circular-guard).isinstance(compilerOptions, dict)guard so a"compilerOptions": nullconfig does not raise AttributeError (pre-existing in the alias loader too).//comments,/* */, and trailing commas with a baseUrl resolves (the code already strips JSONC via the _read_tsconfig_aliases() silently fails on tsconfig.json with comments — every JS/TS project hits this #700 helper, but there is no test).