Skip to content

Some of the query errors will crash the system #32

Description

@rebelsky

I've just been fixing a bug in module.exports.createAlbum in functions/albums.js. When the call fails, it calls res.end(error). But since the error was returned from an SQL query, there's no guarantee that it's a string. Since it's not a string, and res.end expects a string, the server crashes.

I've fixed the bug in albums.js, but a quick glance suggests that we call res.end(error) a lot.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions