Skip to content

Commit b1f9206

Browse files
committed
Upgrade DTOs to the latest open API spec (#178)
* Upgrade DTOs to the latest open API spec * Add missing DTO mapping * Add missing DTO mapping * fix ban-related integration tests * Upgrade DTOs to the latest openAPI spec * Upgrade DTOs to the latest NSwag version * Fix field type * update MemberCount from DTOs + fix event type + cleanup
1 parent 9c3520d commit b1f9206

4 files changed

Lines changed: 8 additions & 2 deletions

File tree

Assets/Plugins/StreamChat/Core/InternalDTO/Responses/MessageResponseInternalDTO.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ internal partial class MessageResponseInternalDTO
1818
{
1919
[Newtonsoft.Json.JsonProperty("message", Required = Newtonsoft.Json.Required.Default, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
2020
public MessageInternalDTO Message { get; set; }
21+
2122
[Newtonsoft.Json.JsonProperty("attachments", Required = Newtonsoft.Json.Required.Default, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
2223
public System.Collections.Generic.List<AttachmentInternalDTO> Attachments { get; set; } = new System.Collections.Generic.List<AttachmentInternalDTO>();
2324

Assets/Plugins/StreamChat/Core/LowLevelClient/Events/EventHealthCheck.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ public partial class EventHealthCheck : EventBase, ILoadableFrom<HealthCheckEven
1313

1414
public string Type { get; set; }
1515

16-
//Not in OpenAPI syntax but mentioned in docs
1716
public string ConnectionId { get; set; }
1817

1918
EventHealthCheck ILoadableFrom<HealthCheckEventInternalDTO, EventHealthCheck>.LoadFromDto(HealthCheckEventInternalDTO dto)

Assets/Plugins/StreamChat/Core/LowLevelClient/Models/ChannelMember.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ ChannelMember ILoadableFrom<ChannelMemberInternalDTO, ChannelMember>.LoadFromDto
8686
User = User.TryLoadFromDto<UserObjectInternalDTO, User>(dto.User);
8787
UserId = dto.UserId;
8888
AdditionalProperties = dto.AdditionalProperties;
89+
//StreamTodo: would be safer to update the dictionary instead of overwriting the reference
8990

9091
return this;
9192
}
@@ -107,6 +108,7 @@ ChannelMember ILoadableFrom<ChannelMemberResponseInternalDTO, ChannelMember>.Loa
107108
User = User.TryLoadFromDto<UserResponseInternalDTO, User>(dto.User);
108109
UserId = dto.UserId;
109110
AdditionalProperties = dto.AdditionalProperties;
111+
//StreamTodo: would be safer to update the dictionary instead of overwriting the reference
110112

111113
return this;
112114
}

Assets/Plugins/StreamChat/Core/StatefulModels/StreamChannel.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -697,6 +697,8 @@ internal void InternalHandleMessageNewNotification(NotificationNewMessageEventIn
697697
{
698698
AssertCid(dto.Cid);
699699
InternalAppendOrUpdateMessage(dto.Message);
700+
701+
MemberCount = dto.ChannelMemberCount;
700702
}
701703

702704
internal void HandleMessageUpdatedEvent(MessageUpdatedEventInternalDTO dto)
@@ -742,20 +744,22 @@ internal void HandleChannelUpdatedEvent(ChannelUpdatedEventInternalDTO eventDto)
742744
// Cache.TryCreateOrUpdate(eventDto.Channel);
743745

744746
UpdateChannelFieldsFromDtoOverwrite(eventDto.Channel, Cache);
745-
747+
MemberCount = eventDto.ChannelMemberCount;
746748
Updated?.Invoke(this);
747749
}
748750

749751
internal void HandleChannelTruncatedEvent(ChannelTruncatedEventInternalDTO eventDto)
750752
{
751753
AssertCid(eventDto.Cid);
752754
InternalTruncateMessages(eventDto.Channel.TruncatedAt, eventDto.Message);
755+
MemberCount = eventDto.ChannelMemberCount;
753756
}
754757

755758
internal void HandleChannelTruncatedEvent(NotificationChannelTruncatedEventInternalDTO eventDto)
756759
{
757760
AssertCid(eventDto.Cid);
758761
InternalTruncateMessages(eventDto.Channel.TruncatedAt);
762+
MemberCount = eventDto.ChannelMemberCount;
759763
}
760764

761765
internal void InternalAddMember(StreamChannelMember member)

0 commit comments

Comments
 (0)