Feature/fix flaky test (#162)

* Fix test not to use hardcoded channel ID (this can fail when tests are executed concurrently  on multiple machines)

* Remove redundant check (this was needed when channel id was passed as arg)

Author: sierpinskid

Assets/Plugins/StreamChat/Tests/LowLevelClient/Integration/BaseIntegrationTests.cs

@@ -75,24 +75,6 @@ protected async Task<ChannelState> CreateTempUniqueChannelAsync(string channelTy
         {
             var channelId = "random-channel-" + Guid.NewGuid();
 
-            var channelsResponse = await LowLevelClient.ChannelApi.QueryChannelsAsync(new QueryChannelsRequest()
-            {
-                FilterConditions = new Dictionary<string, object>
-                {
-                    {
-                        "id", new Dictionary<string, object>
-                        {
-                            { "$in", new[] { channelId } }
-                        }
-                    }
-                }
-            });
-
-            if (channelsResponse.Channels != null && channelsResponse.Channels.Count > 0)
-            {
-                Debug.LogError($"Channel with id {channelId} already exists!");
-            }
-
             var channelState = await Try(() => LowLevelClient.ChannelApi.GetOrCreateChannelAsync(channelType, channelId,
                 channelGetOrCreateRequest), state => state != null);
 

Assets/Plugins/StreamChat/Tests/LowLevelClient/Integration/ChannelApiIntegrationTests.cs

@@ -338,17 +338,14 @@ public IEnumerator When_deleting_non_existing_channel_expect_fail()
         {
             yield return LowLevelClient.WaitForClientToConnect();
 
-            var channelType = "messaging";
-            var channelId = "new-channel-id-1";
+            const string channelType = "messaging";
 
             var createChannelTask =
-                LowLevelClient.ChannelApi.GetOrCreateChannelAsync(channelType, channelId,
-                    new ChannelGetOrCreateRequest());
+                CreateTempUniqueChannelAsync(channelType, new ChannelGetOrCreateRequest());
 
-            yield return createChannelTask.RunAsIEnumerator(response =>
-            {
-                Assert.AreEqual(response.Channel.Id, channelId);
-            });
+            yield return createChannelTask.RunAsIEnumerator();
+
+            var channelId = createChannelTask.Result.Channel.Id;
 
             var deleteChannelTask
                 = LowLevelClient.ChannelApi.DeleteChannelAsync(channelType, channelId, isHardDelete: false);