Bugfix/fix flaky test (#176)

* fix formatting

* Fix test failing if WS event was not received until API call finished

* Fix test failing if the API call took too long due to rate limit error

* fix waiting for valid condition

Author: sierpinskid

Assets/Plugins/StreamChat/Samples/UnreadCountsCodeSamples.cs

@@ -48,7 +48,7 @@ public void ChannelsReadState()
         {
             IStreamChannel channel = null;
 
-// Every channel maintains a full list of read state for each channel member
+            // Every channel maintains a full list of read state for each channel member
             foreach (var read in channel.Read)
             {
                 Debug.Log(read.User); // User
@@ -62,41 +62,41 @@ public async Task MarkRead2()
             IStreamChannel channel = null;
             IStreamMessage message = null;
 
-// Mark this message as last read
+            // Mark this message as last read
             await message.MarkMessageAsLastReadAsync();
 
-// Mark whole channel as read
+            // Mark whole channel as read
             await channel.MarkChannelReadAsync();
         }
 
         public async Task GetCurrentUnreadCounts()
         {
-var current = await Client.GetLatestUnreadCountsAsync();
+            var current = await Client.GetLatestUnreadCountsAsync();
 
-Debug.Log(current.TotalUnreadCount); // Total unread messages
-Debug.Log(current.TotalUnreadThreadsCount); // Total unread threads
+            Debug.Log(current.TotalUnreadCount); // Total unread messages
+            Debug.Log(current.TotalUnreadThreadsCount); // Total unread threads
 
-foreach (var unreadChannel in current.UnreadChannels)
-{
-    Debug.Log(unreadChannel.ChannelCid); // CID of the channel with unread messages
-    Debug.Log(unreadChannel.UnreadCount); // Count of unread messages
-    Debug.Log(unreadChannel.LastRead); // Datetime of the last read message
-}
+            foreach (var unreadChannel in current.UnreadChannels)
+            {
+                Debug.Log(unreadChannel.ChannelCid); // CID of the channel with unread messages
+                Debug.Log(unreadChannel.UnreadCount); // Count of unread messages
+                Debug.Log(unreadChannel.LastRead); // Datetime of the last read message
+            }
 
-foreach (var unreadChannelByType in current.UnreadChannelsByType)
-{
-    Debug.Log(unreadChannelByType.ChannelType); // Channel type
-    Debug.Log(unreadChannelByType.ChannelCount); // How many channels of this type have unread messages
-    Debug.Log(unreadChannelByType.UnreadCount); // How many unread messages in all channels of this type
-}
+            foreach (var unreadChannelByType in current.UnreadChannelsByType)
+            {
+                Debug.Log(unreadChannelByType.ChannelType); // Channel type
+                Debug.Log(unreadChannelByType.ChannelCount); // How many channels of this type have unread messages
+                Debug.Log(unreadChannelByType.UnreadCount); // How many unread messages in all channels of this type
+            }
 
-foreach (var unreadThread in current.UnreadThreads)
-{
-    Debug.Log(unreadThread.ParentMessageId); // Message ID of the parent message for this thread
-    Debug.Log(unreadThread.LastReadMessageId); // Last read message in this thread
-    Debug.Log(unreadThread.UnreadCount); // Count of unread messages
-    Debug.Log(unreadThread.LastRead); // Datetime of the last read message
-}
+            foreach (var unreadThread in current.UnreadThreads)
+            {
+                Debug.Log(unreadThread.ParentMessageId); // Message ID of the parent message for this thread
+                Debug.Log(unreadThread.LastReadMessageId); // Last read message in this thread
+                Debug.Log(unreadThread.UnreadCount); // Count of unread messages
+                Debug.Log(unreadThread.LastRead); // Datetime of the last read message
+            }
         }
 
         private IStreamChatClient Client { get; } = StreamChatClient.CreateDefaultClient();

Assets/Plugins/StreamChat/Tests/StatefulClient/ChannelsTests.cs

@@ -655,8 +655,13 @@ private async Task When_unfreezing_a_frozen_channel_expect_channel_unfrozen_Asyn
         {
             var channel = await CreateUniqueTempChannelAsync();
             await channel.FreezeAsync();
+            
+            await WaitWhileFalseAsync(() => channel.Frozen);
             Assert.IsTrue(channel.Frozen);
+            
             await channel.UnfreezeAsync();
+            
+            await WaitWhileTrueAsync(() => channel.Frozen);
             Assert.IsFalse(channel.Frozen);
 
             await channel.SendNewMessageAsync("MessageAfterUnfrozenChannel");

Assets/Plugins/StreamChat/Tests/StatefulClient/MessagesTests.cs

@@ -207,13 +207,14 @@ public async Task When_message_pin_with_expire_expected_message_pinned_with_expi
             var sentMessage = await channel.SendNewMessageAsync(MessageText);
             Assert.AreEqual(sentMessage.Text, MessageText);
 
-            await sentMessage.PinAsync(DateTime.UtcNow.Add(new TimeSpan(0, 0, 10, 0)));
+            // Use hours because due to rate limit the response can potentially take some time
+            var targetExpiryDate = DateTime.UtcNow.Add(new TimeSpan(0, 5, 0, 0));
+            await sentMessage.PinAsync(targetExpiryDate);
+            await WaitWhileFalseAsync(() => sentMessage.Pinned && sentMessage.PinExpires.HasValue);
 
-            var messageInChannel = channel.Messages.FirstOrDefault(_ => _.Id == sentMessage.Id);
-            Assert.AreEqual(true, messageInChannel.Pinned);
+            Assert.AreEqual(true, sentMessage.Pinned);
 
-            var expiresInMinutes = (messageInChannel.PinExpires.Value - DateTime.UtcNow).TotalMinutes;
-            Assert.That(expiresInMinutes, Is.InRange(9, 11));
+            Assert.That(sentMessage.PinExpires.Value, Is.EqualTo(new DateTimeOffset(targetExpiryDate)).Within(3).Minutes);
         }
 
         [UnityTest]