Skip to content

Commit 3702caa

Browse files
authored
fix(styling): use correct inverse text color tokens (#3125)
### 🎯 Goal Fix broken text colors on inverse-themed surfaces (notifications, gallery overlays, inverse badges). These components rendered with nearly invisible text because they referenced undefined CSS variables. ### 🛠 Implementation details The Figma-generated theme tokens renamed `--text-inverse` → `--text-on-inverse` and `--badge-text-inverse` → `--badge-text-on-inverse`, but three SCSS files still referenced the old names. Since the old variables are undefined in the compiled CSS, the `color` property fell back to the inherited value (`--text-primary`), producing dark-on-dark (light mode) or light-on-light (dark mode) text. **Files changed:** - **`Notification.scss`** — notification toast text + commented-out severity variants - **`ModalGallery.scss`** — load-failed indicator color + "+N more" overlay text - **`Badge.scss`** — inverse badge variant text color The correctly named tokens (`--text-on-inverse`, `--badge-text-on-inverse`) are already defined in both `light.scss` (#ffffff) and `dark.scss` (#000000). ### 🎨 UI Changes Notification toasts, gallery overlays with "+N more" count, image load-failed indicators, and inverse badges now have legible text on their inverse backgrounds in both light and dark mode.
1 parent f131a6a commit 3702caa

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

src/components/Attachment/styling/ModalGallery.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
.str-chat__message {
44
--str-chat__modal-gallery-load-failed-indicator-background: var(--accent-error);
5-
--str-chat__modal-gallery-load-failed-indicator-color: var(--text-inverse);
5+
--str-chat__modal-gallery-load-failed-indicator-color: var(--text-on-inverse);
66
--str-chat__modal-gallery-loading-background: var(--chat-bg);
77
--str-chat__modal-gallery-loading-base: var(--skeleton-loading-base);
88
--str-chat__modal-gallery-loading-highlight: var(--skeleton-loading-highlight);
@@ -64,7 +64,7 @@
6464
cursor: zoom-in;
6565
// CDN resize requires max-width to be present on this element
6666
max-width: $max-width;
67-
color: var(--text-inverse);
67+
color: var(--text-on-inverse);
6868
border: none;
6969
font-size: var(--typography-font-size-2xl);
7070
font-weight: var(--typography-font-weight-medium);

src/components/Badge/styling/Badge.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
.str-chat__badge--variant-inverse {
4040
background: var(--badge-bg-inverse);
41-
color: var(--badge-text-inverse);
41+
color: var(--badge-text-on-inverse);
4242
border-color: var(--badge-border);
4343
}
4444

src/components/Notifications/styling/Notification.scss

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
0 0 0 1px rgba(0, 0, 0, 0.05),
1414
0 4px 8px 0 rgba(0, 0, 0, 0.14),
1515
0 12px 24px 0 rgba(0, 0, 0, 0.1);
16-
color: var(--str-chat__notification-color, var(--text-inverse));
16+
color: var(--str-chat__notification-color, var(--text-on-inverse));
1717

1818
.str-chat__notification-content {
1919
align-items: flex-start;
@@ -94,22 +94,22 @@
9494
//// Severity overrides: allow themes to keep colored variants; defaults match Figma (inverse).
9595
//.str-chat__notification--success {
9696
// background: var(--str-chat-success-background, var(--background-core-inverse));
97-
// color: var(--str-chat-success-color, var(--text-inverse));
97+
// color: var(--str-chat-success-color, var(--text-on-inverse));
9898
//}
9999
//
100100
//.str-chat__notification--error {
101101
// background: var(--str-chat-error-background, var(--background-core-inverse));
102-
// color: var(--str-chat-error-color, var(--text-inverse));
102+
// color: var(--str-chat-error-color, var(--text-on-inverse));
103103
//}
104104
//
105105
//.str-chat__notification--warning {
106106
// background: var(--str-chat-warning-background, var(--background-core-inverse));
107-
// color: var(--str-chat-warning-color, var(--text-inverse));
107+
// color: var(--str-chat-warning-color, var(--text-on-inverse));
108108
//}
109109
//
110110
//.str-chat__notification--info {
111111
// background: var(--str-chat-info-background, var(--background-core-inverse));
112-
// color: var(--str-chat-info-color, var(--text-inverse));
112+
// color: var(--str-chat-info-color, var(--text-on-inverse));
113113
//}
114114

115115
// Loading state: spin the refresh icon

0 commit comments

Comments
 (0)