From 9b3053102f0213790005acffa26264ac7b2f9d2c Mon Sep 17 00:00:00 2001 From: Vikrant Date: Wed, 16 Sep 2026 21:48:18 +0530 Subject: [PATCH] Simplify the summer-semester label formula format_semester_display special-cased semester 2, 4, 6 and 8 to Summer 1 through Summer 4 and only fell back to the general semester_no // 2 formula past that point. The formula already gives the same answer for those four cases, so the special-casing was dead weight rather than a guard against anything -- collapsed to the one line that was already doing the real work. --- FusionIIIT/applications/examination/api/views.py | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/FusionIIIT/applications/examination/api/views.py b/FusionIIIT/applications/examination/api/views.py index 19cd36420..e275e285d 100644 --- a/FusionIIIT/applications/examination/api/views.py +++ b/FusionIIIT/applications/examination/api/views.py @@ -101,21 +101,13 @@ def resolve_programme_list(programme_type): # Helper function to format semester display for PDFs def format_semester_display(semester_no, semester_type=None, semester_label=None): + # A summer term is numbered from the even semester right before it, for + # any semester count -- not just the first four. if semester_label and 'summer' in semester_label.lower(): return semester_label if semester_type and 'summer' in semester_type.lower(): - if semester_no == 2: - return "Summer 1" - elif semester_no == 4: - return "Summer 2" - elif semester_no == 6: - return "Summer 3" - elif semester_no == 8: - return "Summer 4" - else: - return f"Summer {semester_no // 2}" - else: - return str(semester_no) + return f"Summer {semester_no // 2}" + return str(semester_no) def round_from_last_decimal(number, decimal_places=1): """Round a number to `decimal_places` using ROUND_HALF_UP."""