feat(Preferences/SponsorBlock): drop VISIBLE option

Drops the `VISIBLE` option for SponsorBlock, as it provides no additional value
and leads to bad UX, as a user is able to see the segment, but able to skip
it.
Existing users are migrated to the `MANUAL` option.

Ref: libre-tube@f5c4015
Ref: libre-tube@9ceb258

Author: FineFindus

app/src/main/java/com/github/libretube/enums/SbSkipOptions.kt

@@ -2,7 +2,6 @@ package com.github.libretube.enums
 
 enum class SbSkipOptions {
     OFF,
-    VISIBLE,
     MANUAL,
     AUTOMATIC,
     AUTOMATIC_ONCE

app/src/main/java/com/github/libretube/helpers/PreferenceHelper.kt

@@ -6,7 +6,10 @@ import android.util.Log
 import androidx.core.content.edit
 import androidx.preference.PreferenceManager
 import com.github.libretube.BuildConfig
+import com.github.libretube.LibreTubeApp
+import com.github.libretube.R
 import com.github.libretube.constants.PreferenceKeys
+import com.github.libretube.enums.SbSkipOptions
 
 object PreferenceHelper {
     private val TAG = PreferenceHelper::class.simpleName
@@ -43,6 +46,19 @@ object PreferenceHelper {
         if (prefVersion == BuildConfig.VERSION_CODE)
             return
 
+        if (prefVersion < 63) {
+            Log.i(TAG, "Migration to prefs v63")
+            LibreTubeApp.instance.resources
+                .getStringArray(R.array.sponsorBlockSegments)
+                .forEach { category ->
+                    val key = "${category}_category"
+                    val stored = getString(key, "visible")
+                    if (stored == "visible") {
+                        putString(key, SbSkipOptions.MANUAL.name.lowercase())
+                    }
+                }
+        }
+
         // mark as successfully migrated
         putInt(PreferenceKeys.PREFERENCE_VERSION, BuildConfig.VERSION_CODE)
     }

app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt

@@ -1014,8 +1014,8 @@ class PlayerFragment : Fragment(R.layout.fragment_player), OnlinePlayerOptions {
         if (segmentData != null && commonPlayerViewModel.isMiniPlayerVisible.value != true) {
             val (segment, sbSkipOption) = segmentData
 
-            val autoSkipTemporarilyDisabled = !binding.player.sponsorBlockAutoSkip &&
-                    sbSkipOption !in arrayOf(SbSkipOptions.OFF, SbSkipOptions.VISIBLE)
+            val autoSkipTemporarilyDisabled =
+                !binding.player.sponsorBlockAutoSkip && sbSkipOption != SbSkipOptions.OFF
 
             if (sbSkipOption in arrayOf(
                     SbSkipOptions.AUTOMATIC_ONCE,

app/src/main/res/values/array.xml

@@ -422,15 +422,13 @@
 
     <string-array name="sb_skip_options">
         <item>@string/off</item>
-        <item>@string/visible</item>
         <item>@string/manual</item>
         <item>@string/automatic</item>
         <item>@string/automatic_once</item>
     </string-array>
 
     <string-array name="sb_skip_options_values">
         <item>off</item>
-        <item>visible</item>
         <item>manual</item>
         <item>automatic</item>
         <item>automatic_once</item>