fix: thumbnails of videos containing '#' can't be downloaded

Bnyro · Bnyro · commit b3e4a243a919 · 2025-03-31T17:18:45.000+02:00
diff --git a/app/src/main/java/com/github/libretube/services/DownloadService.kt b/app/src/main/java/com/github/libretube/services/DownloadService.kt
@@ -172,7 +172,7 @@ class DownloadService : LifecycleService() {
         try {
             ImageHelper.downloadImage(
                 this@DownloadService,
-                streams.thumbnailUrl,
+                ProxyHelper.rewriteUrlUsingProxyPreference(streams.thumbnailUrl),
                 thumbnailTargetPath
             )
         } catch (e: Exception) {
diff --git a/app/src/main/java/com/github/libretube/util/TextUtils.kt b/app/src/main/java/com/github/libretube/util/TextUtils.kt
@@ -29,7 +29,7 @@ object TextUtils {
     /**
      * Reserved characters by unix which can not be used for file name.
      */
-    const val RESERVED_CHARS = "?:\"*|/\\<>\u0000"
+    const val RESERVED_CHARS = "#?:\"*|/\\<>\u0000"
 
     /**
      * Date time formatter which uses the [FormatStyle.MEDIUM] format style.

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ class DownloadService : LifecycleService() {`
`172`	`172`	`try {`
`173`	`173`	`ImageHelper.downloadImage(`
`174`	`174`	`this@DownloadService,`
`175`		`- streams.thumbnailUrl,`
	`175`	`+ ProxyHelper.rewriteUrlUsingProxyPreference(streams.thumbnailUrl),`
`176`	`176`	`thumbnailTargetPath`
`177`	`177`	`)`
`178`	`178`	`} catch (e: Exception) {`