From b9d151ef0ed53d997ed2470e3bc356513cc05d62 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Fri, 16 Oct 2026 10:21:33 +0000
Subject: [PATCH] Remove js/preferences.js, orphaned by the room-needs-filter
 removal

The room-needs filter was removed in b9397a6 (2026-09-23, "Remove the room
needs filter"), which trimmed index.html and js/app.js but left
js/preferences.js's ROOM_FEATURES table and roomFeatureLabels() behind along
with their test. Nothing imports the module any more: it is not in sw.js's
SHELL_ASSETS, not in index.html's two <script> tags, not statically imported
by any js/*.js file, and the app's only dynamic import() targets js/dev.js.
scripts/test/screens.test.mjs already asserts the room screen's markup does
not reference roomFeatureLabels.

privacy.html's JS-file count drops from 15 to 14 to match.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016RTHekdsXHLYUvG6qYHA4J
---
 js/preferences.js                 | 18 ------------------
 privacy.html                      |  2 +-
 scripts/test/preferences.test.mjs | 11 -----------
 3 files changed, 1 insertion(+), 30 deletions(-)
 delete mode 100644 js/preferences.js
 delete mode 100644 scripts/test/preferences.test.mjs

diff --git a/js/preferences.js b/js/preferences.js
deleted file mode 100644
index 24bd44a..0000000
--- a/js/preferences.js
+++ /dev/null
@@ -1,18 +0,0 @@
-// Ohio State Registrar room characteristics. The numeric codes stay compact in
-// the room index; this table supplies the vocabulary shown on the room screen.
-export const ROOM_FEATURES = Object.freeze([
-  { id: 'movable-tablet', code: 30, label: 'Movable tablet-arm chairs', short: 'movable tablet-arm chairs' },
-  { id: 'stationary-tablet', code: 31, label: 'Stationary tablet-arm chairs', short: 'stationary tablet-arm chairs' },
-  { id: 'movable-tables', code: 32, label: 'Movable tables and chairs', short: 'movable tables and chairs' },
-  { id: 'stationary-tables', code: 33, label: 'Stationary tables and chairs', short: 'stationary tables and chairs' },
-  { id: 'tiered', code: 37, label: 'Sloped or tiered floor', short: 'a tiered floor' },
-  { id: 'windows', code: 39, label: 'Windows', short: 'windows' },
-  { id: 'chalkboards', code: 43, label: 'Chalkboards', short: 'chalkboards' },
-  { id: 'whiteboards', code: 44, label: 'Whiteboards', short: 'whiteboards' },
-]);
-
-export function roomFeatureLabels(room) {
-  if (!Array.isArray(room?.features)) return [];
-  const published = new Set(room.features.map(Number));
-  return ROOM_FEATURES.filter((feature) => published.has(feature.code)).map((feature) => feature.label);
-}
diff --git a/privacy.html b/privacy.html
index 1703400..e1efd0f 100644
--- a/privacy.html
+++ b/privacy.html
@@ -117,7 +117,7 @@ <h2>How that is true, and not just a promise</h2>
   you the words and none of the numbers.</p>
   <p>You can check: every line of the app is at
   <a href="https://github.com/EnesYilmazcode/Vacant">github.com/EnesYilmazcode/Vacant</a>,
-  and it is 15 JavaScript files with no build step, so what is in the
+  and it is 14 JavaScript files with no build step, so what is in the
   repository is what your browser runs.</p>
   <p>The app does store exactly one thing on your phone, and it is not about you:
   a key called <code>vacant:duration</code> holding how long you last said you
diff --git a/scripts/test/preferences.test.mjs b/scripts/test/preferences.test.mjs
deleted file mode 100644
index 20ea173..0000000
--- a/scripts/test/preferences.test.mjs
+++ /dev/null
@@ -1,11 +0,0 @@
-import { test } from 'node:test';
-import assert from 'node:assert/strict';
-
-import { roomFeatureLabels } from '../../js/preferences.js';
-
-test('room labels use the user-facing vocabulary', () => {
-  assert.deepEqual(roomFeatureLabels({ features: [44, 999, 32] }), [
-    'Movable tables and chairs',
-    'Whiteboards',
-  ]);
-});