From 3157216221ad62690823a791c7ef4b1a74283c10 Mon Sep 17 00:00:00 2001 From: KarlKallman Date: Mon, 3 Aug 2026 09:17:02 +0200 Subject: [PATCH 1/2] Changed default value for properties OutLineSummaryRight and OutLineSummaryBelow in ExcelWorksheet. Issue #2445 --- src/EPPlus/ExcelWorksheet.cs | 4 +- .../Issues/FormulaCalculationIssues.cs | 57 ------------------- src/EPPlusTest/Issues/WorksheetIssues.cs | 10 ++++ 3 files changed, 12 insertions(+), 59 deletions(-) diff --git a/src/EPPlus/ExcelWorksheet.cs b/src/EPPlus/ExcelWorksheet.cs index 38375c721..88925be54 100644 --- a/src/EPPlus/ExcelWorksheet.cs +++ b/src/EPPlus/ExcelWorksheet.cs @@ -955,7 +955,7 @@ public bool OutLineSummaryBelow get { CheckSheetTypeAndNotDisposed(); - return GetXmlNodeBool(outLineSummaryBelowPath); + return GetXmlNodeBool(outLineSummaryBelowPath, true); } set { @@ -972,7 +972,7 @@ public bool OutLineSummaryRight get { CheckSheetTypeAndNotDisposed(); - return GetXmlNodeBool(outLineSummaryRightPath); + return GetXmlNodeBool(outLineSummaryRightPath, true); } set { diff --git a/src/EPPlusTest/Issues/FormulaCalculationIssues.cs b/src/EPPlusTest/Issues/FormulaCalculationIssues.cs index 329f030de..5405496ea 100644 --- a/src/EPPlusTest/Issues/FormulaCalculationIssues.cs +++ b/src/EPPlusTest/Issues/FormulaCalculationIssues.cs @@ -1667,63 +1667,6 @@ public void s1050() } } - [TestMethod] - public void s1063_Isolated() - { - using (var p = OpenPackage("Search3ArgsArrays.xlsx", true)) - { - var ws = p.Workbook.Worksheets.Add("args"); - - ws.Cells["A1:A3"].Formula = "\"I.am.a.Beautiful.Creature\" & ROW()"; - - ws.Cells["A1:A3"].Calculate(); - - ws.Cells["B1:B3"].Formula = "(ROW()-1)*2 + 1"; - ws.Cells["B1:B3"].Calculate(); - - ws.Cells["C1"].CreateArrayFormula("SEARCH(\".\",A1:A3,B1:B3+1)", true); - ws.Cells["C1"].Calculate(); - - var range = ws.Cells["C1:C3"]; - - var myValues = ws.Cells["C1:C3"].Value; - - List intValues = new List(); - - foreach(var cell in range) - { - intValues.Add(cell.GetValue()); - } - - Assert.AreEqual(2, intValues[0]); - Assert.AreEqual(5, intValues[1]); - Assert.AreEqual(7, intValues[2]); - - SaveAndCleanup(p); - } - } - - [TestMethod] - public void s1063() - { - using (var p = OpenTemplatePackage("issues\\s1063.xlsx")) - { - var ws = p.Workbook.Worksheets[0]; - - ws.ClearFormulaValues(); - ws.Calculate(); - - Assert.AreEqual(ws.Cells["A1"].Value.ToString(), "R&D Project"); - Assert.AreEqual(ws.Cells["A2"].Value.ToString(), "Labwerks"); - Assert.AreEqual(ws.Cells["A3"].Value.ToString(), "R&D Single Order"); - - p.Workbook.CalcMode = ExcelCalcMode.Manual; - - SaveWorkbook("s1063-saved.xlsx", p); - } - } - - [TestMethod] public void s1054() { diff --git a/src/EPPlusTest/Issues/WorksheetIssues.cs b/src/EPPlusTest/Issues/WorksheetIssues.cs index c77764083..a500392eb 100644 --- a/src/EPPlusTest/Issues/WorksheetIssues.cs +++ b/src/EPPlusTest/Issues/WorksheetIssues.cs @@ -1193,6 +1193,16 @@ public void Issue2325() }); Assert.IsTrue(ex.Message.Contains("Strict Open XML")); } + [TestMethod] + public void Issue2445() + { + using var package = new ExcelPackage(); + var worksheet = package.Workbook.Worksheets.Add("Table1"); + worksheet.Cells["2:5"].EntireRow.Group(); + worksheet.Cells["C:E"].EntireColumn.Group(); + Assert.AreEqual(true, worksheet.OutLineSummaryBelow); + Assert.AreEqual(true, worksheet.OutLineSummaryRight); + } } } From cfcac276cceb2fe6ae1500a17a03ac559636dff9 Mon Sep 17 00:00:00 2001 From: KarlKallman Date: Mon, 3 Aug 2026 09:21:44 +0200 Subject: [PATCH 2/2] Readded mistakenly deleted tests --- .../Issues/FormulaCalculationIssues.cs | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+) diff --git a/src/EPPlusTest/Issues/FormulaCalculationIssues.cs b/src/EPPlusTest/Issues/FormulaCalculationIssues.cs index 5405496ea..00d0a968a 100644 --- a/src/EPPlusTest/Issues/FormulaCalculationIssues.cs +++ b/src/EPPlusTest/Issues/FormulaCalculationIssues.cs @@ -1649,6 +1649,7 @@ public void s1048() SaveWorkbook("S1048-calculated.xlsx", p); } } + [TestMethod] public void s1050() { @@ -1667,6 +1668,63 @@ public void s1050() } } + [TestMethod] + public void s1063_Isolated() + { + using (var p = OpenPackage("Search3ArgsArrays.xlsx", true)) + { + var ws = p.Workbook.Worksheets.Add("args"); + + ws.Cells["A1:A3"].Formula = "\"I.am.a.Beautiful.Creature\" & ROW()"; + + ws.Cells["A1:A3"].Calculate(); + + ws.Cells["B1:B3"].Formula = "(ROW()-1)*2 + 1"; + ws.Cells["B1:B3"].Calculate(); + + ws.Cells["C1"].CreateArrayFormula("SEARCH(\".\",A1:A3,B1:B3+1)", true); + ws.Cells["C1"].Calculate(); + + var range = ws.Cells["C1:C3"]; + + var myValues = ws.Cells["C1:C3"].Value; + + List intValues = new List(); + + foreach(var cell in range) + { + intValues.Add(cell.GetValue()); + } + + Assert.AreEqual(2, intValues[0]); + Assert.AreEqual(5, intValues[1]); + Assert.AreEqual(7, intValues[2]); + + SaveAndCleanup(p); + } + } + + [TestMethod] + public void s1063() + { + using (var p = OpenTemplatePackage("issues\\s1063.xlsx")) + { + var ws = p.Workbook.Worksheets[0]; + + ws.ClearFormulaValues(); + ws.Calculate(); + + Assert.AreEqual(ws.Cells["A1"].Value.ToString(), "R&D Project"); + Assert.AreEqual(ws.Cells["A2"].Value.ToString(), "Labwerks"); + Assert.AreEqual(ws.Cells["A3"].Value.ToString(), "R&D Single Order"); + + p.Workbook.CalcMode = ExcelCalcMode.Manual; + + SaveWorkbook("s1063-saved.xlsx", p); + } + } + + [TestMethod] public void s1054() {