#3279 Perform argument search only when specified

wdolek · wdolek · commit 3c09a6a1b8e4 · 2021-01-06T14:47:32.000+01:00
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1130UseLambdaSyntax.cs b/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1130UseLambdaSyntax.cs
@@ -98,8 +98,10 @@ internal static ParameterListSyntax GetDelegateParameterList(ISymbol symbol, int
 
         internal static int FindArgumentIndex(SymbolInfo originalSymbolInfo, ArgumentSyntax argumentSyntax, BaseArgumentListSyntax argumentListSyntax)
         {
+            // if delegate is passed as named argument of method try to find its position by argument name
             if (originalSymbolInfo.Symbol.Kind == SymbolKind.Method
-                && originalSymbolInfo.Symbol is IMethodSymbol methodSymbol)
+                && originalSymbolInfo.Symbol is IMethodSymbol methodSymbol
+                && argumentSyntax.NameColon != null)
             {
                 var calledMethodParameters = methodSymbol.Parameters;
                 var argumentIdentifier = argumentSyntax.NameColon.Name.Identifier.ValueText;

Original file line number	Diff line number	Diff line change
`@@ -98,8 +98,10 @@ internal static ParameterListSyntax GetDelegateParameterList(ISymbol symbol, int`
`98`	`98`
`99`	`99`	`internal static int FindArgumentIndex(SymbolInfo originalSymbolInfo, ArgumentSyntax argumentSyntax, BaseArgumentListSyntax argumentListSyntax)`
`100`	`100`	`{`
	`101`	`+ // if delegate is passed as named argument of method try to find its position by argument name`
`101`	`102`	`if (originalSymbolInfo.Symbol.Kind == SymbolKind.Method`
`102`		`- && originalSymbolInfo.Symbol is IMethodSymbol methodSymbol)`
	`103`	`+ && originalSymbolInfo.Symbol is IMethodSymbol methodSymbol`
	`104`	`+ && argumentSyntax.NameColon != null)`
`103`	`105`	`{`
`104`	`106`	`var calledMethodParameters = methodSymbol.Parameters;`
`105`	`107`	`var argumentIdentifier = argumentSyntax.NameColon.Name.Identifier.ValueText;`