Remove unreachable code in analyzer and code fix

Author: sharwell

DocumentationAnalyzers/DocumentationAnalyzers.CodeFixes/StyleRules/DOC108CodeFixProvider.cs

@@ -5,6 +5,7 @@ namespace DocumentationAnalyzers.StyleRules
 {
     using System.Collections.Immutable;
     using System.Composition;
+    using System.Diagnostics;
     using System.Threading;
     using System.Threading.Tasks;
     using DocumentationAnalyzers.Helpers;
@@ -27,10 +28,7 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
         {
             foreach (var diagnostic in context.Diagnostics)
             {
-                if (!FixableDiagnosticIds.Contains(diagnostic.Id))
-                {
-                    continue;
-                }
+                Debug.Assert(FixableDiagnosticIds.Contains(diagnostic.Id), "Assertion failed: FixableDiagnosticIds.Contains(diagnostic.Id)");
 
                 context.RegisterCodeFix(
                     CodeAction.Create(
@@ -46,12 +44,7 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
         private static async Task<Document> GetTransformedDocumentAsync(Document document, Diagnostic diagnostic, CancellationToken cancellationToken)
         {
             SyntaxNode root = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);
-            var xmlEmptyElement = root.FindNode(diagnostic.Location.SourceSpan, findInsideTrivia: true, getInnermostNodeForTie: true) as XmlEmptyElementSyntax;
-            if (xmlEmptyElement is null)
-            {
-                return document;
-            }
-
+            var xmlEmptyElement = (XmlEmptyElementSyntax)root.FindNode(diagnostic.Location.SourceSpan, findInsideTrivia: true, getInnermostNodeForTie: true);
             return document.WithSyntaxRoot(root.RemoveNode(xmlEmptyElement, SyntaxRemoveOptions.KeepExteriorTrivia));
         }
     }

DocumentationAnalyzers/DocumentationAnalyzers/StyleRules/DOC108AvoidEmptyParagraphs.cs

@@ -44,7 +44,7 @@ private static void HandleXmlEmptyElementSyntax(SyntaxNodeAnalysisContext contex
         {
             var xmlEmptyElement = (XmlEmptyElementSyntax)context.Node;
             var name = xmlEmptyElement.Name;
-            if (name is null || name.Prefix != null)
+            if (name.Prefix != null)
             {
                 return;
             }