Merge pull request #43 from sharwell/property-markdown

Fix invalid cast converting Markdown code blocks

Author: sharwell

DocumentationAnalyzers/DocumentationAnalyzers.Test/RefactoringRules/DOC900UnitTests.cs

@@ -225,6 +225,30 @@ void Method<T2>() { }
             await VerifyCodeFixAsync(testCode, fixedCode);
         }
 
+        [Fact]
+        [WorkItem(42, "https://github.com/DotNetAnalyzers/DocumentationAnalyzers/issues/42")]
+        public async Task TestPropertyDocumentationWithCodeBlockAsync()
+        {
+            var testCode = @"
+class TestClass {
+    ///$$ <summary>
+    /// Provide a `value`.
+    /// </summary>
+    int Property => 3;
+}
+";
+            var fixedCode = @"
+class TestClass {
+    ///$$ <summary>
+    /// Provide a <c>value</c>.
+    /// </summary>
+    int Property => 3;
+}
+";
+
+            await VerifyCodeFixAsync(testCode, fixedCode);
+        }
+
         private static async Task VerifyCodeFixAsync(string testCode, string fixedCode)
         {
             int iterations;

DocumentationAnalyzers/DocumentationAnalyzers/Helpers/SymbolExtensions.cs

@@ -19,9 +19,8 @@ internal static class SymbolExtensions
         /// context of the specified <paramref name="symbol"/>; otherwise, <see langword="false"/>.</returns>
         public static bool HasAnyParameter(this ISymbol symbol, string name, StringComparer comparer)
         {
-            if (symbol.Kind == SymbolKind.Method)
+            if (symbol is IMethodSymbol methodSymbol)
             {
-                var methodSymbol = (IMethodSymbol)symbol;
                 return methodSymbol.Parameters.Any(parameter => comparer.Equals(parameter.Name, name));
             }
 
@@ -40,18 +39,18 @@ public static bool HasAnyTypeParameter(this ISymbol symbol, string name, StringC
         {
             for (var currentSymbol = symbol; currentSymbol != null; currentSymbol = currentSymbol.ContainingSymbol)
             {
-                switch (currentSymbol.Kind)
+                switch (currentSymbol)
                 {
-                case SymbolKind.NamedType:
-                    if (((INamedTypeSymbol)symbol).TypeParameters.Any(parameter => comparer.Equals(parameter.Name, name)))
+                case INamedTypeSymbol namedType:
+                    if (namedType.TypeParameters.Any(parameter => comparer.Equals(parameter.Name, name)))
                     {
                         return true;
                     }
 
                     break;
 
-                case SymbolKind.Method:
-                    if (((IMethodSymbol)symbol).TypeParameters.Any(parameter => comparer.Equals(parameter.Name, name)))
+                case IMethodSymbol method:
+                    if (method.TypeParameters.Any(parameter => comparer.Equals(parameter.Name, name)))
                     {
                         return true;
                     }