Skip to content

Commit 48061d8

Browse files
committed
Remove the 'Has Implementation' column
1 parent 65a03a5 commit 48061d8

3 files changed

Lines changed: 0 additions & 38 deletions

File tree

DocumentationAnalyzers/DocumentationAnalyzers.Status.Generator/DocumentationDiagnostic.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,6 @@ public class DocumentationDiagnostic
2727
/// </value>
2828
public string Name { get; set; }
2929

30-
/// <summary>
31-
/// Gets or sets a value indicating whether the diagnostic is implemented.
32-
/// </summary>
33-
/// <value>
34-
/// <see langword="true"/> if the diagnostic is implemented; otherwise <see langword="false"/>.
35-
/// </value>
36-
public bool HasImplementation { get; set; }
37-
3830
/// <summary>
3931
/// Gets or sets a value indicating whether the diagnostic is enabled. This can indicate if the
4032
/// diagnostic is enabled by default, and if not, whether it is disabled because

DocumentationAnalyzers/DocumentationAnalyzers.Status.Generator/SolutionReader.cs

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,6 @@ public async Task<ImmutableList<DocumentationDiagnostic>> GetDiagnosticsAsync()
123123
continue;
124124
}
125125

126-
bool hasImplementation = HasImplementation(syntaxRoot);
127-
128126
IEnumerable<DiagnosticDescriptor> descriptorInfos = GetDescriptor(classSymbol);
129127

130128
foreach (var descriptorInfo in descriptorInfos)
@@ -140,7 +138,6 @@ public async Task<ImmutableList<DocumentationDiagnostic>> GetDiagnosticsAsync()
140138
{
141139
Id = descriptorInfo.Id,
142140
Category = descriptorInfo.Category,
143-
HasImplementation = hasImplementation,
144141
Status = status,
145142
Name = shortName,
146143
Title = descriptorInfo.Title.ToString(),
@@ -156,23 +153,6 @@ public async Task<ImmutableList<DocumentationDiagnostic>> GetDiagnosticsAsync()
156153
return diagnostics.ToImmutable();
157154
}
158155

159-
private static bool HasImplementation(SyntaxNode syntaxRoot)
160-
{
161-
bool hasImplementation = true;
162-
foreach (var trivia in syntaxRoot.DescendantTrivia())
163-
{
164-
if (trivia.IsKind(SyntaxKind.SingleLineCommentTrivia))
165-
{
166-
if (trivia.ToFullString().Contains("TODO: Implement analysis"))
167-
{
168-
hasImplementation = false;
169-
}
170-
}
171-
}
172-
173-
return hasImplementation;
174-
}
175-
176156
private async Task InitializeAsync()
177157
{
178158
_solution = await _workspace.OpenSolutionAsync(SlnPath).ConfigureAwait(false);

docs/index.html

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,6 @@ <h2>This page is reporting the current status of <a href="https://github.com/Dot
6969
<td>
7070
Title
7171
</td>
72-
<td>
73-
Has Implementation
74-
</td>
7572
<td>
7673
Status
7774
</td>
@@ -91,15 +88,11 @@ <h2>This page is reporting the current status of <a href="https://github.com/Dot
9188
</div>
9289

9390
<script id="diagnostic-color" type="text/x-jsrender">
94-
{{if HasImplementation}}
9591
{{if Status !== "DisabledNoTests"}}
9692
success
9793
{{else}}
9894
warning
9995
{{/if}}
100-
{{else }}
101-
danger
102-
{{/if}}
10396
</script>
10497

10598
<script id="diagnostic" type="text/x-jsrender">
@@ -113,9 +106,6 @@ <h2>This page is reporting the current status of <a href="https://github.com/Dot
113106
<td>
114107
{{>Title}}
115108
</td>
116-
<td>
117-
{{>HasImplementation}}
118-
</td>
119109
<td>
120110
{{>Status}}
121111
</td>

0 commit comments

Comments
 (0)