Simplify destructor checks

Author: lucic71

cpp2rust/converter/converter.cpp

@@ -678,7 +678,7 @@ bool Converter::RecordDerivesCopy(const clang::RecordDecl *decl) const {
 
 bool Converter::RecordHasCopyableFields(const clang::RecordDecl *decl) {
   if (auto *cxx = clang::dyn_cast<clang::CXXRecordDecl>(decl);
-      cxx && RecordNeedsDestruction(cxx)) {
+      cxx && !cxx->hasTrivialDestructor()) {
     return false;
   }
   for (auto f : decl->fields()) {

cpp2rust/converter/converter_lib.cpp

@@ -589,39 +589,15 @@ const char *GetOverloadedOperator(const clang::FunctionDecl *decl) {
 
 clang::CXXDestructorDecl *
 GetTranslatableDestructor(const clang::CXXRecordDecl *decl) {
-  if (!decl->hasDefinition() || !IsUserDefinedDecl(decl) ||
-      !decl->hasUserDeclaredDestructor()) {
+  if (!IsUserDefinedDecl(decl)) {
     return nullptr;
   }
   auto *dtor = decl->getDestructor();
-  if (!dtor || dtor->isImplicit() || !dtor->getDefinition() ||
-      dtor->getDefinition()->isDefaulted()) {
+  if (!dtor || dtor->isImplicit()) {
     return nullptr;
   }
-  return dtor;
-}
-
-bool TypeNeedsDestruction(clang::QualType type) {
-  if (type->isArrayType()) {
-    type = clang::QualType(type->getBaseElementTypeUnsafe(), 0);
-  }
-  auto *record = type->getAsCXXRecordDecl();
-  return record && RecordNeedsDestruction(record);
-}
-
-bool RecordNeedsDestruction(const clang::CXXRecordDecl *decl) {
-  if (!decl->hasDefinition() || !IsUserDefinedDecl(decl)) {
-    return false;
-  }
-  if (GetTranslatableDestructor(decl)) {
-    return true;
-  }
-  for (const auto *field : decl->fields()) {
-    if (TypeNeedsDestruction(field->getType())) {
-      return true;
-    }
-  }
-  return false;
+  auto *definition = dtor->getDefinition();
+  return definition && !definition->isDefaulted() ? dtor : nullptr;
 }
 
 bool IsOverloadedComparisonOperator(const clang::CXXMethodDecl *decl) {

cpp2rust/converter/converter_lib.h

@@ -122,10 +122,6 @@ bool IsOverloadedComparisonOperator(const clang::CXXMethodDecl *decl);
 clang::CXXDestructorDecl *
 GetTranslatableDestructor(const clang::CXXRecordDecl *decl);
 
-bool TypeNeedsDestruction(clang::QualType type);
-
-bool RecordNeedsDestruction(const clang::CXXRecordDecl *decl);
-
 clang::Expr *ToAddrOf(clang::ASTContext &ctx, clang::Expr *expr);
 
 std::vector<clang::CXXRecordDecl *>