Fix unset computed_expr_type for default arg and init list

Author: lucic71

cpp2rust/converter/converter.cpp

@@ -3604,7 +3604,8 @@ bool Converter::VisitInitListExpr(clang::InitListExpr *expr) {
 bool Converter::VisitCompoundLiteralExpr(clang::CompoundLiteralExpr *expr) {
   auto record = expr->getType()->getAsRecordDecl();
   if (!record || !record->hasAttr<clang::TransparentUnionAttr>()) {
-    return true;
+    Convert(expr->getInitializer());
+    return false;
   }
   auto init = clang::cast<clang::InitListExpr>(expr->getInitializer());
   assert(init->getNumInits() == 1);
@@ -3958,7 +3959,9 @@ bool Converter::VisitCXXDefaultArgExpr(clang::CXXDefaultArgExpr *expr) {
   if (expr->getType()->isPointerType()) {
     StrCat(token::kDefault);
     computed_expr_type_ = ComputedExprType::FreshPointer;
+    return false;
   }
+  Convert(expr->getExpr());
   return false;
 }
 

tests/unit/default_function_arguments.cpp

@@ -21,6 +21,10 @@ Bar global_bar(9);
 
 int by_global_ref(const Bar &b = global_bar) { return b.v; }
 
+template <typename T> int shifted(T x, int y = -1) { return x + y; }
+
+template <typename R> int first(R &&r) { return r[0]; }
+
 template <typename T> struct Holder {
   T v;
   explicit Holder(T v = 0) : v(v) {}
@@ -55,5 +59,9 @@ int main() {
   Holder<int> h(4);
   assert(h.v == 4);
 
+  assert(shifted(3) == 2);
+  assert(shifted(3, 4) == 7);
+  assert(first((int[]){4, 5, 6}) == 4);
+
   return 0;
 }