Memset(0) tv fields instead of explicit 0

explicit 0 creates a diff between macos and linux because on macos the
type of tv_usec is different.

Author: lucic71

libcc2rs/src/libc_shims/time.rs

@@ -89,7 +89,23 @@ impl Clone for Timeval {
     }
 }
 
-impl ByteRepr for Timeval {}
+impl ByteRepr for Timeval {
+    fn byte_size() -> usize {
+        16
+    }
+
+    fn to_bytes(&self, buf: &mut [u8]) {
+        (*self.tv_sec.borrow()).to_bytes(&mut buf[0..8]);
+        (*self.tv_usec.borrow()).to_bytes(&mut buf[8..16]);
+    }
+
+    fn from_bytes(buf: &[u8]) -> Self {
+        Self {
+            tv_sec: Rc::new(RefCell::new(i64::from_bytes(&buf[0..8]))),
+            tv_usec: Rc::new(RefCell::new(i64::from_bytes(&buf[8..16]))),
+        }
+    }
+}
 
 #[derive(Default)]
 pub struct Timespec {

tests/unit/out/refcount/select.rs

@@ -32,8 +32,15 @@ fn main_0() -> i32 {
     (rset.as_pointer()).with_mut(|__s| __s.zero());
     (rset.as_pointer()).with_mut(|__s| __s.set((*fds.borrow())[(0) as usize]));
     let tv: Value<libcc2rs::Timeval> = Rc::new(RefCell::new(Default::default()));
+    {
+        ((tv.as_pointer()) as Ptr<libcc2rs::Timeval>)
+            .to_any()
+            .memset((0) as u8, 16usize as usize);
+        ((tv.as_pointer()) as Ptr<libcc2rs::Timeval>)
+            .to_any()
+            .clone()
+    };
     (*(*tv.borrow()).tv_sec.borrow_mut()) = 0_i64;
-    (*(*tv.borrow()).tv_usec.borrow_mut()) = 0_i64;
     assert!(
         ((({
             let __rp = (rset.as_pointer()).clone();
@@ -183,7 +190,6 @@ fn main_0() -> i32 {
     (rset.as_pointer()).with_mut(|__s| __s.zero());
     (rset.as_pointer()).with_mut(|__s| __s.set((*fds.borrow())[(0) as usize]));
     (*(*tv.borrow()).tv_sec.borrow_mut()) = 1_i64;
-    (*(*tv.borrow()).tv_usec.borrow_mut()) = 0_i64;
     assert!(
         ((({
             let __rp = (rset.as_pointer()).clone();

tests/unit/out/unsafe/select.rs

@@ -18,8 +18,15 @@ unsafe fn main_0() -> i32 {
     libc::FD_ZERO((&mut rset as *mut ::libc::fd_set));
     libc::FD_SET(fds[(0) as usize], (&mut rset as *mut ::libc::fd_set));
     let mut tv: ::libc::timeval = unsafe { std::mem::zeroed() };
+    {
+        let byte_0 = ((&mut tv as *mut ::libc::timeval) as *mut ::libc::timeval
+            as *mut ::libc::c_void) as *mut u8;
+        for offset in 0..::std::mem::size_of::<::libc::timeval>() {
+            *byte_0.offset(offset as isize) = 0 as u8;
+        }
+        ((&mut tv as *mut ::libc::timeval) as *mut ::libc::timeval as *mut ::libc::c_void)
+    };
     tv.tv_sec = 0_i64;
-    tv.tv_usec = 0_i64;
     assert!(
         ((((libc::select(
             ((fds[(0) as usize]) + (1)),
@@ -49,7 +56,6 @@ unsafe fn main_0() -> i32 {
     libc::FD_ZERO((&mut rset as *mut ::libc::fd_set));
     libc::FD_SET(fds[(0) as usize], (&mut rset as *mut ::libc::fd_set));
     tv.tv_sec = 1_i64;
-    tv.tv_usec = 0_i64;
     assert!(
         ((((libc::select(
             ((fds[(0) as usize]) + (1)),

tests/unit/select.c

@@ -1,4 +1,5 @@
 #include <assert.h>
+#include <string.h>
 #include <sys/select.h>
 #include <unistd.h>
 
@@ -9,15 +10,14 @@ int main(void) {
   FD_ZERO(&rset);
   FD_SET(fds[0], &rset);
   struct timeval tv;
+  memset(&tv, 0, sizeof(tv));
   tv.tv_sec = 0;
-  tv.tv_usec = 0;
   assert(select(fds[0] + 1, &rset, NULL, NULL, &tv) == 0);
   assert(!FD_ISSET(fds[0], &rset));
   assert(write(fds[1], "x", 1) == 1);
   FD_ZERO(&rset);
   FD_SET(fds[0], &rset);
   tv.tv_sec = 1;
-  tv.tv_usec = 0;
   assert(select(fds[0] + 1, &rset, NULL, NULL, &tv) == 1);
   assert(FD_ISSET(fds[0], &rset));
   assert(close(fds[0]) == 0);