Pin ruff version and fix sporadic double unlink in tests (#287)

ruff got suddenly updated and our python linting broke. Pin ruff to a
fixed version so linting is stable.

Author: lucic71

.github/workflows/format.yml

@@ -26,7 +26,7 @@ jobs:
           llvm-version: 22
 
       - name: Setup Python
-        run: pip install ruff
+        run: pip install ruff==0.15.22
 
       - name: Configure
         run: cmake -GNinja -B build -S .

README.md

@@ -37,7 +37,7 @@ On Ubuntu, install the required dependencies with:
 
 ```bash
 sudo apt install libclang-22-dev clang++-22 ninja-build cmake
-curl -LsSf https://astral.sh/ruff/install.sh | sh
+pip install ruff==0.15.22
 ```
 
 

tests/lit/lit/formats/Cpp2RustTest.py

@@ -261,14 +261,18 @@ def build_rust(self):
     def run_cpp(self):
         if self.skip_run:
             return None
-        self.cpp_result = RunResult(*lit.util.executeCommand(str(self.cpp_bin)))
+        self.cpp_result = RunResult(
+            *lit.util.executeCommand(str(self.cpp_bin), str(self.tmp_dir))
+        )
         return None
 
     def run_rust(self):
         exp = self.expectations
         if self.skip_run:
             return None
-        self.rust_result = RunResult(*lit.util.executeCommand(str(self.rust_bin)))
+        self.rust_result = RunResult(
+            *lit.util.executeCommand(str(self.rust_bin), str(self.tmp_dir))
+        )
 
         if exp.should_panic_ub:
             err = str(self.rust_result.stderr)

tests/unit/fd_io.c

@@ -4,7 +4,7 @@
 #include <unistd.h>
 
 int main(void) {
-  const char *path = "/tmp/cpp2rust_fd_io_test.tmp";
+  const char *path = "cpp2rust_fd_io_test.tmp";
   int fd = open(path, O_WRONLY | O_CREAT | O_TRUNC, 0644);
   assert(fd >= 0);
   assert(write(fd, "hello world", 11) == 11);

tests/unit/fstat.c

@@ -4,7 +4,7 @@
 #include <unistd.h>
 
 int main(void) {
-  const char *path = "/tmp/cpp2rust_fstat_test.tmp";
+  const char *path = "cpp2rust_fstat_test.tmp";
   int fd = open(path, O_RDWR | O_CREAT | O_TRUNC, 0644);
   assert(fd >= 0);
   assert(write(fd, "hello", 5) == 5);

tests/unit/isatty.c

@@ -3,7 +3,7 @@
 #include <unistd.h>
 
 int main(void) {
-  const char *path = "/tmp/cpp2rust_isatty_test.tmp";
+  const char *path = "cpp2rust_isatty_test.tmp";
   int fd = open(path, O_RDWR | O_CREAT | O_TRUNC, 0644);
   assert(fd >= 0);
   assert(isatty(fd) == 0);

tests/unit/lseek_ftruncate.c

@@ -4,7 +4,7 @@
 #include <unistd.h>
 
 int main(void) {
-  const char *path = "/tmp/cpp2rust_lseek_ftruncate_test.tmp";
+  const char *path = "cpp2rust_lseek_ftruncate_test.tmp";
   int fd = open(path, O_RDWR | O_CREAT | O_TRUNC, 0644);
   assert(fd >= 0);
   assert(write(fd, "hello world", 11) == 11);

tests/unit/out/refcount/fd_io.rs

@@ -11,7 +11,7 @@ pub fn main() {
 }
 fn main_0() -> i32 {
     let path: Value<Ptr<u8>> = Rc::new(RefCell::new(Ptr::from_string_literal(
-        b"/tmp/cpp2rust_fd_io_test.tmp",
+        b"cpp2rust_fd_io_test.tmp",
     )));
     let fd: Value<i32> = Rc::new(RefCell::new({
         let __mode = match &[(420).into()].first() {

tests/unit/out/refcount/fstat.rs

@@ -11,7 +11,7 @@ pub fn main() {
 }
 fn main_0() -> i32 {
     let path: Value<Ptr<u8>> = Rc::new(RefCell::new(Ptr::from_string_literal(
-        b"/tmp/cpp2rust_fstat_test.tmp",
+        b"cpp2rust_fstat_test.tmp",
     )));
     let fd: Value<i32> = Rc::new(RefCell::new({
         let __mode = match &[(420).into()].first() {

tests/unit/out/refcount/isatty.rs

@@ -11,7 +11,7 @@ pub fn main() {
 }
 fn main_0() -> i32 {
     let path: Value<Ptr<u8>> = Rc::new(RefCell::new(Ptr::from_string_literal(
-        b"/tmp/cpp2rust_isatty_test.tmp",
+        b"cpp2rust_isatty_test.tmp",
     )));
     let fd: Value<i32> = Rc::new(RefCell::new({
         let __mode = match &[(420).into()].first() {