remove some string copies

Author: nunoplopes

cpp2rust/converter/converter_lib.cpp

@@ -1193,14 +1193,12 @@ void Unwrap(std::string &s, std::string_view prefix, std::string_view suffix) {
   }
 }
 
-std::string ReplaceAll(std::string str, std::string_view from,
-                       std::string_view to) {
+void ReplaceAll(std::string &str, std::string_view from, std::string_view to) {
   size_t pos = 0;
   while ((pos = str.find(from, pos)) != std::string::npos) {
     str.replace(pos, from.size(), to);
     pos += to.size();
   }
-  return str;
 }
 
 ConstCastType GetConstCastType(clang::QualType to, clang::QualType from) {

cpp2rust/converter/converter_lib.h

@@ -230,8 +230,7 @@ std::string_view Trim(std::string_view s);
 
 void Unwrap(std::string &s, std::string_view prefix, std::string_view suffix);
 
-std::string ReplaceAll(std::string str, std::string_view from,
-                       std::string_view to);
+void ReplaceAll(std::string &str, std::string_view from, std::string_view to);
 
 enum class ConstCastType {
   ConstToConst,

cpp2rust/converter/mapper.cpp

@@ -619,7 +619,7 @@ std::string mapTypeStringRecursive(const std::string &cpp_type) {
 std::string normalizeTranslationRule(std::string rule) {
   // Detach pointer from double reference. Useful for matching translation
   // rules.
-  rule = ReplaceAll(rule, "*&&", "* &&");
+  ReplaceAll(rule, "*&&", "* &&");
 
   const std::array<std::pair<std::regex, std::string>, 1> normalization_rules{{
       // Ignore constant template parameters, i.e. replace them with _.
@@ -832,7 +832,8 @@ std::string ToRustName(std::string name) {
     name[pos] = '_';
     ++pos;
   }
-  return ReplaceAll(name, "::", "_");
+  ReplaceAll(name, "::", "_");
+  return name;
 }
 
 std::string ToString(clang::QualType qual_type, ScalarSugar sugar) {

cpp2rust/converter/plugins/emplace_back.cpp

@@ -137,7 +137,9 @@ clang::CXXConstructExpr *buildConstructExpr(clang::CXXMemberCallExpr *call,
 void Converter::emplace_back_emit_push_open(clang::CXXMemberCallExpr *call) {
   {
     PushExprKind push(*this, ExprKind::LValue);
-    StrCat(ReplaceAll(ToString(call->getCallee()), "emplace_back", "push"));
+    auto callee = ToString(call->getCallee());
+    ReplaceAll(callee, "emplace_back", "push");
+    StrCat(callee);
   }
   StrCat('(');
 }