Remove unnecessary pub on tmp variables

Author: joaotgouveia

cpp2rust/converter/converter.cpp

@@ -237,7 +237,7 @@ Converter::MaterializeTemp(const std::string &binding_name,
   auto pointee = param_type.getNonReferenceType();
   auto value = ConvertRValue(expr, pointee);
   auto type_str = ToStringBase(pointee);
-  const char *decl = in_const_initializer_ ? "pub static" : keyword::kLet;
+  const auto *decl = in_const_initializer_ ? keyword::kStatic : keyword::kLet;
 
   auto binding =
       std::format("{} mut {} : {} = {};", decl, binding_name, type_str, value);

cpp2rust/converter/models/converter_refcount.cpp

@@ -368,7 +368,7 @@ ConverterRefCount::MaterializeTemp(const std::string &binding_name,
   auto pointee = param_type.getNonReferenceType();
   auto value = ConvertRValue(expr, pointee);
   auto type_str = ToStringBase(pointee);
-  const char *decl = in_const_initializer_ ? "pub static" : keyword::kLet;
+  const auto *decl = in_const_initializer_ ? keyword::kStatic : keyword::kLet;
 
   auto binding = std::format("{} {} : Value<{}> = Rc::new(RefCell::new({}));",
                              decl, binding_name, type_str, value);

tests/unit/out/refcount/rvalue_ref_global.rs

@@ -7,7 +7,7 @@ use std::io::{Read, Seek, Write};
 use std::os::fd::AsFd;
 use std::rc::{Rc, Weak};
 thread_local!(
-    pub static __tmp_0: Value<i32> = Rc::new(RefCell::new(5));
+    static __tmp_0: Value<i32> = Rc::new(RefCell::new(5));
     pub static g_0: Ptr<i32> = __tmp_0.with(Value::as_pointer);
 );
 pub fn main() {

tests/unit/out/unsafe/rvalue_ref_global.rs

@@ -6,7 +6,7 @@ use std::collections::BTreeMap;
 use std::io::{Read, Seek, Write};
 use std::os::fd::{AsFd, FromRawFd, IntoRawFd};
 use std::rc::Rc;
-pub static mut __tmp_0: i32 = 5;
+static mut __tmp_0: i32 = 5;
 pub static mut g_0: *mut i32 = unsafe { &mut __tmp_0 };
 pub fn main() {
     unsafe {