Skip to content

Security: ai_model_url was not redacted in non-admin settings response (C-W3-5 gap) #671

Description

@rubenvdlinde

Summary

The wave-3 security fix (commit da0be238) for C-W3-5 (AiService SSRF) added ai_api_key and appointment_backend_api_key to SECRET_KEYS in SettingsService, but missed adding ai_model_url.

This meant that GET /api/settings (which is @NoAdminRequired) returned the admin-configured AI model URL (e.g. http://ollama:11434 or a cloud LLM endpoint) to every authenticated Nextcloud user — revealing internal infrastructure topology.

Fix

ai_model_url was added to SECRET_KEYS in commit 65f80614 (wave-9 follow-up, pushed to development 2026-05-28).

Scope

  • File: lib/Service/SettingsService.phpSECRET_KEYS constant
  • Effect: non-admin callers of GET /api/settings now receive "ai_model_url": "***" instead of the real URL

Tracked as C-W3-5 gap — the core SSRF guard on AiService::callAiModel (preventing actual exploitation) was shipped in wave-3; this closes the information-disclosure residual.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions