From 6af9a57f60531024566ff4174d12b38eb3547943 Mon Sep 17 00:00:00 2001 From: Daniel Gergely Date: Fri, 30 Oct 2026 07:14:58 +0100 Subject: [PATCH 1/4] [T3417] FIX: thank-you crashes when a third party letter is pending --- thankyou_letters/models/account_move_line.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/thankyou_letters/models/account_move_line.py b/thankyou_letters/models/account_move_line.py index 897675b07..384a91ed8 100644 --- a/thankyou_letters/models/account_move_line.py +++ b/thankyou_letters/models/account_move_line.py @@ -85,7 +85,14 @@ def generate_thank_you(self): all_thanks_config_ids = ( self.env["partner.communication.config"] - .search([("send_mode_pref_field", "like", "thankyou_preference")]) + .search( + [ + ("send_mode_pref_field", "like", "thankyou_preference"), + # Other configs (e.g. third party letters on res.partner) + # share the preference field but not the model. + ("model_id.model", "=", self._name), + ] + ) .ids ) From 6cfb999cd88ad2fc530efb41811dda9a0216bb50 Mon Sep 17 00:00:00 2001 From: Daniel Gergely Date: Fri, 30 Oct 2026 12:10:30 +0100 Subject: [PATCH 2/4] [T3417] FIX: Christmas letters released for suspended projects --- sbc_compassion/models/correspondence.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sbc_compassion/models/correspondence.py b/sbc_compassion/models/correspondence.py index d75edf53a..dd5a6498b 100644 --- a/sbc_compassion/models/correspondence.py +++ b/sbc_compassion/models/correspondence.py @@ -1346,6 +1346,8 @@ def check_postponed_christmas_letters(self): ("kit_identifier", "=", False), ("state", "=", "Exception"), ("on_hold", "=", True), + # Released with the project reactivation instead + ("child_id.project_id.hold_s2b_letters", "!=", True), ] ) correspondences.reactivate_letters(_("Christmas period started")) From 2ce1cf6edef68e93f0400b8ee1876aaff60d459d Mon Sep 17 00:00:00 2001 From: Daniel Gergely Date: Fri, 30 Oct 2026 07:14:58 +0100 Subject: [PATCH 3/4] [T3417] FIX: thank-you crashes when a third party letter is pending --- thankyou_letters/models/account_move_line.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/thankyou_letters/models/account_move_line.py b/thankyou_letters/models/account_move_line.py index 8cb1bc28d..08794182a 100644 --- a/thankyou_letters/models/account_move_line.py +++ b/thankyou_letters/models/account_move_line.py @@ -102,7 +102,14 @@ def generate_thank_you(self): all_thanks_config_ids = ( self.env["partner.communication.config"] - .search([("send_mode_pref_field", "like", "thankyou_preference")]) + .search( + [ + ("send_mode_pref_field", "like", "thankyou_preference"), + # Other configs (e.g. third party letters on res.partner) + # share the preference field but not the model. + ("model_id.model", "=", self._name), + ] + ) .ids ) From 4b87d7d83b2fd6f591c8603d87d5b3fb04d52ab0 Mon Sep 17 00:00:00 2001 From: Daniel Gergely Date: Fri, 30 Oct 2026 12:10:30 +0100 Subject: [PATCH 4/4] [T3417] FIX: Christmas letters released for suspended projects --- sbc_compassion/models/correspondence.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sbc_compassion/models/correspondence.py b/sbc_compassion/models/correspondence.py index 8744cd3bc..aa17059c7 100644 --- a/sbc_compassion/models/correspondence.py +++ b/sbc_compassion/models/correspondence.py @@ -1364,6 +1364,8 @@ def check_postponed_christmas_letters(self): ("kit_identifier", "=", False), ("state", "=", "Exception"), ("on_hold", "=", True), + # Released with the project reactivation instead + ("child_id.project_id.hold_s2b_letters", "!=", True), ] ) correspondences.reactivate_letters(_("Christmas period started"))