diff --git a/docs/callers/review-readiness-shadow.md b/docs/callers/review-readiness-shadow.md index 3374d564..7912d58d 100644 --- a/docs/callers/review-readiness-shadow.md +++ b/docs/callers/review-readiness-shadow.md @@ -15,7 +15,8 @@ in the caller's `uses:`. The provider tools load at the workflow's own revision, never from the PR. This workflow runs only when explicitly called. The report records the supplied `tested_sha` but cannot prove that tests actually -ran on it. It does not verify reviewer permissions or cover every finding source. +ran on it. It does not verify reviewer permissions or cover every finding source, so +review and finding evidence remains incomplete. Missing checks and incomplete findings prevent `READY`; known current failures can still produce `BLOCKED`. Data reads are not atomic, so a review change or an ABA revision change can race collection. It is not an authorization to merge or diff --git a/scripts/review-readiness/README.md b/scripts/review-readiness/README.md index 23d464b9..02a26444 100644 --- a/scripts/review-readiness/README.md +++ b/scripts/review-readiness/README.md @@ -74,8 +74,9 @@ partial, unavailable, or discarded. Only the latest submitted approval, dismissal, or change request per actor can count, and only when its review records the supplied head SHA. GitHub `User` and `Bot` identities are distinguished; unknown or malformed identities make review -collection unavailable. Comments and unsubmitted reviews do not replace a -submitted decision. Current unresolved, non-outdated review threads block even +collection unavailable. Review records are reported as incomplete even when the +list was read successfully, because the collector does not check reviewer +permissions. Comments and unsubmitted reviews do not replace a submitted decision. Current unresolved, non-outdated review threads block even if a later thread page fails. A partial thread read is not a complete inventory. The collector never marks the finding inventory complete: GitHub review threads diff --git a/scripts/review-readiness/collect_reviews.py b/scripts/review-readiness/collect_reviews.py index 4b751008..689e59d4 100644 --- a/scripts/review-readiness/collect_reviews.py +++ b/scripts/review-readiness/collect_reviews.py @@ -158,7 +158,7 @@ def collect(data, client): if matches(client.pull(), snapshot): status['snapshot'] = 'matched' try: - base['reviews'] = {'scope': scope, 'complete': True, 'proof': proof, + base['reviews'] = {'scope': scope, 'complete': False, 'proof': proof, 'approvals': approvals(client.list_reviews(), snapshot['head_sha'])} status['reviews'] = 'observed' except EvidenceError: diff --git a/scripts/review-readiness/tests/test_collect_reviews.py b/scripts/review-readiness/tests/test_collect_reviews.py index 5d18db9c..e5253bf7 100644 --- a/scripts/review-readiness/tests/test_collect_reviews.py +++ b/scripts/review-readiness/tests/test_collect_reviews.py @@ -52,10 +52,10 @@ def run(client): class CollectReviewsTests(unittest.TestCase): - def test_current_human_approval_is_collected_but_other_sources_remain_incomplete(self): + def test_current_human_approval_remains_incomplete_without_permission_check(self): result = run(FakeClient()) self.assertEqual(result['state'], 'WAITING') - self.assertNotIn('required human approvals incomplete', result['reasons']) + self.assertIn('required human approvals incomplete', result['reasons']) self.assertIn('finding evidence incomplete', result['reasons']) self.assertIn('check inventory incomplete', result['reasons']) @@ -148,7 +148,7 @@ def test_cli_uses_paginated_github_responses(self): result = json.loads(proc.stdout) self.assertEqual(result['state'], 'BLOCKED') self.assertIn('unresolved finding', result['reasons']) - self.assertNotIn('required human approvals incomplete', result['reasons']) + self.assertIn('required human approvals incomplete', result['reasons']) def test_unbounded_thread_pagination_is_marked_partial(self): class Endless(FakeClient):