diff --git a/.github/coderabbit-config/README.md b/.github/coderabbit-config/README.md index d991a2cb..b87ef115 100644 --- a/.github/coderabbit-config/README.md +++ b/.github/coderabbit-config/README.md @@ -28,7 +28,7 @@ a schema library calls "invalid": | Class | Severity | Because | |---|---|---| | YAML parse error | error | CodeRabbit cannot read the file at all. | -| `maxLength` violation | error | File-rejecting. The schema carries **14** per-field caps, 50 → 20,000 chars. | +| `maxLength` violation | error | File-rejecting. The schema carries **15** per-field caps, 50 → 20,000 chars. | | type / enum error | error | File-rejecting. | | unknown / additional property | **warning** | CodeRabbit *strips* an unrecognized key rather than rejecting the file. Reported wherever the schema object accepts only the names it lists — see below. | | config path that is not a regular file, or > 512 KiB | exit 2 | "I could not check" must never look like a pass. A path resolving outside the repo root (symlinks resolved) is refused the same way. | @@ -95,7 +95,7 @@ carried exactly that shape when this landed. ## Why file size is the wrong invariant The obvious cheap check — "fail if `.coderabbit.yaml` gets too big" — would gate -nothing. There is no whole-document size cap in the schema, only the 14 per-field +nothing. There is no whole-document size cap in the schema, only the 15 per-field ones, and size is uncorrelated with validity: the invalid config that started this was 2,198 bytes while a valid one next to it was 4,826. Across the org sweep there were **zero** `maxLength` violations and three misplaced-key repos, so a size check diff --git a/.github/coderabbit-config/schema.v2.json b/.github/coderabbit-config/schema.v2.json index 016f4e82..1a052589 100644 --- a/.github/coderabbit-config/schema.v2.json +++ b/.github/coderabbit-config/schema.v2.json @@ -234,7 +234,6 @@ }, "reviews": { "default": {}, - "description": "Settings related to reviews.", "type": "object", "properties": { "profile": { @@ -248,6 +247,11 @@ "description": "Automatically approve when CodeRabbit’s comments are resolved, the latest commit has been reviewed, and no pre-merge checks are failing. Note: In GitLab, all discussions must be resolved.", "type": "boolean" }, + "allow_author_approval": { + "default": true, + "description": "Allow Author Approval | Controls whether pull request authors can use `@coderabbitai approve` and `@coderabbitai resolve` on their own pull requests. When disabled, anyone other than the author can still use them, provided CodeRabbit can identify both the commenter and the author. The pull request’s branch configuration cannot re-enable this setting.", + "type": "boolean" + }, "high_level_summary": { "default": true, "description": "Generate a high-level summary of the changes in the PR description or walkthrough.", @@ -688,7 +692,7 @@ "properties": { "override_requested_reviewers_only": { "default": false, - "description": "Override Requested Reviewers Only | When enabled, only requested reviewers (and not the pull request author) can override/ignore failing pre-merge checks.", + "description": "Override Requested Reviewers Only | When enabled, the pull request author cannot override/ignore failing pre-merge checks. Eligible actors are individually requested reviewers and, on GitHub, members of requested reviewer teams or submitted reviewers whose author association is OWNER, MEMBER, or COLLABORATOR.", "type": "boolean" }, "docstrings": { @@ -820,7 +824,6 @@ }, "tools": { "default": {}, - "description": "Tools that provide additional context to code reviews.", "type": "object", "properties": { "ast-grep": { @@ -828,6 +831,11 @@ "default": {}, "type": "object", "properties": { + "enabled": { + "default": true, + "description": "Enable ast-grep | ast-grep is a code analysis tool that helps you to find patterns in your codebase using abstract syntax trees patterns. | v0.45.3", + "type": "boolean" + }, "rule_dirs": { "default": [], "description": "List of rules directories.", @@ -878,7 +886,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable Ruff | Ruff is a Python linter and code formatter. | Enable Ruff integration. | v0.16.4", + "description": "Enable Ruff | Ruff is a Python linter and code formatter. | Enable Ruff integration. | v0.16.7", "type": "boolean" }, "config_file": { @@ -973,7 +981,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable Biome | Biome is a fast formatter, linter, and analyzer for web projects. | Enable Biome integration. | v2.5.10", + "description": "Enable Biome | Biome is a fast formatter, linter, and analyzer for web projects. | Enable Biome integration. | v2.5.13", "type": "boolean" } } @@ -1013,7 +1021,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable PHPStan | PHPStan requires [config file](https://phpstan.org/config-reference#config-file) in your repository root. Please ensure that this file contains the `paths:` parameter. | v2.2.9", + "description": "Enable PHPStan | PHPStan requires [config file](https://phpstan.org/config-reference#config-file) in your repository root. Please ensure that this file contains the `paths:` parameter. | v2.2.14", "type": "boolean" }, "level": { @@ -1120,7 +1128,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable Checkov | Checkov is a static code analysis tool for infrastructure-as-code files. | v3.3.13", + "description": "Enable Checkov | Checkov is a static code analysis tool for infrastructure-as-code files. | v3.3.17", "type": "boolean" } } @@ -1229,7 +1237,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable RuboCop | RuboCop is a Ruby static code analyzer (a.k.a. linter ) and code formatter. | v1.90.0", + "description": "Enable RuboCop | RuboCop is a Ruby static code analyzer (a.k.a. linter ) and code formatter. | v1.91.0", "type": "boolean" } } @@ -1241,7 +1249,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable Buf | Buf offers linting for Protobuf files. | v1.72.0", + "description": "Enable Buf | Buf offers linting for Protobuf files. | v1.73.0", "type": "boolean" } } @@ -1277,7 +1285,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable zizmor | zizmor is a static security analyzer for GitHub Actions workflow files. | v1.29.0", + "description": "Enable zizmor | zizmor is a static security analyzer for GitHub Actions workflow files. | v1.30.1", "type": "boolean" } } @@ -1289,7 +1297,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable PMD | PMD is an extensible multilanguage static code analyzer. It’s mainly concerned with Java. | v7.26.0", + "description": "Enable PMD | PMD is an extensible multilanguage static code analyzer. It’s mainly concerned with Java. | v7.27.0", "type": "boolean" }, "config_file": { @@ -1329,7 +1337,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable Vale | Vale checks prose against repository-defined editorial style rules. It runs only when a supported root Vale configuration is present. | v3.18.0", + "description": "Enable Vale | Vale checks prose against repository-defined editorial style rules. It runs only when a supported root Vale configuration is present. | v3.21.0", "type": "boolean" } } @@ -1341,7 +1349,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable Verilator | Verilator lints Verilog and SystemVerilog for syntax, width, connectivity, and behavioral correctness issues. | v5.050", + "description": "Enable Verilator | Verilator lints Verilog and SystemVerilog for syntax, width, connectivity, and behavioral correctness issues. | v5.052", "type": "boolean" } } @@ -1353,7 +1361,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable OpenGrep | OpenGrep is a high-performance static code analysis engine for finding security vulnerabilities and bugs across 17+ languages. | v1.28.0", + "description": "Enable OpenGrep | OpenGrep is a high-performance static code analysis engine for finding security vulnerabilities and bugs across 17+ languages. | v1.30.0", "type": "boolean" } } @@ -1365,7 +1373,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable Semgrep | Semgrep is a static analysis tool designed to scan code for security vulnerabilities and code quality issues. | Enable Semgrep integration. | v1.174.0", + "description": "Enable Semgrep | Semgrep is a static analysis tool designed to scan code for security vulnerabilities and code quality issues. | Enable Semgrep integration. | v1.177.0", "type": "boolean" }, "config_file": { @@ -1381,7 +1389,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable CircleCI | CircleCI tool is a static checker for CircleCI config files. | v1.0.48692", + "description": "Enable CircleCI | CircleCI tool is a static checker for CircleCI config files. | v1.0.50462", "type": "boolean" } } @@ -1421,7 +1429,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable Squawk for Postgres migration linting | Detects unsafe schema changes that can cause downtime or blocking locks | v2.63.0", + "description": "Enable Squawk for Postgres migration linting | Detects unsafe schema changes that can cause downtime or blocking locks | v2.65.0", "type": "boolean" } } @@ -1457,7 +1465,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable Pylint | Pylint is a Python static code analysis tool. | v4.0.7", + "description": "Enable Pylint | Pylint is a Python static code analysis tool. | v4.0.8", "type": "boolean" } } @@ -1469,7 +1477,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable Oxlint | Oxlint is a JavaScript/TypeScript linter for OXC written in Rust. | v1.80.0", + "description": "Enable Oxlint | Oxlint is a JavaScript/TypeScript linter for OXC written in Rust. | v1.83.0", "type": "boolean" } } @@ -1481,7 +1489,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable Shopify Theme Check | A linter for Shopify themes that helps you follow Shopify theme & Liquid best practices | cli 4.7.0 | theme 3.58.2", + "description": "Enable Shopify Theme Check | A linter for Shopify themes that helps you follow Shopify theme & Liquid best practices | cli 4.8.0 | theme 3.58.2", "type": "boolean" } } @@ -1567,7 +1575,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable OSV Scanner | OSV Scanner is a tool for vulnerability package scanning | v2.5.1", + "description": "Enable OSV Scanner | OSV Scanner is a tool for vulnerability package scanning | v2.6.0", "type": "boolean" } } @@ -1579,7 +1587,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable oasdiff | oasdiff detects breaking changes between OpenAPI specifications. | v1.29.1", + "description": "Enable oasdiff | oasdiff detects breaking changes between OpenAPI specifications. | v1.32.1", "type": "boolean" } } @@ -1591,7 +1599,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable React Doctor | React Doctor scans React codebases for security, performance, correctness, and accessibility issues. | v0.9.12", + "description": "Enable React Doctor | React Doctor scans React codebases for security, performance, correctness, and accessibility issues. | v0.9.14", "type": "boolean" } } @@ -1615,7 +1623,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable Blinter | Blinter is a linter for Windows batch files that provides comprehensive static analysis to identify syntax errors, security vulnerabilities, performance issues, and style problems. | v1.1.17", + "description": "Enable Blinter | Blinter is a linter for Windows batch files that provides comprehensive static analysis to identify syntax errors, security vulnerabilities, performance issues, and style problems. | v1.1.27", "type": "boolean" } } @@ -1651,7 +1659,7 @@ "properties": { "enabled": { "default": true, - "description": "Enable SkillSpector | SkillSpector is a security scanner for AI agent skills. It detects vulnerabilities, malicious patterns, and security risks in SKILL.md manifests and MCP configurations. | v2.9.6", + "description": "Enable SkillSpector | SkillSpector is a security scanner for AI agent skills. It detects vulnerabilities, malicious patterns, and security risks in SKILL.md manifests and MCP configurations. | v2.11.2", "type": "boolean" } } @@ -1668,9 +1676,11 @@ } } } - } + }, + "description": "Tools that provide additional context to code reviews." } - } + }, + "description": "Settings related to reviews." }, "chat": { "default": {}, diff --git a/.github/coderabbit-config/tests/test_check_coderabbit_config.py b/.github/coderabbit-config/tests/test_check_coderabbit_config.py index 3a8fa31c..1532225f 100644 --- a/.github/coderabbit-config/tests/test_check_coderabbit_config.py +++ b/.github/coderabbit-config/tests/test_check_coderabbit_config.py @@ -1056,8 +1056,13 @@ def test_the_two_halves_partition_the_objects_that_declare_properties(self): else: omitted.append(node) # Not an arbitrary snapshot: this is the size of the gap being closed. + # `omitted` grows by one per object the upstream schema adds without an + # opener -- 103 at #179, 104 at #215, 105 once #250 vendored the `vale` + # tool. `explicit` holding at 5 is the load-bearing half: it says the + # refresh introduced no NEW opener keyword, so the walk still means what + # the docstring above claims. Bump these deliberately, never to go green. self.assertEqual(len(explicit), 5) - self.assertEqual(len(omitted), 104) + self.assertEqual(len(omitted), 105) def test_every_explicitly_open_object_uses_additional_properties(self): # The audit behind `_OPENER_KEYWORDS`: the schema uses one opener today, diff --git a/.github/coderabbit-config/tests/test_schema_drift.py b/.github/coderabbit-config/tests/test_schema_drift.py index cfa187aa..b0ccf5c4 100644 --- a/.github/coderabbit-config/tests/test_schema_drift.py +++ b/.github/coderabbit-config/tests/test_schema_drift.py @@ -210,7 +210,13 @@ def test_the_committed_schema_has_the_documented_cap_set(self): caps = schema_drift.length_caps(schema_drift.load(VENDORED, "vendored")) self.assertEqual(caps["tone_instructions"], 250) self.assertEqual(caps["reviews.path_instructions[].instructions"], 20000) - self.assertEqual(len(caps), 14) + # The two above are the caps the checker's own messages quote; this one + # arrived with #288's refresh and is pinned so the 15th cap is checked + # rather than merely counted. + self.assertEqual(caps["chat.integrations.jira.issue_template"], 3000) + # README.md documents this count and the 50 -> 20,000 span; both move together. + self.assertEqual(len(caps), 15) + self.assertEqual((min(caps.values()), max(caps.values())), (50, 20000)) if __name__ == "__main__":