You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 233fd2d
Browse filesBrowse the repository at this point in the historyBrowse files
fix(cursor-approve): approve-external refuses a PR labelled skip-cursor-review (#351)
* fix(cursor-approve): approve-external refuses a PR labelled skip-cursor-review
A caller whose workflow concurrency group is keyed on the label name cannot
cancel an in-flight decide when `skip-cursor-review` lands mid-axes: the veto
starts a run in a different slot, and decide runs under always(). So the
veto is now re-checked where the approval is posted.
approve-external reads `skip-cursor-review` from the live PR object it
already re-reads for head/base/needs-human-review, and treats it exactly like
needs-human-review: no APPROVE, this identity's own marked approvals
withdrawn, and a new `vetoed` outcome the decide card renders. The post-write
re-read withdraws an approval if the veto arrives during the POST. A PR
payload with no label list fails closed rather than reading as "no veto".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(cursor-approve): the skip-cursor-review veto outranks supersession and withdraws PR-wide
Review round on the approve-external veto:
- the veto is checked before head/base supersession (pre- and post-POST), so a
late decide on a vetoed PR no longer keeps an approval standing on the live head;
- a veto landing during the POST withdraws every own marked approval, not just
the one just posted;
- an unreadable post-POST label list withdraws under its own message and exits
red instead of claiming the veto label was applied;
- `live_labels_readable` rejects entries `has_label` would silently skip;
- the review POST response is validated for an id, as cmd_decide does;
- the live-vs-payload test now distinguishes the two sources in both directions.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
0 commit comments