From 49399149901b5cae44b8c680aa1fbdaa600c79c7 Mon Sep 17 00:00:00 2001 From: bymyself Date: Mon, 26 Oct 2026 20:51:39 +0000 Subject: [PATCH 1/2] test: verify DynamicGroup count replay is inert --- test/dynamic-group.test.ts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/test/dynamic-group.test.ts b/test/dynamic-group.test.ts index 704f38f..d00b567 100644 --- a/test/dynamic-group.test.ts +++ b/test/dynamic-group.test.ts @@ -300,6 +300,23 @@ describe("DynamicGroup catalog layout", () => { doc.destroy(); }); + it("replays a row count op as a byte-identical no-op", () => { + const doc = mint(cases.populated, catalog); + const shrink = edit("loras", 0); + expect(applyOps(doc, [shrink], catalog).outcomes[0]?.outcome).toBe("applied"); + const grow = edit("loras", 2, 2); + expect(applyOps(doc, [grow], catalog).outcomes[0]?.outcome).toBe("applied"); + const projected = project(doc, catalog).nodes[0]!.widgets_values; + + for (const op of [shrink, grow]) { + const before = Y.encodeStateAsUpdate(doc); + expect(applyOps(doc, [op], catalog).outcomes[0]?.outcome).toBe("no-op"); + expect(Y.encodeStateAsUpdate(doc)).toEqual(before); + } + expect(project(doc, catalog).nodes[0]!.widgets_values).toEqual(projected); + doc.destroy(); + }); + it("converges when the row count and a row value arrive in either order", () => { const seed = mint(cases.empty, catalog); const snapshot = Y.encodeStateAsUpdate(seed); From 04b0f6c9db1aeb70f59f6851d9cb0d21cb6c1d72 Mon Sep 17 00:00:00 2001 From: bymyself Date: Tue, 27 Oct 2026 04:28:13 +0000 Subject: [PATCH 2/2] test: replay DynamicGroup count ops in both arrival orders The reverse order drops the older shrink by LWW, so both orders must project the retained populated rows and replay byte-identically. Addresses the CodeRabbit both-orders finding on this PR. --- test/dynamic-group.test.ts | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/test/dynamic-group.test.ts b/test/dynamic-group.test.ts index d00b567..58a2244 100644 --- a/test/dynamic-group.test.ts +++ b/test/dynamic-group.test.ts @@ -300,21 +300,27 @@ describe("DynamicGroup catalog layout", () => { doc.destroy(); }); - it("replays a row count op as a byte-identical no-op", () => { - const doc = mint(cases.populated, catalog); + it("replays a row count op as a byte-identical no-op in either arrival order", () => { const shrink = edit("loras", 0); - expect(applyOps(doc, [shrink], catalog).outcomes[0]?.outcome).toBe("applied"); const grow = edit("loras", 2, 2); - expect(applyOps(doc, [grow], catalog).outcomes[0]?.outcome).toBe("applied"); - const projected = project(doc, catalog).nodes[0]!.widgets_values; - - for (const op of [shrink, grow]) { - const before = Y.encodeStateAsUpdate(doc); - expect(applyOps(doc, [op], catalog).outcomes[0]?.outcome).toBe("no-op"); - expect(Y.encodeStateAsUpdate(doc)).toEqual(before); + const arrivals = [ + { order: [shrink, grow], outcomes: ["applied", "applied"] }, + { order: [grow, shrink], outcomes: ["applied", "lww-dropped"] }, + ]; + for (const { order, outcomes } of arrivals) { + const doc = mint(cases.populated, catalog); + expect(order.map((op) => applyOps(doc, [op], catalog).outcomes[0]?.outcome)).toEqual(outcomes); + const projected = project(doc, catalog).nodes[0]!.widgets_values; + expect(projected).toEqual(cases.populated.nodes[0]!.widgets_values); + + for (const op of order) { + const before = Y.encodeStateAsUpdate(doc); + expect(applyOps(doc, [op], catalog).outcomes[0]?.outcome).toBe("no-op"); + expect(Y.encodeStateAsUpdate(doc)).toEqual(before); + } + expect(project(doc, catalog).nodes[0]!.widgets_values).toEqual(projected); + doc.destroy(); } - expect(project(doc, catalog).nodes[0]!.widgets_values).toEqual(projected); - doc.destroy(); }); it("converges when the row count and a row value arrive in either order", () => {