From 010f215a16511df422ef3c2f5bdcf94416d86abb Mon Sep 17 00:00:00 2001 From: EnragedAntelope Date: Sun, 8 Nov 2026 14:08:12 -0500 Subject: [PATCH] fix: honor combo control filter on PrimitiveNode - Link the control_filter_list widget to the PrimitiveNode value widget so value control reads the filter - Add regression test for filtered increment on a COMBO primitive --- src/extensions/core/widgetInputs.test.ts | 24 ++++++++++++++++++++++++ src/extensions/core/widgetInputs.ts | 9 +++++++-- 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/src/extensions/core/widgetInputs.test.ts b/src/extensions/core/widgetInputs.test.ts index 408e6d7e8b0..481911d62a2 100644 --- a/src/extensions/core/widgetInputs.test.ts +++ b/src/extensions/core/widgetInputs.test.ts @@ -189,6 +189,30 @@ describe('PrimitiveNode', () => { expect(primitive.widgets?.[1].value).toBe('fixed') }) + it('limits combo value control to values matching the filter', () => { + const values = ['moss_a', 'beta', 'moss_b'] + const graph = new LGraph() + const target = new LGraphNode('Target') + graph.add(target) + target.addInput('ckpt', 'COMBO') + target.inputs[0].widget = { + name: 'ckpt', + [GET_CONFIG]: () => [values, {}] + } + target.addWidget('combo', 'ckpt', 'moss_a', () => {}, { values }) + const primitive = new PrimitiveNode('Primitive') + graph.add(primitive) + primitive.connect(0, target, 0) + + const [value, control, filter] = primitive.widgets! + value.value = 'moss_a' + control.value = 'increment' + filter.value = 'moss' + control.afterQueued?.() + + expect(value.value).toBe('moss_b') + }) + it('does not apply a serialized value left over from an unresolved output type', () => { const graph = new LGraph() const target = new LGraphNode('Loader') diff --git a/src/extensions/core/widgetInputs.ts b/src/extensions/core/widgetInputs.ts index 1e0225f61d7..10031503504 100644 --- a/src/extensions/core/widgetInputs.ts +++ b/src/extensions/core/widgetInputs.ts @@ -319,8 +319,13 @@ export class PrimitiveNode extends LGraphNode { !inputData[1]?.control_after_generate && (widget.type === 'number' || widget.type === 'combo') ) { - addValueControlWidgets(this, widget, 'fixed', undefined, inputData) - if (this.widgets?.[1]) widget.linkedWidgets = [this.widgets[1]] + widget.linkedWidgets = addValueControlWidgets( + this, + widget, + 'fixed', + undefined, + inputData + ) } const controlValues = this.controlValues