From 7fc72b573e019a7345f0eef4032aa37437f9e5a2 Mon Sep 17 00:00:00 2001 From: Alexander Brown Date: Mon, 2 Nov 2026 23:52:51 +0000 Subject: [PATCH] chore: enable new Vue, Playwright, and Stylelint rules Amp-Thread-ID: https://ampcode.com/threads/T-4bd70dac-1393-41ec-91e9-b0950c6d350c --- .oxlintrc.json | 3 ++ .stylelintrc.json | 1 + .../agent/agentRefusedDocSubscribe.spec.ts | 2 +- eslint.config.ts | 2 ++ .../content/ConfirmationDialogContent.vue | 16 +++++---- .../parameters/SectionWidgets.vue | 18 +++++----- .../tabs/modelLibrary/ModelPreview.vue | 36 +++++++++++-------- src/components/topbar/WorkflowTabPopover.vue | 3 +- .../WorkflowTemplateSelectorDialog.vue | 7 ++-- .../vueNodes/components/InputSlot.vue | 4 +-- .../vueNodes/components/OutputSlot.vue | 4 +-- 11 files changed, 56 insertions(+), 40 deletions(-) diff --git a/.oxlintrc.json b/.oxlintrc.json index f3dd307370b..d1c4a8d11be 100644 --- a/.oxlintrc.json +++ b/.oxlintrc.json @@ -780,6 +780,8 @@ "playwright/no-eval": "error", "playwright/no-focused-test": "error", "playwright/no-force-option": "error", + "playwright/no-identical-title": "error", + "playwright/no-export": "error", "playwright/no-networkidle": "error", "playwright/no-page-pause": "error", "playwright/no-skipped-test": "error", @@ -796,6 +798,7 @@ "playwright/prefer-to-have-length": "error", "playwright/prefer-web-first-assertions": "error", "playwright/prefer-native-locators": "error", + "playwright/require-annotation-reason": "error", "playwright/require-to-pass-timeout": "error", "playwright/valid-expect": "error", "playwright/valid-expect-in-promise": "error", diff --git a/.stylelintrc.json b/.stylelintrc.json index 8d2fb3df4b9..a6da3be3e67 100644 --- a/.stylelintrc.json +++ b/.stylelintrc.json @@ -30,6 +30,7 @@ "shorthand-property-no-redundant-values": true, "selector-pseudo-element-colon-notation": "double", "no-duplicate-selectors": true, + "selector-no-unmatchable": true, "font-weight-notation": "numeric", "length-zero-no-unit": true, "color-no-invalid-hex": true, diff --git a/browser_tests/tests/agent/agentRefusedDocSubscribe.spec.ts b/browser_tests/tests/agent/agentRefusedDocSubscribe.spec.ts index 8400e89fb3b..93f8d6d6ff5 100644 --- a/browser_tests/tests/agent/agentRefusedDocSubscribe.spec.ts +++ b/browser_tests/tests/agent/agentRefusedDocSubscribe.spec.ts @@ -88,7 +88,7 @@ test.describe( ) exhaustedRetryTest.describe( - 'Agent doc subscribe refused by the host', + 'Agent doc subscribe retries exhausted', { tag: ['@cloud', '@agent', '@vue-nodes'] }, () => { exhaustedRetryTest.describe.configure({ timeout: 90_000 }) diff --git a/eslint.config.ts b/eslint.config.ts index 33758948712..e84a8c8013f 100644 --- a/eslint.config.ts +++ b/eslint.config.ts @@ -399,6 +399,8 @@ export default defineConfig([ 'vue/multi-word-component-names': 'off', // TODO: fix 'vue/no-template-shadow': 'off', // TODO: fix 'vue/match-component-import-name': 'error', + 'vue/no-content-outside-block': 'error', + 'vue/no-props-shadow': 'error', 'vue/no-unused-properties': 'error', 'vue/no-unused-refs': 'error', 'vue/no-useless-mustaches': 'error', diff --git a/src/components/dialog/content/ConfirmationDialogContent.vue b/src/components/dialog/content/ConfirmationDialogContent.vue index edf86536ff7..59074102cfb 100644 --- a/src/components/dialog/content/ConfirmationDialogContent.vue +++ b/src/components/dialog/content/ConfirmationDialogContent.vue @@ -58,14 +58,18 @@ {{ $t('g.cancel') }} - - @@ -91,7 +95,7 @@