From 085d6003961282b310b2ea6529f35184a39b152e Mon Sep 17 00:00:00 2001 From: bymyself Date: Mon, 2 Nov 2026 07:44:18 +0000 Subject: [PATCH] refactor: fold the placeholder check with reduceAllNodes (FRONT-3721) canvasHasRebuildablePlaceholder closed over a mutable flag inside forEachNode. reduceAllNodes already gives forEachNode a fold with the same subgraph walk, so use it instead of adding a new helper. --- .../useReconnectNodeDefinitionRefresh.ts | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/platform/customNodes/useReconnectNodeDefinitionRefresh.ts b/src/platform/customNodes/useReconnectNodeDefinitionRefresh.ts index cc85c25886e..aaa173071de 100644 --- a/src/platform/customNodes/useReconnectNodeDefinitionRefresh.ts +++ b/src/platform/customNodes/useReconnectNodeDefinitionRefresh.ts @@ -11,7 +11,7 @@ import { useWorkflowStore } from '@/platform/workflow/management/stores/workflow import { app } from '@/scripts/app' import { useCommandStore } from '@/platform/keybindings/commandStore' import { useNodeDefStore } from '@/stores/nodeDefStore' -import { forEachNode } from '@/utils/graphTraversalUtil' +import { reduceAllNodes } from '@/utils/graphTraversalUtil' import { useUserBusy } from './useUserBusy' @@ -35,12 +35,13 @@ function isRegistered(type: string): boolean { } function canvasHasRebuildablePlaceholder(): boolean { - let found = false - forEachNode(app.rootGraph, (node) => { - if (found || node.last_serialization === undefined) return - if (isRegistered(node.type)) found = true - }) - return found + return reduceAllNodes( + app.rootGraph, + (found, node) => + found || + (node.last_serialization !== undefined && isRegistered(node.type)), + false + ) } async function rebuildWhenIdle(