From e5bff85b116ca48c6042a8e792439b0d7a4baee0 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Sat, 31 Oct 2026 05:00:12 +0000 Subject: [PATCH] fix: tag agent audio failures with the agent surface (#22460) Follow-up to #22451, from its review. - `useWaveAudioPlayer` takes a `surface` option (default `assets`), and `ReplyAudioCard` passes `agent`, so agent reply failures are tagged correctly in telemetry. - Test: a waveform click right after a pause resumes playback. Fails if the check goes back to `playing`. - Test: the failed-source retry now depends on the reload. `play()` rejects until `load()` clears the error. (cherry picked from commit 98f9b60ce487fb5c538821e3fa4c6a283849ba5c) --- src/composables/useWaveAudioPlayer.test.ts | 55 +++++++++++++++++-- src/composables/useWaveAudioPlayer.ts | 12 +++- .../agent/message/ReplyAudioCard.vue | 6 +- 3 files changed, 65 insertions(+), 8 deletions(-) diff --git a/src/composables/useWaveAudioPlayer.test.ts b/src/composables/useWaveAudioPlayer.test.ts index 1178b51d755..a2889a6e729 100644 --- a/src/composables/useWaveAudioPlayer.test.ts +++ b/src/composables/useWaveAudioPlayer.test.ts @@ -310,14 +310,59 @@ describe('useWaveAudioPlayer', () => { it('reloads a failed source before retrying', async () => { const { audio, player } = await createPlayer() - Object.defineProperty(audio, 'error', { value: { code: 4 } }) - const load = vi.spyOn(audio, 'load').mockImplementation(() => {}) - const play = vi.spyOn(audio, 'play').mockResolvedValue(undefined) + let mediaError: { code: number } | null = { code: 4 } + Object.defineProperty(audio, 'error', { get: () => mediaError }) + const load = vi.spyOn(audio, 'load').mockImplementation(() => { + mediaError = null + }) + vi.spyOn(audio, 'play').mockImplementation(() => + mediaError ? Promise.reject(notSupported()) : Promise.resolve() + ) player.togglePlayPause() - await vi.waitFor(() => expect(play).toHaveBeenCalledTimes(1)) + await vi.waitFor(() => expect(load).toHaveBeenCalledTimes(1)) + await nextTick() + await nextTick() + + expect(useToast().toasts).toEqual([]) + }) + + it('reports failures on the caller surface', async () => { + vi.mocked(useMediaControls).mockReset() + const player = useWaveAudioPlayer({ + src: ref(''), + surface: 'agent', + waveform: false + }) + const audio = document.createElement('audio') + player.audioRef.value = audio + await nextTick() + vi.spyOn(audio, 'play').mockRejectedValue(notSupported()) + + player.togglePlayPause() + + await vi.waitFor(() => + expect(reportError).toHaveBeenCalledWith( + expect.any(DOMException), + expect.objectContaining({ surface: 'agent' }) + ) + ) + }) + + it('resumes from a waveform click right after a pause', async () => { + const { audio, player } = await createPlayer() + const play = vi.spyOn(audio, 'play').mockResolvedValue(undefined) + const waveform = document.createElement('div') + waveform.getBoundingClientRect = () => new DOMRect(0, 0, 100, 10) + player.waveformRef.value = waveform + await giveDuration(audio) + audio.dispatchEvent(new Event('play')) + await nextTick() + expect(player.isPlaying.value).toBe(true) + + player.handleWaveformClick(new MouseEvent('click')) - expect(load).toHaveBeenCalledTimes(1) + expect(play).toHaveBeenCalledTimes(1) }) it('stays silent when a play attempt is aborted', async () => { diff --git a/src/composables/useWaveAudioPlayer.ts b/src/composables/useWaveAudioPlayer.ts index 56b36e68481..923be10d09b 100644 --- a/src/composables/useWaveAudioPlayer.ts +++ b/src/composables/useWaveAudioPlayer.ts @@ -5,6 +5,7 @@ import type { Ref } from 'vue' import { useToast } from '@/components/ui/toast/toastStore' import { t } from '@/i18n' import { reportError } from '@/platform/telemetry/reportError' +import type { Surface } from '@/platform/telemetry/reportError' import { api } from '@/scripts/api' import { createToastId } from '@/types/toastId' import { formatTime } from '@/utils/formatUtil' @@ -16,12 +17,19 @@ interface WaveformBar { interface UseWaveAudioPlayerOptions { src: Readonly> logicalSrc?: Readonly> + surface?: Surface barCount?: number waveform?: boolean } export function useWaveAudioPlayer(options: UseWaveAudioPlayerOptions) { - const { src, logicalSrc = src, barCount = 40, waveform = true } = options + const { + src, + logicalSrc = src, + surface = 'assets', + barCount = 40, + waveform = true + } = options const audioRef = ref() const waveformRef = ref() @@ -147,7 +155,7 @@ export function useWaveAudioPlayer(options: UseWaveAudioPlayerOptions) { } reportError(error, { errorType: 'error_playing_audio', - surface: 'assets', + surface, level: 'warning' }) toast.error(t('g.error'), { diff --git a/src/workbench/extensions/agent/components/agent/message/ReplyAudioCard.vue b/src/workbench/extensions/agent/components/agent/message/ReplyAudioCard.vue index fd3b50b6933..eb42723a83b 100644 --- a/src/workbench/extensions/agent/components/agent/message/ReplyAudioCard.vue +++ b/src/workbench/extensions/agent/components/agent/message/ReplyAudioCard.vue @@ -27,7 +27,11 @@ const { volumeIcon, toggleMute, seekToRatio -} = useWaveAudioPlayer({ src: toRef(() => asset.url), waveform: false }) +} = useWaveAudioPlayer({ + src: toRef(() => asset.url), + surface: 'agent', + waveform: false +}) function onScrub(value: number[] | undefined): void { if (value?.length) seekToRatio(value[0] / 100)