From 1136521281e772e54adf4205d04654281d3362ea Mon Sep 17 00:00:00 2001 From: bymyself Date: Sat, 31 Oct 2026 14:32:18 +0000 Subject: [PATCH 1/2] docs(adr): record why the wire proof keeps its key-set check --- ...-0047-agent-wire-widget-form-is-proven-not-derived.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/docs/adr/WIDGET-SERIALIZATION-0047-agent-wire-widget-form-is-proven-not-derived.md b/docs/adr/WIDGET-SERIALIZATION-0047-agent-wire-widget-form-is-proven-not-derived.md index ba237950928..e3dbf4b81a3 100644 --- a/docs/adr/WIDGET-SERIALIZATION-0047-agent-wire-widget-form-is-proven-not-derived.md +++ b/docs/adr/WIDGET-SERIALIZATION-0047-agent-wire-widget-form-is-proven-not-derived.md @@ -134,6 +134,15 @@ declaration gap would bury the signal under every such class in the ecosystem. filtered post-hook named-value key set was rewritten by an extension no longer gets a form. Positional or private state the Agent wire does not send does not suppress the form. +- Two stricter checks from #22007 were tried and deliberately not adopted. + Refusing a form because a class overrides serialization, or because a hook + replaced the positional array, finds no wrong form on this wire: the proof + already reads the final `node.serialize()` result, `SubgraphNode` hosts carry + no `widgets_values_named` and never reach it, and positional data is not + sent. Both would also regress real nodes, because the host rejects named + values with no form on a class absent from the pinned catalog + (`uncatalogued_widget_write`). Revisit if the wire starts sending positional + values for a node that declares a form. - Invariant 4 turns "what fraction of the ecosystem declares a form" from an unanswerable question into a queryable one: `error_type` `agent_widget_form_undeclared`, tagged `node_type` and `reason`, From 494e183d704d6c33b5769cb25b5bebec98ffe860 Mon Sep 17 00:00:00 2001 From: bymyself Date: Sat, 31 Oct 2026 14:44:16 +0000 Subject: [PATCH 2/2] docs(adr): correct why subgraph hosts skip the proof --- ...-agent-wire-widget-form-is-proven-not-derived.md | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/docs/adr/WIDGET-SERIALIZATION-0047-agent-wire-widget-form-is-proven-not-derived.md b/docs/adr/WIDGET-SERIALIZATION-0047-agent-wire-widget-form-is-proven-not-derived.md index e3dbf4b81a3..f50ce3f8067 100644 --- a/docs/adr/WIDGET-SERIALIZATION-0047-agent-wire-widget-form-is-proven-not-derived.md +++ b/docs/adr/WIDGET-SERIALIZATION-0047-agent-wire-widget-form-is-proven-not-derived.md @@ -137,12 +137,13 @@ declaration gap would bury the signal under every such class in the ecosystem. - Two stricter checks from #22007 were tried and deliberately not adopted. Refusing a form because a class overrides serialization, or because a hook replaced the positional array, finds no wrong form on this wire: the proof - already reads the final `node.serialize()` result, `SubgraphNode` hosts carry - no `widgets_values_named` and never reach it, and positional data is not - sent. Both would also regress real nodes, because the host rejects named - values with no form on a class absent from the pinned catalog - (`uncatalogued_widget_write`). Revisit if the wire starts sending positional - values for a node that declares a form. + already reads the final `node.serialize()` result, a `SubgraphNode` host is a + virtual node that goes out positionally and never reaches the proof, and + positional data is not sent for a node that declares a form. Refusing would + also regress real nodes, because the host rejects named values with no form + on a class absent from the pinned catalog (`uncatalogued_widget_write`). + Revisit if the wire starts sending positional values for a node that declares + a form. - Invariant 4 turns "what fraction of the ecosystem declares a form" from an unanswerable question into a queryable one: `error_type` `agent_widget_form_undeclared`, tagged `node_type` and `reason`,