From ae7cdd2502018cd1cbc12eb0bc780920f5733450 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Fri, 30 Oct 2026 00:17:38 -0700 Subject: [PATCH] fix(agent): stale-page message no longer promises a reload shows the agent's changes (#22364) Stale-page message no longer promises a reload shows the agent's changes. - Reload can load the same build when the agent's server is ahead, so the promise was false - Now matches the agent's own notice (Comfy-Org/cloud#16975) - English string only; the locale job regenerates the others
Full context for agent readers **What changes.** `agent.workflowSyncFailedDetailStaleClient` in `src/locales/en/main.json`: - Before: "This page is out of date, so the agent's changes can't be shown. Reload the page to see them." - After: "This page can't display the current version of this document, so the agent's changes can't be shown here. They are kept. Reloading may fix this; if it doesn't, the update hasn't reached your app yet." **Why.** The message shows when the follower refuses a document whose schema is newer than this build reads. For an old tab a reload helps. When the agent's document server runs a newer schema than the frontend build production serves, a reload fetches the same bundle and the page stays unable to show the edits. https://github.com/Comfy-Org/cloud/pull/16975 already removed the same promise from the agent's notice, so on a skewed deploy the two messages disagreed. Wording copied from that notice ("kept", not "saved": the edits are drafts until committed). **Tests.** No logic changes. `browser_tests/tests/agent/agentSchemaSkewTellsTheUser.spec.ts` reads this key from `enMessages`, so it follows the new text. `workflowSyncErrorDetail.test.ts` stubs its own translation and does not assert the English text. `src/workbench/extensions/agent/crdt/**` is not touched. **Backports.** The key exists on every live train. Labelled for 1.57, 1.58 (production cloud) and 1.59. Not 1.56: no cloud traffic serves it and its other agent ports wait on a separate call. Linear: FRONT-3699 (related BE-21373, PM-2072).
--- src/locales/en/main.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/locales/en/main.json b/src/locales/en/main.json index 89a3b24cc60..7f3091b4903 100644 --- a/src/locales/en/main.json +++ b/src/locales/en/main.json @@ -6141,7 +6141,7 @@ "workflowSyncFailedTitle": "This workflow can't sync", "workflowSyncFailedDetail": "This workflow was created with an incompatible document version. Your canvas has been left unchanged.", "workflowSyncFailedDetailCatalogMismatch": "A node in this workflow has changed since the agent last saw it. Your canvas has been left unchanged. Your next message sends your canvas so the agent can rebuild its copy of the workflow.", - "workflowSyncFailedDetailStaleClient": "This page is out of date, so the agent's changes can't be shown. Reload the page to see them.", + "workflowSyncFailedDetailStaleClient": "This page can't display the current version of this document, so the agent's changes can't be shown here. They are kept. Reloading may fix this; if it doesn't, the update hasn't reached your app yet.", "workflowSyncFailedDetailStaleHost": "This page is ahead of the agent service, so the agent's changes can't be shown here yet. Reload the page once the service finishes updating to see them.", "runModeTriggerAutoLimit": "Auto (limited)", "runModeTriggerAutoLimitTooltip": "Ask when credit limit is reached",