From 5ce901bcc3375e5dd25e9199819c850f454b8039 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Tue, 27 Oct 2026 00:52:20 +0000 Subject: [PATCH] Link free-use notice to cost details (#22025) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary Point the free-use notice's “Learn more” link at the Agent documentation's `#what-it-costs` section. General Agent and consent links continue to open the page root. Follow-up to [DES-1221](https://linear.app/comfyorg/issue/DES-1221). ## Verification - `pnpm test:unit src/workbench/extensions/agent/components/agent/FreeUseNotice.test.ts --testTimeout=30000` (5 passed) - `PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://127.0.0.1:5178 PLAYWRIGHT_SETUP_API_URL=https://testcloud.comfy.org DISTRIBUTION=cloud pnpm exec playwright test browser_tests/tests/agent/agentFreeUsePlacement.spec.ts --project=cloud --workers=1 --retries=0` (2 passed) - Pre-commit formatting, lint, application typecheck, and browser typecheck passed. - Verified the published docs page contains the `what-it-costs` anchor. --- browser_tests/tests/agent/agentFreeUsePlacement.spec.ts | 6 ++++++ src/workbench/extensions/agent/agentDocs.ts | 2 ++ .../extensions/agent/components/agent/FreeUseNotice.test.ts | 2 +- .../extensions/agent/components/agent/FreeUseNotice.vue | 4 ++-- 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/browser_tests/tests/agent/agentFreeUsePlacement.spec.ts b/browser_tests/tests/agent/agentFreeUsePlacement.spec.ts index db2f6b63d2c..4698156df39 100644 --- a/browser_tests/tests/agent/agentFreeUsePlacement.spec.ts +++ b/browser_tests/tests/agent/agentFreeUsePlacement.spec.ts @@ -60,6 +60,12 @@ test.describe( 'the retired blanket-beta sentence is not appended' ).not.toContainText('during BETA') await expect(notice).toHaveAttribute('data-placement', PLACEMENT) + await expect( + notice.getByRole('link', { name: 'Learn more' }) + ).toHaveAttribute( + 'href', + 'https://docs.comfy.org/agent-tools/in-app-agent#what-it-costs' + ) const composer = agentPanel.root.getByTestId('agent-composer') await expect diff --git a/src/workbench/extensions/agent/agentDocs.ts b/src/workbench/extensions/agent/agentDocs.ts index 1eaf3fbbe4a..ddd6b583682 100644 --- a/src/workbench/extensions/agent/agentDocs.ts +++ b/src/workbench/extensions/agent/agentDocs.ts @@ -1 +1,3 @@ export const AGENT_DOCS_URL = 'https://docs.comfy.org/agent-tools/in-app-agent' + +export const AGENT_COST_DOCS_URL = `${AGENT_DOCS_URL}#what-it-costs` diff --git a/src/workbench/extensions/agent/components/agent/FreeUseNotice.test.ts b/src/workbench/extensions/agent/components/agent/FreeUseNotice.test.ts index abb0d74d97b..2bbf4f05e32 100644 --- a/src/workbench/extensions/agent/components/agent/FreeUseNotice.test.ts +++ b/src/workbench/extensions/agent/components/agent/FreeUseNotice.test.ts @@ -53,7 +53,7 @@ describe('FreeUseNotice', () => { expect(link).toHaveAttribute('target', '_blank') expect(link).toHaveAttribute( 'href', - 'https://docs.comfy.org/agent-tools/in-app-agent' + 'https://docs.comfy.org/agent-tools/in-app-agent#what-it-costs' ) }) diff --git a/src/workbench/extensions/agent/components/agent/FreeUseNotice.vue b/src/workbench/extensions/agent/components/agent/FreeUseNotice.vue index c9b722d1a2f..7e53e5a8ea2 100644 --- a/src/workbench/extensions/agent/components/agent/FreeUseNotice.vue +++ b/src/workbench/extensions/agent/components/agent/FreeUseNotice.vue @@ -9,7 +9,7 @@ import type { AgentFreeUseNoticeMetadata, AgentFreeUsePlacement } from '@/platform/telemetry/types' -import { AGENT_DOCS_URL } from '@/workbench/extensions/agent/agentDocs' +import { AGENT_COST_DOCS_URL } from '@/workbench/extensions/agent/agentDocs' import { freeUseNoticeDismissedKey } from './freeUseNoticeDismissal' @@ -65,7 +65,7 @@ function onDismiss(): void { variant="link" size="unset" as="a" - :href="AGENT_DOCS_URL" + :href="AGENT_COST_DOCS_URL" target="_blank" rel="noopener noreferrer" class="inline p-0 text-sm/5 font-normal text-foreground underline underline-offset-4"