diff --git a/.github/workflows/ci-tests-e2e.yaml b/.github/workflows/ci-tests-e2e.yaml index 6882b9441ec..5ee682ff64d 100644 --- a/.github/workflows/ci-tests-e2e.yaml +++ b/.github/workflows/ci-tests-e2e.yaml @@ -469,7 +469,7 @@ jobs: }} uses: ./.github/workflows/ci-tests-e2e-coverage-package.yaml with: - source_sha: ${{ github.event.pull_request.head.sha || github.sha }} + source_sha: ${{ github.sha }} # A shard that died partway still uploads a tracefile, and one that # produced none fails its own upload, so the matrix verdict is what # makes the merge trustworthy for trend reporting. diff --git a/scripts/cicd/package-e2e-coverage.test.ts b/scripts/cicd/package-e2e-coverage.test.ts index 3f1ccbb9893..46cd4837be7 100644 --- a/scripts/cicd/package-e2e-coverage.test.ts +++ b/scripts/cicd/package-e2e-coverage.test.ts @@ -356,6 +356,16 @@ describe('completeness gate wiring', () => { ) }) + it('packages coverage against the revision exercised by the workflow', () => { + const job = field( + readWorkflow('.github/workflows/ci-tests-e2e.yaml'), + 'jobs', + 'upload-e2e-coverage' + ) + + expect(field(job, 'with', 'source_sha')).toBe('${{ github.sha }}') + }) + it('gates the saved E2E baseline on a whole merge', () => { const steps = jobSteps( readWorkflow('.github/workflows/coverage-slack-notify.yaml')