From 02a55bd3c768a55e4a6c9d146619d33051285bb9 Mon Sep 17 00:00:00 2001 From: dante01yoon Date: Fri, 9 Oct 2026 20:09:24 -0400 Subject: [PATCH 1/2] test(workspace): orthogonality tests for members panel server-fact gates Add describeServerFactGate, which checks that a gate renders one server fact: perturbing any non-fact input leaves the output unchanged for either fact value, and flipping the fact changes it. Apply it to the Cloud invite gate (can_invite_members), the member-management gate (can_manage_members) and roster visibility (members response). --- .../composables/useMembersPanel.test.ts | 143 +++++++++++++++++- src/utils/__tests__/serverFactGate.ts | 53 +++++++ 2 files changed, 195 insertions(+), 1 deletion(-) create mode 100644 src/utils/__tests__/serverFactGate.ts diff --git a/src/platform/workspace/composables/useMembersPanel.test.ts b/src/platform/workspace/composables/useMembersPanel.test.ts index b6205cb1f04..c8c490ab2ca 100644 --- a/src/platform/workspace/composables/useMembersPanel.test.ts +++ b/src/platform/workspace/composables/useMembersPanel.test.ts @@ -19,6 +19,7 @@ import type { WorkspaceMember } from '@/platform/workspace/stores/teamWorkspaceStore' import { useTeamWorkspaceStore } from '@/platform/workspace/stores/teamWorkspaceStore' +import { describeServerFactGate } from '@/utils/__tests__/serverFactGate' import { filterBySearch, @@ -279,6 +280,7 @@ let workspaceStore: ReturnType & { let workspaceType: 'personal' | 'team' = 'personal' let workspaceMembers: WorkspaceMember[] = [] let workspacePendingInvites: WorkspacePendingInvite[] = [] +let workspaceMembersLoaded = true function updateWorkspaceStore() { workspaceStore.workspaces = [ @@ -294,7 +296,7 @@ function updateWorkspaceStore() { subscriptionTier: workspaceType === 'team' ? 'PRO' : 'FREE', members: workspaceMembers, pendingInvites: workspacePendingInvites, - membersLoaded: true, + membersLoaded: workspaceMembersLoaded, pendingInvitesLoaded: true } ] @@ -416,6 +418,7 @@ describe('useMembersPanel', () => { workspaceType = 'personal' workspaceMembers = [] workspacePendingInvites = [] + workspaceMembersLoaded = true updateWorkspaceStore() vi.mocked(useFeatureFlags().flags).memberCreditLimitsEnabled = true mockMaxSeats.value = 73 @@ -1409,4 +1412,142 @@ describe('useMembersPanel', () => { ).not.toHaveBeenCalled() }) }) + + function setCapability( + name: 'canInviteMembers' | 'canManageMembers' | 'canChangeSeats', + value: boolean + ) { + useBillingCapabilities()[name] = computed(() => value) + } + + function flipCapability( + name: 'canInviteMembers' | 'canManageMembers' | 'canChangeSeats' + ) { + setCapability(name, !useBillingCapabilities()[name].value) + } + + function endPlan() { + mockSubscriptionStatus.value = 'ended' + mockCanAccessSubscriptionFeatures.value = false + } + + const planAndRolePerturbations = [ + { name: 'an ended plan', apply: endPlan }, + { + name: 'an Enterprise tier', + apply: () => { + mockSubscription.value = { tier: 'ENTERPRISE', isCancelled: false } + } + }, + { + name: 'an ended Enterprise plan with one seat', + apply: () => { + endPlan() + mockSubscription.value = { tier: 'ENTERPRISE', isCancelled: false } + mockMaxSeats.value = 1 + } + }, + { + name: 'one seat', + apply: () => { + mockMaxSeats.value = 1 + } + }, + { + name: 'a personal plan', + apply: () => { + mockIsTeamPlan.value = false + } + }, + { + name: 'a scheduled cancellation', + apply: () => { + mockSubscriptionStatus.value = 'canceled' + mockSubscription.value = { tier: 'PRO', isCancelled: true } + } + }, + { + name: 'no subscription management', + apply: () => { + mockPermissions.value = { + ...mockPermissions.value, + canManageSubscription: false + } + } + }, + { + name: 'the member role', + apply: () => { + mockWorkspaceRole.value = 'member' + } + }, + { + name: 'a flipped can_change_seats', + apply: () => flipCapability('canChangeSeats') + } + ] + + describeServerFactGate({ + name: 'Invite (can_invite_members)', + fact: { set: (value) => setCapability('canInviteMembers', value) }, + perturbations: [ + ...planAndRolePerturbations, + { + name: 'a flipped can_manage_members', + apply: () => flipCapability('canManageMembers') + } + ], + mount: setup, + read: (panel) => ({ + showInviteButton: panel.showInviteButton.value, + isInviteDisabled: panel.isInviteDisabled.value, + canInviteMembers: panel.permissions.value.canInviteMembers + }) + }) + + describeServerFactGate({ + name: 'Member management (can_manage_members)', + fact: { set: (value) => setCapability('canManageMembers', value) }, + perturbations: [ + ...planAndRolePerturbations, + { + name: 'a flipped can_invite_members', + apply: () => flipCapability('canInviteMembers') + } + ], + mount: setup, + read: (panel) => ({ + canManageMembers: panel.permissions.value.canManageMembers, + canViewPendingInvites: panel.permissions.value.canViewPendingInvites, + showPendingTab: panel.uiConfig.value.showPendingTab, + hasMemberActions: panel.memberMenuItems(createMember()).length > 0 + }) + }) + + describeServerFactGate({ + name: 'Roster visibility (members response)', + fact: { + set: (loaded) => { + workspaceMembersLoaded = loaded + workspaceType = 'team' + mockMembers.value = [createMember(), createMember({ id: 'member-2' })] + } + }, + perturbations: [ + ...planAndRolePerturbations, + { + name: 'a flipped can_manage_members', + apply: () => flipCapability('canManageMembers') + }, + { + name: 'a flipped can_invite_members', + apply: () => flipCapability('canInviteMembers') + } + ], + mount: setup, + read: (panel) => ({ + canViewOtherMembers: panel.permissions.value.canViewOtherMembers, + showMembersList: panel.uiConfig.value.showMembersList + }) + }) }) diff --git a/src/utils/__tests__/serverFactGate.ts b/src/utils/__tests__/serverFactGate.ts new file mode 100644 index 00000000000..ca7ae88ee14 --- /dev/null +++ b/src/utils/__tests__/serverFactGate.ts @@ -0,0 +1,53 @@ +import { describe, expect, it } from 'vitest' + +interface Perturbation { + name: string + apply(): void +} + +interface ServerFactGate { + name: string + fact: { set(value: boolean): void } + perturbations: readonly Perturbation[] + mount(): Promise | T + read(subject: T): unknown +} + +const FACT_VALUES = [true, false] as const + +/** + * Orthogonality check for ADR-API-SERVER-FACTS-0042: a gate renders one + * server fact. Every perturbation of a non-fact input must leave `read()` + * unchanged for either fact value, and flipping the fact must change it. + */ +export function describeServerFactGate({ + name, + fact, + perturbations, + mount, + read +}: ServerFactGate) { + async function readWith(value: boolean, perturbation?: Perturbation) { + perturbation?.apply() + fact.set(value) + return read(await mount()) + } + + describe(`${name} renders one server fact`, () => { + const cases = FACT_VALUES.flatMap((value) => + perturbations.map((perturbation) => ({ value, perturbation })) + ) + + it.for(cases)( + 'ignores $perturbation.name when the fact is $value', + async ({ value, perturbation }) => { + const baseline = await readWith(value) + expect(await readWith(value, perturbation)).toEqual(baseline) + } + ) + + it('changes when the fact flips', async () => { + expect(await readWith(true)).not.toEqual(await readWith(false)) + }) + }) +} From 92e25f2ae4d83d3cf38d02ecf41a122e15e1db76 Mon Sep 17 00:00:00 2001 From: dante01yoon Date: Fri, 9 Oct 2026 20:09:55 -0400 Subject: [PATCH 2/2] chore(codeowners): own src/platform/workspace with the billing reviewers --- CODEOWNERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CODEOWNERS b/CODEOWNERS index 73af3b2f69c..7b9cf78ffff 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -83,6 +83,9 @@ /apps/website/src/config/workshop-balance.ts @dante01yoon @Comfy-Org/comfy_website_devs @Comfy-Org/comfy-standard-approver /apps/website/src/config/workshop-credits.ts @dante01yoon @Comfy-Org/comfy_website_devs @Comfy-Org/comfy-standard-approver +# Workspace members and billing gates - see ADR-API-SERVER-FACTS-0042. +/src/platform/workspace/ @dante01yoon @Comfy-Org/comfy_frontend_devs + /src/workbench/extensions/agent/ @Comfy-Org/comfy-standard-approver @Comfy-Org/comfy_frontend_devs @Comfy-Org/agent_devs /src/extensions/core/agentPanel.ts @Comfy-Org/comfy-standard-approver @Comfy-Org/comfy_frontend_devs @Comfy-Org/agent_devs /src/extensions/core/agentPanel.test.ts @Comfy-Org/comfy-standard-approver @Comfy-Org/comfy_frontend_devs @Comfy-Org/agent_devs