diff --git a/.github/actions/post-pr-report-comment/action.yaml b/.github/actions/post-pr-report-comment/action.yaml index 3adaae7f835..4fb9482b155 100644 --- a/.github/actions/post-pr-report-comment/action.yaml +++ b/.github/actions/post-pr-report-comment/action.yaml @@ -20,7 +20,7 @@ runs: steps: - name: Read report id: report - uses: juliangruber/read-file-action@b549046febe0fe86f8cb4f93c24e284433f9ab58 # v1.1.7 + uses: juliangruber/read-file-action@271ff311a4947af354c6abcd696a306553b9ec18 # v1.1.8 with: path: ${{ inputs.report-file }} diff --git a/.github/actions/read-and-upsert-comment-section/action.yaml b/.github/actions/read-and-upsert-comment-section/action.yaml index d703d52889b..5befb85ba1f 100644 --- a/.github/actions/read-and-upsert-comment-section/action.yaml +++ b/.github/actions/read-and-upsert-comment-section/action.yaml @@ -29,7 +29,7 @@ runs: - name: Read section file id: section if: ${{ hashFiles(inputs.section-file) != '' }} - uses: juliangruber/read-file-action@b549046febe0fe86f8cb4f93c24e284433f9ab58 # v1.1.7 + uses: juliangruber/read-file-action@271ff311a4947af354c6abcd696a306553b9ec18 # v1.1.8 with: path: ${{ inputs.section-file }} diff --git a/.github/actions/setup-frontend/action.yaml b/.github/actions/setup-frontend/action.yaml index 005e0b230c6..3b7d142235f 100644 --- a/.github/actions/setup-frontend/action.yaml +++ b/.github/actions/setup-frontend/action.yaml @@ -16,10 +16,10 @@ runs: # Install pnpm, Node.js, build frontend - name: Install pnpm - uses: pnpm/action-setup@0ebf47130e4866e96fce0953f49152a61190b271 # v6.0.9 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: ${{ inputs.node_cache == 'true' && 'pnpm' || '' }} diff --git a/.github/actions/setup-playwright/action.yaml b/.github/actions/setup-playwright/action.yaml index edf577d4014..14f53e73da5 100644 --- a/.github/actions/setup-playwright/action.yaml +++ b/.github/actions/setup-playwright/action.yaml @@ -16,7 +16,7 @@ runs: echo "playwright-version=$PLAYWRIGHT_VERSION" >> $GITHUB_OUTPUT - name: Restore Playwright Browsers - uses: actions/cache/restore@v5 # v5.0.2 + uses: actions/cache/restore@v6 id: cache-playwright-browsers with: path: '~/.cache/ms-playwright' @@ -55,7 +55,7 @@ runs: - name: Save Playwright Browsers if: steps.cache-playwright-browsers.outputs.cache-hit != 'true' - uses: actions/cache/save@v5 # v5.0.2 + uses: actions/cache/save@v6 with: path: '~/.cache/ms-playwright' key: ${{ runner.os }}-playwright-browsers-v2-${{ steps.detect-version.outputs.playwright-version }} diff --git a/.github/actions/tool-cache-restore/action.yml b/.github/actions/tool-cache-restore/action.yml index b8e2344d224..568d03a837f 100644 --- a/.github/actions/tool-cache-restore/action.yml +++ b/.github/actions/tool-cache-restore/action.yml @@ -39,7 +39,7 @@ runs: } >> "$GITHUB_OUTPUT" - name: Restore caches - uses: actions/cache/restore@v5 + uses: actions/cache/restore@v6 with: path: ${{ inputs.path }} key: ${{ steps.key.outputs.key }} diff --git a/.github/actions/tool-cache-save/action.yml b/.github/actions/tool-cache-save/action.yml index 42cdb2e6166..15bd7597eee 100644 --- a/.github/actions/tool-cache-save/action.yml +++ b/.github/actions/tool-cache-save/action.yml @@ -16,7 +16,7 @@ runs: using: composite steps: - name: Save caches - uses: actions/cache/save@v5 + uses: actions/cache/save@v6 with: path: ${{ inputs.path }} key: ${{ inputs.cache-key }} diff --git a/.github/dependabot.yml b/.github/dependabot.yml index c64eed56f13..098c7d087fe 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -67,12 +67,20 @@ updates: versions: ['>=20.10.0'] - package-ecosystem: 'github-actions' - directory: '/' + # '/' scans only .github/workflows, not the composite actions. + directories: + - '/' + - '/.github/actions/*' schedule: interval: 'weekly' labels: - 'dependencies' groups: + github-actions-major: + patterns: + - '*' + update-types: + - 'major' github-actions: patterns: - '*' diff --git a/.github/workflows/api-update-electron-api-types.yaml b/.github/workflows/api-update-electron-api-types.yaml index 22e1240001f..8cc166da3de 100644 --- a/.github/workflows/api-update-electron-api-types.yaml +++ b/.github/workflows/api-update-electron-api-types.yaml @@ -16,10 +16,10 @@ jobs: uses: actions/checkout@v7 - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: 'pnpm' diff --git a/.github/workflows/api-update-manager-api-types.yaml b/.github/workflows/api-update-manager-api-types.yaml index 47178f4428c..6c72ca0bd80 100644 --- a/.github/workflows/api-update-manager-api-types.yaml +++ b/.github/workflows/api-update-manager-api-types.yaml @@ -21,10 +21,10 @@ jobs: uses: actions/checkout@v7 - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: 'pnpm' diff --git a/.github/workflows/ci-billing-web-unit.yaml b/.github/workflows/ci-billing-web-unit.yaml index e20acb91717..501381c35bc 100644 --- a/.github/workflows/ci-billing-web-unit.yaml +++ b/.github/workflows/ci-billing-web-unit.yaml @@ -42,7 +42,7 @@ jobs: - name: Upload billing web coverage to Codecov if: ${{ !cancelled() }} - uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0 + uses: codecov/codecov-action@303a32d7a59b442fa8d48b6a1cc6825c09c847a5 # v7.1.1 with: working-directory: ./apps/billing-web files: ./coverage/lcov.info diff --git a/.github/workflows/ci-crdt-skew-alarm.yaml b/.github/workflows/ci-crdt-skew-alarm.yaml index 5fcd04ea0f3..d2742915a93 100644 --- a/.github/workflows/ci-crdt-skew-alarm.yaml +++ b/.github/workflows/ci-crdt-skew-alarm.yaml @@ -58,13 +58,13 @@ jobs: } >> "$GITHUB_OUTPUT" - name: Install pnpm - uses: pnpm/action-setup@0ebf47130e4866e96fce0953f49152a61190b271 # v6.0.9 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 # No pnpm store cache: this job installs and builds an unreviewed upstream # revision, and setup-node's post step would write it into a lockfile-keyed cache # that the publish workflows restore. - name: Setup Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' diff --git a/.github/workflows/ci-dist-telemetry-scan.yaml b/.github/workflows/ci-dist-telemetry-scan.yaml index dfcd6f45fc9..30155e2984a 100644 --- a/.github/workflows/ci-dist-telemetry-scan.yaml +++ b/.github/workflows/ci-dist-telemetry-scan.yaml @@ -32,10 +32,10 @@ jobs: - uses: actions/checkout@v7 - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Use Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: 'pnpm' diff --git a/.github/workflows/ci-ecosystem-matrix.yaml b/.github/workflows/ci-ecosystem-matrix.yaml index 16024251bf1..617914367fd 100644 --- a/.github/workflows/ci-ecosystem-matrix.yaml +++ b/.github/workflows/ci-ecosystem-matrix.yaml @@ -124,7 +124,7 @@ jobs: # commits nor changed validation rules can restore an older cache. - name: Restore corpus cache id: restore - uses: actions/cache/restore@caa296126883cff596d87d8935842f9db880ef25 # v5.1.0 + uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0 with: path: .census key: ${{ env.CORPUS_CACHE_PREFIX }}${{ hashFiles('scripts/registry-census/corpus.pins.json', 'scripts/registry-census/fetch_corpus.py', 'scripts/registry-census/validate_corpus.py') }} @@ -187,7 +187,7 @@ jobs: steps.restore.outputs.cache-hit != 'true' && steps.fetch.outcome == 'success' && hashFiles('.census/corpus.ready.json') != '' - uses: actions/cache/save@caa296126883cff596d87d8935842f9db880ef25 # v5.1.0 + uses: actions/cache/save@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0 with: path: .census key: ${{ env.CORPUS_CACHE_PREFIX }}${{ hashFiles('scripts/registry-census/corpus.pins.json', 'scripts/registry-census/fetch_corpus.py', 'scripts/registry-census/validate_corpus.py') }} @@ -272,7 +272,7 @@ jobs: # commits, and `corpus missing` further down is a much clearer failure # than a green verdict over the wrong packs. - name: Restore corpus cache - uses: actions/cache/restore@caa296126883cff596d87d8935842f9db880ef25 # v5.1.0 + uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0 with: path: .census key: ${{ env.CORPUS_CACHE_PREFIX }}${{ hashFiles('scripts/registry-census/corpus.pins.json', 'scripts/registry-census/fetch_corpus.py', 'scripts/registry-census/validate_corpus.py') }} @@ -428,7 +428,7 @@ jobs: # run's earlier attempt - metrics carry runId and the summarizer skips # the delta rather than compare a run against itself. - name: Restore baseline metrics - uses: actions/cache/restore@caa296126883cff596d87d8935842f9db880ef25 # v5.1.0 + uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0 with: path: matrix-metrics key: matrix-metrics-${{ matrix.renderer }}-${{ github.run_id }} @@ -470,7 +470,7 @@ jobs: && github.ref_name == github.event.repository.default_branch && steps.verdict.outcome == 'success' && hashFiles('matrix-metrics/metrics.json') != '' - uses: actions/cache/save@caa296126883cff596d87d8935842f9db880ef25 # v5.1.0 + uses: actions/cache/save@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0 with: path: matrix-metrics key: matrix-metrics-${{ matrix.renderer }}-${{ github.run_id }}-${{ github.run_attempt }} diff --git a/.github/workflows/ci-fallow.yaml b/.github/workflows/ci-fallow.yaml index d01365ca2d3..92b09795156 100644 --- a/.github/workflows/ci-fallow.yaml +++ b/.github/workflows/ci-fallow.yaml @@ -35,7 +35,7 @@ jobs: - name: Audit new findings id: audit - uses: fallow-rs/fallow@c2da9fcae5388226a87e986b1812f9c872d288c6 # v3.24.1 + uses: fallow-rs/fallow@71369f80d099e25726ad04382f15aef14a251abc # v3.31.0 with: command: audit version: '3.24.1' diff --git a/.github/workflows/ci-lockfile-repair.yaml b/.github/workflows/ci-lockfile-repair.yaml index a39da4ac6d8..5959ee428c6 100644 --- a/.github/workflows/ci-lockfile-repair.yaml +++ b/.github/workflows/ci-lockfile-repair.yaml @@ -41,12 +41,12 @@ jobs: base-sha: ${{ github.event.pull_request.base.sha }} - name: Install pnpm - uses: pnpm/action-setup@0ebf47130e4866e96fce0953f49152a61190b271 # v6.0.9 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 with: package_json_file: pull-request/package.json - name: Setup Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: pull-request/.nvmrc diff --git a/.github/workflows/ci-oss-assets-validation.yaml b/.github/workflows/ci-oss-assets-validation.yaml index 672574665fa..bd9e9fbc635 100644 --- a/.github/workflows/ci-oss-assets-validation.yaml +++ b/.github/workflows/ci-oss-assets-validation.yaml @@ -33,10 +33,10 @@ jobs: - uses: actions/checkout@v7 - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Use Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: 'pnpm' @@ -88,10 +88,10 @@ jobs: - uses: actions/checkout@v7 - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Use Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: 'pnpm' diff --git a/.github/workflows/ci-playwright-videos.yaml b/.github/workflows/ci-playwright-videos.yaml index fa475807272..98982468bcc 100644 --- a/.github/workflows/ci-playwright-videos.yaml +++ b/.github/workflows/ci-playwright-videos.yaml @@ -165,7 +165,7 @@ jobs: sparse-checkout-cone-mode: false persist-credentials: false - - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + - uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Download recording shards uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 diff --git a/.github/workflows/ci-tests-custom-nodes.yaml b/.github/workflows/ci-tests-custom-nodes.yaml index 8bb4ad97e0a..1998a91749f 100644 --- a/.github/workflows/ci-tests-custom-nodes.yaml +++ b/.github/workflows/ci-tests-custom-nodes.yaml @@ -274,7 +274,7 @@ jobs: # check - a stale or partial entry re-fetches. - name: Restore manifest pack cache id: pack-cache - uses: actions/cache/restore@v5 + uses: actions/cache/restore@v6 with: path: ~/.cache/cn-packs key: cn-packs-v3-${{ env.SHARD_SLUG }}-${{ hashFiles('browser_tests/fixtures/data/customNodeManifest.*.json') }} @@ -295,7 +295,7 @@ jobs: (github.event_name == 'schedule' || github.event_name == 'workflow_dispatch') && steps.prepare.outcome == 'success' && steps.pack-cache.outputs.cache-hit != 'true' - uses: actions/cache/save@v5 + uses: actions/cache/save@v6 with: path: ~/.cache/cn-packs key: cn-packs-v3-${{ env.SHARD_SLUG }}-${{ hashFiles('browser_tests/fixtures/data/customNodeManifest.*.json') }} diff --git a/.github/workflows/ci-tests-e2e-coverage.yaml b/.github/workflows/ci-tests-e2e-coverage.yaml index dd3fd4791ed..43b85e42129 100644 --- a/.github/workflows/ci-tests-e2e-coverage.yaml +++ b/.github/workflows/ci-tests-e2e-coverage.yaml @@ -70,7 +70,7 @@ jobs: steps.coverage.outputs.has-coverage == 'true' && (github.event.workflow_run.event != 'pull_request' || steps.pr-meta.outputs.skip != 'true') - uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0 + uses: codecov/codecov-action@303a32d7a59b442fa8d48b6a1cc6825c09c847a5 # v7.1.1 with: files: coverage/playwright/coverage.lcov flags: e2e diff --git a/.github/workflows/ci-tests-e2e.yaml b/.github/workflows/ci-tests-e2e.yaml index 9d3371d453d..e35fc16465d 100644 --- a/.github/workflows/ci-tests-e2e.yaml +++ b/.github/workflows/ci-tests-e2e.yaml @@ -370,7 +370,7 @@ jobs: persist-credentials: false - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Download blob reports uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 diff --git a/.github/workflows/ci-tests-unit.yaml b/.github/workflows/ci-tests-unit.yaml index bbb253e852c..f537be5ab11 100644 --- a/.github/workflows/ci-tests-unit.yaml +++ b/.github/workflows/ci-tests-unit.yaml @@ -125,7 +125,7 @@ jobs: - name: Upload coverage to Codecov if: always() - uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0 + uses: codecov/codecov-action@303a32d7a59b442fa8d48b6a1cc6825c09c847a5 # v7.1.1 with: files: coverage/lcov.info,packages/account-core/coverage/lcov.info,packages/account-ui/coverage/lcov.info,packages/billing-contract/coverage/lcov.info,packages/object-info-parser/coverage/lcov.info,packages/shared-frontend-utils/coverage/lcov.info,packages/design-system/coverage/lcov.info flags: unit diff --git a/.github/workflows/ci-update-comfyui-container.yaml b/.github/workflows/ci-update-comfyui-container.yaml index 785ef9a21b1..757fc1e7d85 100644 --- a/.github/workflows/ci-update-comfyui-container.yaml +++ b/.github/workflows/ci-update-comfyui-container.yaml @@ -145,13 +145,13 @@ jobs: if: > steps.versions.outputs.update == 'true' && steps.versions.outputs.playwright != steps.versions.outputs.current_playwright - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node.js if: > steps.versions.outputs.update == 'true' && steps.versions.outputs.playwright != steps.versions.outputs.current_playwright - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' diff --git a/.github/workflows/ci-validate-action-pins.yaml b/.github/workflows/ci-validate-action-pins.yaml index 9ac8343f0d7..2a6cfa864ec 100644 --- a/.github/workflows/ci-validate-action-pins.yaml +++ b/.github/workflows/ci-validate-action-pins.yaml @@ -11,11 +11,13 @@ on: - '.github/workflows/**' - '.github/actions/**' - '.pinact.yaml' + - 'scripts/check-action-versions.ts' pull_request: paths: - '.github/workflows/**' - '.github/actions/**' - '.pinact.yaml' + - 'scripts/check-action-versions.ts' permissions: contents: read @@ -26,6 +28,18 @@ jobs: steps: - uses: actions/checkout@v7 - - uses: suzuki-shunsuke/pinact-action@3d49c6412901042473ffa78becddab1aea46bbea # v1.3.1 + - uses: suzuki-shunsuke/pinact-action@896d595f299e71d65b9d28349d6956abe144390a # v3.0.0 with: + fix: 'false' skip_push: 'true' + + version-sync: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v7 + + - uses: actions/setup-node@v7 + with: + node-version-file: '.nvmrc' + + - run: node scripts/check-action-versions.ts diff --git a/.github/workflows/ci-vercel-billing-web-deploy.yaml b/.github/workflows/ci-vercel-billing-web-deploy.yaml index a793adb56b6..13b2d4fced2 100644 --- a/.github/workflows/ci-vercel-billing-web-deploy.yaml +++ b/.github/workflows/ci-vercel-billing-web-deploy.yaml @@ -76,10 +76,10 @@ jobs: uses: actions/checkout@v7 - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' @@ -123,10 +123,10 @@ jobs: uses: actions/checkout@v7 - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' diff --git a/.github/workflows/ci-vercel-billing-web-preview.yaml b/.github/workflows/ci-vercel-billing-web-preview.yaml index 01649b68b22..0f68d41aecd 100644 --- a/.github/workflows/ci-vercel-billing-web-preview.yaml +++ b/.github/workflows/ci-vercel-billing-web-preview.yaml @@ -64,10 +64,10 @@ jobs: uses: actions/checkout@v7 - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' diff --git a/.github/workflows/ci-vercel-website-preview.yaml b/.github/workflows/ci-vercel-website-preview.yaml index faa4502cc1e..0a5d11a4412 100644 --- a/.github/workflows/ci-vercel-website-preview.yaml +++ b/.github/workflows/ci-vercel-website-preview.yaml @@ -42,10 +42,10 @@ jobs: uses: actions/checkout@v7 - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' @@ -151,10 +151,10 @@ jobs: uses: actions/checkout@v7 - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' diff --git a/.github/workflows/ci-website-unit.yaml b/.github/workflows/ci-website-unit.yaml index cae0ff2eeef..44930a19c26 100644 --- a/.github/workflows/ci-website-unit.yaml +++ b/.github/workflows/ci-website-unit.yaml @@ -41,7 +41,7 @@ jobs: - name: Upload website coverage to Codecov if: ${{ !cancelled() }} - uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0 + uses: codecov/codecov-action@303a32d7a59b442fa8d48b6a1cc6825c09c847a5 # v7.1.1 with: working-directory: ./apps/website files: ./coverage/lcov.info diff --git a/.github/workflows/pr-claude-review.yaml b/.github/workflows/pr-claude-review.yaml index 0933f035d55..d3657cb0e08 100644 --- a/.github/workflows/pr-claude-review.yaml +++ b/.github/workflows/pr-claude-review.yaml @@ -29,10 +29,10 @@ jobs: ref: refs/pull/${{ github.event.pull_request.number }}/head - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: 'pnpm' @@ -42,7 +42,7 @@ jobs: pnpm add -g typescript @vue/compiler-sfc - name: Run Claude PR Review - uses: anthropics/claude-code-action@239e3a730883eeb5c53db12b0fc9573b3024b126 # v1.0.191 + uses: anthropics/claude-code-action@6c690188da61cf16ee7debb28383ba67f02abb4c # v1.0.242 with: label_trigger: 'claude-review' prompt: | diff --git a/.github/workflows/pr-lockfile-conflict-repair.yaml b/.github/workflows/pr-lockfile-conflict-repair.yaml index 31618255f11..bc29669ddbe 100644 --- a/.github/workflows/pr-lockfile-conflict-repair.yaml +++ b/.github/workflows/pr-lockfile-conflict-repair.yaml @@ -96,13 +96,13 @@ jobs: - name: Install pnpm if: steps.conflict.outputs.mode == 'merge' - uses: pnpm/action-setup@0ebf47130e4866e96fce0953f49152a61190b271 # v6.0.9 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 with: package_json_file: pull-request/package.json - name: Setup Node.js if: steps.conflict.outputs.mode == 'merge' - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: pull-request/.nvmrc diff --git a/.github/workflows/pr-playwright-videos.yaml b/.github/workflows/pr-playwright-videos.yaml index 7ddb6fe6d9c..879f8e50b47 100644 --- a/.github/workflows/pr-playwright-videos.yaml +++ b/.github/workflows/pr-playwright-videos.yaml @@ -46,7 +46,7 @@ jobs: repository: ${{ github.repository }} run-id: ${{ github.event.workflow_run.id }} - - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + - uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 if: steps.download.outcome == 'success' - name: Deploy video report diff --git a/.github/workflows/publish-design-system.yaml b/.github/workflows/publish-design-system.yaml index 9f314b77fa0..b8391d6cc7f 100644 --- a/.github/workflows/publish-design-system.yaml +++ b/.github/workflows/publish-design-system.yaml @@ -69,10 +69,10 @@ jobs: persist-credentials: false - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: 'pnpm' diff --git a/.github/workflows/publish-package.yaml b/.github/workflows/publish-package.yaml index 25243a6e778..4842dedddca 100644 --- a/.github/workflows/publish-package.yaml +++ b/.github/workflows/publish-package.yaml @@ -107,10 +107,10 @@ jobs: persist-credentials: false - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: 'pnpm' diff --git a/.github/workflows/release-branch-create.yaml b/.github/workflows/release-branch-create.yaml index 095ae87fe61..634b2721092 100644 --- a/.github/workflows/release-branch-create.yaml +++ b/.github/workflows/release-branch-create.yaml @@ -25,7 +25,7 @@ jobs: token: ${{ secrets.PR_GH_TOKEN || secrets.GITHUB_TOKEN }} - name: Setup Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' diff --git a/.github/workflows/release-draft-create.yaml b/.github/workflows/release-draft-create.yaml index 526548ec494..80c1ec0f1fc 100644 --- a/.github/workflows/release-draft-create.yaml +++ b/.github/workflows/release-draft-create.yaml @@ -22,9 +22,9 @@ jobs: uses: actions/checkout@v7 - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - - uses: actions/setup-node@v6 + - uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: 'pnpm' diff --git a/.github/workflows/release-npm-types.yaml b/.github/workflows/release-npm-types.yaml index 4291514583b..0a3ee0d7b64 100644 --- a/.github/workflows/release-npm-types.yaml +++ b/.github/workflows/release-npm-types.yaml @@ -75,10 +75,10 @@ jobs: fetch-depth: 1 - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: 'pnpm' diff --git a/.github/workflows/release-pypi-dev.yaml b/.github/workflows/release-pypi-dev.yaml index 2e69c948812..25b262ef897 100644 --- a/.github/workflows/release-pypi-dev.yaml +++ b/.github/workflows/release-pypi-dev.yaml @@ -18,9 +18,9 @@ jobs: uses: actions/checkout@v7 - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - - uses: actions/setup-node@v6 + - uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: 'pnpm' diff --git a/.github/workflows/release-recover-tag.yaml b/.github/workflows/release-recover-tag.yaml index 9d677c2907d..277f1c91051 100644 --- a/.github/workflows/release-recover-tag.yaml +++ b/.github/workflows/release-recover-tag.yaml @@ -49,9 +49,9 @@ jobs: echo "Recovering v${VERSION} on ${BRANCH}" - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - - uses: actions/setup-node@v6 + - uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: 'pnpm' diff --git a/.github/workflows/release-version-bump.yaml b/.github/workflows/release-version-bump.yaml index 2154033519c..fc59394d863 100644 --- a/.github/workflows/release-version-bump.yaml +++ b/.github/workflows/release-version-bump.yaml @@ -199,10 +199,10 @@ jobs: fi - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' diff --git a/.github/workflows/release-weekly-comfyui.yaml b/.github/workflows/release-weekly-comfyui.yaml index 34d11ef736a..a1327405c9a 100644 --- a/.github/workflows/release-weekly-comfyui.yaml +++ b/.github/workflows/release-weekly-comfyui.yaml @@ -107,12 +107,12 @@ jobs: path: comfyui - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 with: package_json_file: frontend/package.json - name: Setup Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: 'frontend/.nvmrc' @@ -255,11 +255,11 @@ jobs: path: release - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 with: package_json_file: release/package.json - - uses: actions/setup-node@v6 + - uses: actions/setup-node@v7 with: node-version-file: 'release/.nvmrc' cache: 'pnpm' diff --git a/.github/workflows/update-corpus-pins.yaml b/.github/workflows/update-corpus-pins.yaml index 2780be53c9b..48a376c3db0 100644 --- a/.github/workflows/update-corpus-pins.yaml +++ b/.github/workflows/update-corpus-pins.yaml @@ -70,7 +70,7 @@ jobs: PY - name: Open the bump PR - uses: peter-evans/create-pull-request@22a9089034f40e5a961c8808d113e2c98fb63676 # v7.0.11 + uses: peter-evans/create-pull-request@5f6978faf089d4d20b00c7766989d076bb2fc7f1 # v8.1.1 with: branch: chore/corpus-pins commit-message: 'chore: bump ecosystem matrix corpus pins' diff --git a/.github/workflows/version-bump-design-system.yaml b/.github/workflows/version-bump-design-system.yaml index 047a959a733..bcd74b526bf 100644 --- a/.github/workflows/version-bump-design-system.yaml +++ b/.github/workflows/version-bump-design-system.yaml @@ -31,10 +31,10 @@ jobs: persist-credentials: false - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: 'pnpm' diff --git a/.github/workflows/version-bump-package.yaml b/.github/workflows/version-bump-package.yaml index a7fa78b764d..37f48633ffd 100644 --- a/.github/workflows/version-bump-package.yaml +++ b/.github/workflows/version-bump-package.yaml @@ -36,10 +36,10 @@ jobs: persist-credentials: false - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: 'pnpm' diff --git a/.github/workflows/weekly-docs-check.yaml b/.github/workflows/weekly-docs-check.yaml index a744ad22e7c..fc1fb7dd77d 100644 --- a/.github/workflows/weekly-docs-check.yaml +++ b/.github/workflows/weekly-docs-check.yaml @@ -29,10 +29,10 @@ jobs: ref: main - name: Install pnpm - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 + uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - name: Setup Node.js - uses: actions/setup-node@v6 + uses: actions/setup-node@v7 with: node-version-file: '.nvmrc' cache: 'pnpm' @@ -48,7 +48,7 @@ jobs: fi - name: Run Claude Documentation Review - uses: anthropics/claude-code-action@239e3a730883eeb5c53db12b0fc9573b3024b126 # v1.0.191 + uses: anthropics/claude-code-action@6c690188da61cf16ee7debb28383ba67f02abb4c # v1.0.242 with: prompt: | Is all documentation still 100% accurate? diff --git a/.pinact.yaml b/.pinact.yaml index 72ae227905b..8338d4ba939 100644 --- a/.pinact.yaml +++ b/.pinact.yaml @@ -11,20 +11,23 @@ files: # Actions that don't need SHA pinning (official GitHub actions are trusted) ignore_actions: - name: actions/cache - ref: v5 + ref: 'v\d+' - name: actions/cache/restore - ref: v5 + ref: 'v\d+' - name: actions/cache/save - ref: v5 + ref: 'v\d+' - name: actions/checkout - ref: v7 + ref: 'v\d+' - name: actions/setup-node - ref: v6 + ref: 'v\d+' - name: actions/setup-python - ref: v6 + ref: 'v\d+' - name: actions/upload-artifact - ref: v6 + ref: 'v\d+' - name: actions/download-artifact - ref: v8 + ref: 'v\d+' - name: actions/github-script - ref: v9 + ref: 'v\d+' + # Reusable workflows pinned to a github-workflows main commit, which has no version tag. + - name: Comfy-Org/github-workflows/.* + ref: '[0-9a-f]{40}' diff --git a/scripts/check-action-versions.test.ts b/scripts/check-action-versions.test.ts new file mode 100644 index 00000000000..8af52934b01 --- /dev/null +++ b/scripts/check-action-versions.test.ts @@ -0,0 +1,74 @@ +import { describe, expect, it } from 'vitest' + +import { findVersionDrift } from './check-action-versions' + +const V5 = 'caa296126883cff596d87d8935842f9db880ef25 # v5.1.0' +const V6 = '55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0' +const V7_0_1 = '3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1' + +describe('findVersionDrift', () => { + it.for([ + { + name: 'sub-actions of one repo on different majors', + uses: [`actions/cache/restore@${V6}`, `actions/cache/save@${V5}`], + drifting: ['actions/cache'] + }, + { + name: 'two commits of the same major', + uses: [ + 'pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10', + 'pnpm/action-setup@0ebf47130e4866e96fce0953f49152a61190b271 # v6.0.9' + ], + drifting: ['pnpm/action-setup'] + }, + { + name: 'a floating major tag beside a commit pin of that major', + uses: ['actions/checkout@v7', `actions/checkout@${V7_0_1}`], + drifting: [] + }, + { + name: 'a floating major tag beside a commit pin of another major', + uses: ['actions/cache/restore@v5', `actions/cache/save@${V6}`], + drifting: ['actions/cache'] + }, + { + name: 'reusable workflows and local actions', + uses: [ + 'Comfy-Org/github-workflows/.github/workflows/a.yml@06f835f96accfd84d0a0929777d602837402608c', + 'Comfy-Org/github-workflows/.github/workflows/b.yml@ba2e67b68ddbf28c0d3af05a0213b12822a3bf68', + './.github/actions/setup-frontend' + ], + drifting: [] + } + ])('reports $name', ({ uses, drifting }) => { + const files = uses.map((use, index) => ({ + path: `.github/workflows/w${index}.yaml`, + contents: `jobs:\n job:\n steps:\n - uses: ${use}\n` + })) + + const report = findVersionDrift(files) + + expect(report.map((entry) => entry.split(' ')[0])).toEqual(drifting) + }) + + it('names each drifting use with its version and location', () => { + const [entry] = findVersionDrift([ + { + path: '.github/actions/a/action.yml', + contents: `runs:\n steps:\n - name: Restore\n uses: actions/cache/restore@${V6}\n` + }, + { + path: '.github/workflows/b.yaml', + contents: `steps:\n - uses: actions/cache/save@${V5}\n` + } + ]) + + expect(entry).toBe( + [ + 'actions/cache is used at more than one version:', + ' v6.1.0 .github/actions/a/action.yml:4', + ' v5.1.0 .github/workflows/b.yaml:2' + ].join('\n') + ) + }) +}) diff --git a/scripts/check-action-versions.ts b/scripts/check-action-versions.ts new file mode 100644 index 00000000000..6d9f710081a --- /dev/null +++ b/scripts/check-action-versions.ts @@ -0,0 +1,79 @@ +import { readdirSync, readFileSync } from 'node:fs' +import { join } from 'node:path' + +interface WorkflowFile { + path: string + contents: string +} + +interface ActionUse { + action: string + ref: string + version: string + location: string +} + +const USES_LINE = /^\s*(?:-\s+)?uses:\s*['"]?([^\s'"#]+)['"]?(?:\s+#\s*(\S+))?/ +const COMMIT_SHA = /^[0-9a-f]{40}$/ + +function parseUses({ path, contents }: WorkflowFile): ActionUse[] { + return contents.split('\n').flatMap((line, index) => { + const match = USES_LINE.exec(line) + if (!match) return [] + const [, target, comment] = match + const at = target.lastIndexOf('@') + if (target.startsWith('./') || target.startsWith('docker://') || at < 0) + return [] + if (target.includes('/.github/workflows/')) return [] + const ref = target.slice(at + 1) + const [owner, repo] = target.slice(0, at).split('/') + return [ + { + action: `${owner}/${repo}`.toLowerCase(), + ref, + version: COMMIT_SHA.test(ref) && comment ? comment : ref, + location: `${path}:${index + 1}` + } + ] + }) +} + +function majorOf(version: string): string { + return /^v?(\d+)/.exec(version)?.[1] ?? version +} + +function hasDrift(uses: ActionUse[]): boolean { + const majors = new Set(uses.map((use) => majorOf(use.version))) + const shas = new Set( + uses.map((use) => use.ref).filter((ref) => COMMIT_SHA.test(ref)) + ) + return majors.size > 1 || shas.size > 1 +} + +export function findVersionDrift(files: WorkflowFile[]): string[] { + const allUses = files.flatMap(parseUses) + return [...new Set(allUses.map((use) => use.action))] + .map((action) => allUses.filter((use) => use.action === action)) + .filter(hasDrift) + .map((uses) => + [ + `${uses[0].action} is used at more than one version:`, + ...uses.map((use) => ` ${use.version} ${use.location}`) + ].join('\n') + ) +} + +if (import.meta.main) { + const root = '.github' + const files = readdirSync(root, { recursive: true, encoding: 'utf8' }) + .filter((file) => /^(workflows|actions)\/.*\.ya?ml$/.test(file)) + .map((file) => ({ + path: join(root, file), + contents: readFileSync(join(root, file), 'utf8') + })) + const drift = findVersionDrift(files) + if (drift.length > 0) { + process.stderr.write(`${drift.join('\n\n')}\n`) + process.exitCode = 1 + } +}